| Message ID | 20210504205139.1055360-6-thomas.petazzoni@bootlin.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Support for the BeagleV platform | expand |
On 2021-05-04 22:51 +0200, Thomas Petazzoni spake thusly: > This commit adds a package for the DDR initialization code used on the > BeagleV platform. The upstream package name is beaglev-ddrlnit, yes, with an 'l' instead of an 'i'. I've renamed the package to match upstream name, so that users that look for it can actually find it. Applied to master, thanks. Regards, Yann E. MORIN. > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > --- > DEVELOPERS | 1 + > boot/Config.in | 1 + > boot/beaglev-ddrinit/Config.in | 9 ++++++++ > boot/beaglev-ddrinit/beaglev-ddrinit.mk | 29 +++++++++++++++++++++++++ > 4 files changed, 40 insertions(+) > create mode 100644 boot/beaglev-ddrinit/Config.in > create mode 100644 boot/beaglev-ddrinit/beaglev-ddrinit.mk > > diff --git a/DEVELOPERS b/DEVELOPERS > index 7ce78742fc..39bc71ea34 100644 > --- a/DEVELOPERS > +++ b/DEVELOPERS > @@ -2604,6 +2604,7 @@ N: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > F: arch/Config.in.arm > F: board/beaglev/ > F: board/stmicroelectronics/stm32mp157c-dk2/ > +F: boot/beaglev-ddrinit/ > F: boot/boot-wrapper-aarch64/ > F: boot/grub2/ > F: boot/gummiboot/ > diff --git a/boot/Config.in b/boot/Config.in > index b3adbfc8bc..f581205c6c 100644 > --- a/boot/Config.in > +++ b/boot/Config.in > @@ -6,6 +6,7 @@ source "boot/at91bootstrap3/Config.in" > source "boot/at91dataflashboot/Config.in" > source "boot/arm-trusted-firmware/Config.in" > source "boot/barebox/Config.in" > +source "boot/beaglev-ddrinit/Config.in" > source "boot/binaries-marvell/Config.in" > source "boot/boot-wrapper-aarch64/Config.in" > source "boot/grub2/Config.in" > diff --git a/boot/beaglev-ddrinit/Config.in b/boot/beaglev-ddrinit/Config.in > new file mode 100644 > index 0000000000..5392f49088 > --- /dev/null > +++ b/boot/beaglev-ddrinit/Config.in > @@ -0,0 +1,9 @@ > +config BR2_TARGET_BEAGLEV_DDRINIT > + bool "beaglev-ddrinit" > + depends on BR2_riscv > + depends on BR2_HOSTARCH = "x86_64" # host-riscv64-elf-toolchain > + help > + This package builds the DDRinit firmware used on the BeagleV > + platform. > + > + https://github.com/starfive-tech/beagle_ddrlnit > diff --git a/boot/beaglev-ddrinit/beaglev-ddrinit.mk b/boot/beaglev-ddrinit/beaglev-ddrinit.mk > new file mode 100644 > index 0000000000..72e6aea965 > --- /dev/null > +++ b/boot/beaglev-ddrinit/beaglev-ddrinit.mk > @@ -0,0 +1,29 @@ > +################################################################################ > +# > +# beaglev-ddrinit > +# > +################################################################################ > + > +# HEAD of the starfive branch > +BEAGLEV_DDRINIT_VERSION = 15b80de81263996affb2a29332aa681925709983 > +BEAGLEV_DDRINIT_SITE = $(call github,starfive-tech,beagle_ddrlnit,$(BEAGLEV_DDRINIT_VERSION)) > +BEAGLEV_DDRINIT_INSTALL_TARGET = NO > +BEAGLEV_DDRINIT_INSTALL_IMAGES = YES > +BEAGLEV_DDRINIT_DEPENDENCIES = host-riscv64-elf-toolchain > +# unfortunately, no real license file, but several sources files are > +# under GPL-2.0+, making the whole work GPL-2.0+ > +BEAGLEV_DDRINIT_LICENSE = GPL-2.0+ > + > +define BEAGLEV_DDRINIT_BUILD_CMDS > + $(MAKE) -C $(@D)/build \ > + CROSSCOMPILE=$(HOST_DIR)/bin/riscv64-unknown-elf- \ > + SUFFIX=buildroot \ > + GIT_VERSION=$(BEAGLEV_DDRINIT_VERSION) > +endef > + > +define BEAGLEV_DDRINIT_INSTALL_IMAGES_CMDS > + $(INSTALL) -D -m 0644 $(@D)/build/ddrinit-2133-buildroot.bin.out \ > + $(BINARIES_DIR)/ddrinit-2133-buildroot.bin.out > +endef > + > +$(eval $(generic-package)) > -- > 2.30.2 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Thomas, All, On 2021-05-08 00:04 +0200, Yann E. MORIN spake thusly: > On 2021-05-04 22:51 +0200, Thomas Petazzoni spake thusly: > > This commit adds a package for the DDR initialization code used on the > > BeagleV platform. > > The upstream package name is beaglev-ddrlnit, yes, with an 'l' instead > of an 'i'. I've renamed the package to match upstream name, so that > users that look for it can actually find it. I've also added a hash file. Also, the comment was stating "HEAD of the starfive branch", but it was HEAD only at the time you wrote it. It already is no longer HEAD. So I changed the comment, but kept the hash as-is, since that what you tested. Feel free to send a bump if it makes sense. > Applied to master, thanks. > > Regards, > Yann E. MORIN. > > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > > --- > > DEVELOPERS | 1 + > > boot/Config.in | 1 + > > boot/beaglev-ddrinit/Config.in | 9 ++++++++ > > boot/beaglev-ddrinit/beaglev-ddrinit.mk | 29 +++++++++++++++++++++++++ > > 4 files changed, 40 insertions(+) > > create mode 100644 boot/beaglev-ddrinit/Config.in > > create mode 100644 boot/beaglev-ddrinit/beaglev-ddrinit.mk > > > > diff --git a/DEVELOPERS b/DEVELOPERS > > index 7ce78742fc..39bc71ea34 100644 > > --- a/DEVELOPERS > > +++ b/DEVELOPERS > > @@ -2604,6 +2604,7 @@ N: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > > F: arch/Config.in.arm > > F: board/beaglev/ > > F: board/stmicroelectronics/stm32mp157c-dk2/ > > +F: boot/beaglev-ddrinit/ > > F: boot/boot-wrapper-aarch64/ > > F: boot/grub2/ > > F: boot/gummiboot/ > > diff --git a/boot/Config.in b/boot/Config.in > > index b3adbfc8bc..f581205c6c 100644 > > --- a/boot/Config.in > > +++ b/boot/Config.in > > @@ -6,6 +6,7 @@ source "boot/at91bootstrap3/Config.in" > > source "boot/at91dataflashboot/Config.in" > > source "boot/arm-trusted-firmware/Config.in" > > source "boot/barebox/Config.in" > > +source "boot/beaglev-ddrinit/Config.in" > > source "boot/binaries-marvell/Config.in" > > source "boot/boot-wrapper-aarch64/Config.in" > > source "boot/grub2/Config.in" > > diff --git a/boot/beaglev-ddrinit/Config.in b/boot/beaglev-ddrinit/Config.in > > new file mode 100644 > > index 0000000000..5392f49088 > > --- /dev/null > > +++ b/boot/beaglev-ddrinit/Config.in > > @@ -0,0 +1,9 @@ > > +config BR2_TARGET_BEAGLEV_DDRINIT > > + bool "beaglev-ddrinit" > > + depends on BR2_riscv > > + depends on BR2_HOSTARCH = "x86_64" # host-riscv64-elf-toolchain > > + help > > + This package builds the DDRinit firmware used on the BeagleV > > + platform. > > + > > + https://github.com/starfive-tech/beagle_ddrlnit > > diff --git a/boot/beaglev-ddrinit/beaglev-ddrinit.mk b/boot/beaglev-ddrinit/beaglev-ddrinit.mk > > new file mode 100644 > > index 0000000000..72e6aea965 > > --- /dev/null > > +++ b/boot/beaglev-ddrinit/beaglev-ddrinit.mk > > @@ -0,0 +1,29 @@ > > +################################################################################ > > +# > > +# beaglev-ddrinit > > +# > > +################################################################################ > > + > > +# HEAD of the starfive branch > > +BEAGLEV_DDRINIT_VERSION = 15b80de81263996affb2a29332aa681925709983 > > +BEAGLEV_DDRINIT_SITE = $(call github,starfive-tech,beagle_ddrlnit,$(BEAGLEV_DDRINIT_VERSION)) > > +BEAGLEV_DDRINIT_INSTALL_TARGET = NO > > +BEAGLEV_DDRINIT_INSTALL_IMAGES = YES > > +BEAGLEV_DDRINIT_DEPENDENCIES = host-riscv64-elf-toolchain > > +# unfortunately, no real license file, but several sources files are > > +# under GPL-2.0+, making the whole work GPL-2.0+ > > +BEAGLEV_DDRINIT_LICENSE = GPL-2.0+ > > + > > +define BEAGLEV_DDRINIT_BUILD_CMDS > > + $(MAKE) -C $(@D)/build \ > > + CROSSCOMPILE=$(HOST_DIR)/bin/riscv64-unknown-elf- \ > > + SUFFIX=buildroot \ > > + GIT_VERSION=$(BEAGLEV_DDRINIT_VERSION) > > +endef > > + > > +define BEAGLEV_DDRINIT_INSTALL_IMAGES_CMDS > > + $(INSTALL) -D -m 0644 $(@D)/build/ddrinit-2133-buildroot.bin.out \ > > + $(BINARIES_DIR)/ddrinit-2133-buildroot.bin.out > > +endef > > + > > +$(eval $(generic-package)) > > -- > > 2.30.2 > > > > _______________________________________________ > > buildroot mailing list > > buildroot@busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------' > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
On Fri, May 7, 2021, 15:04 Yann E. MORIN <yann.morin.1998@free.fr> wrote: > On 2021-05-04 22:51 +0200, Thomas Petazzoni spake thusly: > > This commit adds a package for the DDR initialization code used on the > > BeagleV platform. > > The upstream package name is beaglev-ddrlnit, yes, with an 'l' instead > of an 'i'. I've renamed the package to match upstream name, so that > users that look for it can actually find it. > > Applied to master, thanks. > > Regards, > Yann E. MORIN. Would it be helpful if I get StarFive to fix the typo and rename it to ddrinit? I am thinking that would probably be good to have happen before other projects start pointing to it. Thomas was so fast with the buildroot patches I think it is the first to notice this. Thank you, Drew >
Drew, All, On 2021-05-07 16:30 -0700, Drew Fustini spake thusly: > On Fri, May 7, 2021, 15:04 Yann E. MORIN < [1]yann.morin.1998@free.fr> wrote: > On 2021-05-04 22:51 +0200, Thomas Petazzoni spake thusly: > > This commit adds a package for the DDR initialization code used on the > > BeagleV platform. > > The upstream package name is beaglev-ddrlnit, yes, with an 'l' instead > of an 'i'. I've renamed the package to match upstream name, so that > users that look for it can actually find it. > Would it be helpful if I get StarFive to fix the typo and rename it to ddrinit? > I am thinking that would probably be good to have happen before other projects > start pointing to it. Thomas was so fast with the buildroot patches I think it > is the first to notice this. It is not so important that the upstream name gets fixed; in fact quite the opposite: we are now already referencing it. Granted, it's brand new, and we can fix it quick before the release. But note that our 2021.05-rc1 is due this WE, for example; we can still fix this kind of thing post rc1, of course, but we can't fix a release... But as you mention, once other projects start referencing it, it will be too late. For example, Khem Raj already has started such support: https://github.com/riscv/meta-riscv/blob/master/beaglev.yml https://github.com/YoeDistro/yoe-distro/blob/master/beaglev-starlight-jh7100-envsetup.sh So even if it is still very early, I think it is already too late to rename the repository... Regards, Yann E. MORIN.
On Sat, May 8, 2021 at 12:37 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > Drew, All, > > On 2021-05-07 16:30 -0700, Drew Fustini spake thusly: > > On Fri, May 7, 2021, 15:04 Yann E. MORIN < [1]yann.morin.1998@free.fr> wrote: > > On 2021-05-04 22:51 +0200, Thomas Petazzoni spake thusly: > > > This commit adds a package for the DDR initialization code used on the > > > BeagleV platform. > > > > The upstream package name is beaglev-ddrlnit, yes, with an 'l' instead > > of an 'i'. I've renamed the package to match upstream name, so that > > users that look for it can actually find it. > > Would it be helpful if I get StarFive to fix the typo and rename it to ddrinit? > > I am thinking that would probably be good to have happen before other projects > > start pointing to it. Thomas was so fast with the buildroot patches I think it > > is the first to notice this. > > It is not so important that the upstream name gets fixed; in fact quite > the opposite: we are now already referencing it. Granted, it's brand > new, and we can fix it quick before the release. But note that our > 2021.05-rc1 is due this WE, for example; we can still fix this kind of > thing post rc1, of course, but we can't fix a release... > > But as you mention, once other projects start referencing it, it will be > too late. For example, Khem Raj already has started such support: > > https://github.com/riscv/meta-riscv/blob/master/beaglev.yml > https://github.com/YoeDistro/yoe-distro/blob/master/beaglev-starlight-jh7100-envsetup.sh > > So even if it is still very early, I think it is already too late to > rename the repository... Ok, thank you for the insights. I agree more important to have the release go forward and not risk breaking references. My goal is that ddrinit will eventually be replaced with u-boot SPL anyways. Bin Meng is actively looking into this right now. Thank you, Drew
On Sat, May 8, 2021 at 12:48 AM Drew Fustini <drew@beagleboard.org> wrote: > > On Sat, May 8, 2021 at 12:37 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > > > Drew, All, > > > > On 2021-05-07 16:30 -0700, Drew Fustini spake thusly: > > > On Fri, May 7, 2021, 15:04 Yann E. MORIN < [1]yann.morin.1998@free.fr> wrote: > > > On 2021-05-04 22:51 +0200, Thomas Petazzoni spake thusly: > > > > This commit adds a package for the DDR initialization code used on the > > > > BeagleV platform. > > > > > > The upstream package name is beaglev-ddrlnit, yes, with an 'l' instead > > > of an 'i'. I've renamed the package to match upstream name, so that > > > users that look for it can actually find it. > > > Would it be helpful if I get StarFive to fix the typo and rename it to ddrinit? > > > I am thinking that would probably be good to have happen before other projects > > > start pointing to it. Thomas was so fast with the buildroot patches I think it > > > is the first to notice this. > > > > It is not so important that the upstream name gets fixed; in fact quite > > the opposite: we are now already referencing it. Granted, it's brand > > new, and we can fix it quick before the release. But note that our > > 2021.05-rc1 is due this WE, for example; we can still fix this kind of > > thing post rc1, of course, but we can't fix a release... > > > > But as you mention, once other projects start referencing it, it will be > > too late. For example, Khem Raj already has started such support: > > > > https://github.com/riscv/meta-riscv/blob/master/beaglev.yml > > https://github.com/YoeDistro/yoe-distro/blob/master/beaglev-starlight-jh7100-envsetup.sh > > > > So even if it is still very early, I think it is already too late to > > rename the repository... Is there general consensus on what it should be called ? I am happy to remove references to SOC name, if we have clear naming convention and strategy to also name future iterations of beagleV based on RISCV > > Ok, thank you for the insights. I agree more important to have the > release go forward and not risk breaking references. My goal is that > ddrinit will eventually be replaced with u-boot SPL anyways. Bin Meng > is actively looking into this right now. > > Thank you, > Drew
Khem, All, On 2021-05-08 09:01 -0700, Khem Raj spake thusly: > On Sat, May 8, 2021 at 12:48 AM Drew Fustini <drew@beagleboard.org> wrote: > > On Sat, May 8, 2021 at 12:37 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > > On 2021-05-07 16:30 -0700, Drew Fustini spake thusly: > > > > On Fri, May 7, 2021, 15:04 Yann E. MORIN < [1]yann.morin.1998@free.fr> wrote: > > > > The upstream package name is beaglev-ddrlnit, yes, with an 'l' instead > > > > of an 'i'. [...] > > > > Would it be helpful if I get StarFive to fix the typo and rename it to ddrinit? > > > It is not so important that the upstream name gets fixed; [...] > Is there general consensus on what it should be called ? > I am happy to remove references to SOC name, if we have clear naming > convention and strategy to also name future iterations of beagleV based on RISCV Khem: note that we were speaking about a typo in one of the upstream repositories: beaglev-ddrlnit (dee-dee-are-ell-hen-eye-tee) instead of ddrinit (dee-dee-are-eye-hen-eye-tee). But Drew said this should be a short-term repository, which will eventually get phased out in favour of uboot spl. I am not sure what kind of level support OE so far has for BeagleV, and whether it uses that repository or not, but I used your layers just as a hint that it is too late (IMHO) to rename repositories upstream... And as far as I understand, BeagleV is named BeagleV, and the SoC is JH7100. So your layers/scripts seemed to be aptly named. ;-) Regards, Yann E. MORIN.
Hello, On Sat, 8 May 2021 00:04:01 +0200 "Yann E. MORIN" <yann.morin.1998@free.fr> wrote: > On 2021-05-04 22:51 +0200, Thomas Petazzoni spake thusly: > > This commit adds a package for the DDR initialization code used on the > > BeagleV platform. > > The upstream package name is beaglev-ddrlnit, yes, with an 'l' instead > of an 'i'. I've renamed the package to match upstream name, so that > users that look for it can actually find it. Ah, in fact I had only seen the package name on github with a font where the l and I are pretty much the same, so I thought it was named ddrInit (with a capital 'I') and I normalized that to 'ddrinit' was we like lower-case name in Buildroot packages. But indeed, I see that the repository is named ddrlnit. I'm wondering if this isn't just a mistake, because then everywhere it is referred to as ddrinit. ddrlnit doesn't make much sense to me. But fair enough, for now it's named beaglev-ddrlnit so our Buildroot package should follow that naming. Best regards, Thomas
On Sat, May 8, 2021 at 11:21 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > Khem, All, > > On 2021-05-08 09:01 -0700, Khem Raj spake thusly: > > On Sat, May 8, 2021 at 12:48 AM Drew Fustini <drew@beagleboard.org> wrote: > > > On Sat, May 8, 2021 at 12:37 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > > > On 2021-05-07 16:30 -0700, Drew Fustini spake thusly: > > > > > On Fri, May 7, 2021, 15:04 Yann E. MORIN < [1] yann.morin.1998@free.fr> wrote: > > > > > The upstream package name is beaglev-ddrlnit, yes, with an 'l' instead > > > > > of an 'i'. [...] > > > > > Would it be helpful if I get StarFive to fix the typo and rename it to ddrinit? > > > > It is not so important that the upstream name gets fixed; [...] > > Is there general consensus on what it should be called ? > > I am happy to remove references to SOC name, if we have clear naming > > convention and strategy to also name future iterations of beagleV based on RISCV > > Khem: note that we were speaking about a typo in one of the upstream > repositories: beaglev-ddrlnit (dee-dee-are-ell-hen-eye-tee) instead of > ddrinit (dee-dee-are-eye-hen-eye-tee). > > But Drew said this should be a short-term repository, which will > eventually get phased out in favour of uboot spl. Bin Meng is trying to get u-boot SPL working on the StarFive JH7100 SoC and that could replace ddrinit. Although I am not sure exactly when that goal will be accomplished. StarFive will fix the 'l' typo in the ddrinit repo if I ask them to, but they probably would not get that done until Monday or Tuesday. It seemed like from your previous email it would be best to avoid that churn of renaming the repository as the patch already went into buildroot. I am happy to do whatever is best for buildroot and also Khem's meta-riscv OE layer. Thank you, Drew
On Sat, May 8, 2021 at 9:02 AM Khem Raj <raj.khem@gmail.com> wrote: > > On Sat, May 8, 2021 at 12:48 AM Drew Fustini <drew@beagleboard.org> wrote: > > > > On Sat, May 8, 2021 at 12:37 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > > > > > Drew, All, > > > > > > On 2021-05-07 16:30 -0700, Drew Fustini spake thusly: > > > > On Fri, May 7, 2021, 15:04 Yann E. MORIN < [1]yann.morin.1998@free.fr> wrote: > > > > On 2021-05-04 22:51 +0200, Thomas Petazzoni spake thusly: > > > > > This commit adds a package for the DDR initialization code used on the > > > > > BeagleV platform. > > > > > > > > The upstream package name is beaglev-ddrlnit, yes, with an 'l' instead > > > > of an 'i'. I've renamed the package to match upstream name, so that > > > > users that look for it can actually find it. > > > > Would it be helpful if I get StarFive to fix the typo and rename it to ddrinit? > > > > I am thinking that would probably be good to have happen before other projects > > > > start pointing to it. Thomas was so fast with the buildroot patches I think it > > > > is the first to notice this. > > > > > > It is not so important that the upstream name gets fixed; in fact quite > > > the opposite: we are now already referencing it. Granted, it's brand > > > new, and we can fix it quick before the release. But note that our > > > 2021.05-rc1 is due this WE, for example; we can still fix this kind of > > > thing post rc1, of course, but we can't fix a release... > > > > > > But as you mention, once other projects start referencing it, it will be > > > too late. For example, Khem Raj already has started such support: > > > > > > https://github.com/riscv/meta-riscv/blob/master/beaglev.yml > > > https://github.com/YoeDistro/yoe-distro/blob/master/beaglev-starlight-jh7100-envsetup.sh > > > > > > So even if it is still very early, I think it is already too late to > > > rename the repository... > > Is there general consensus on what it should be called ? > I am happy to remove references to SOC name, if we have clear naming > convention and strategy to also name future iterations of beagleV based on RISCV The board that Thomas and you received is the beta prototype version of BeagleV Starlight board with the StarFive JH7100 SoC, which is a low quantity test SoC. BeagleV is BeagleBoard.org Foundation's name for RISC-V boards. BeagleV Starlight is a BeagleBoard.org board with a StarFive RISC-V SoC. The production BeagleV Starlight will have the StarFive JH7110, the mass production SoC. Due to the different SoC models, BeagleV Starlight JH7100 would refer to the beta prototype, and BeagleV Starlight JH7110 would be the product that will be launched later this year. That README is the best public URL to reference in documentation and patches and it includes guidance on naming conventions: https://github.com/beagleboard/beaglev-starlight#guidance-on-naming-conventions Thanks. Drew
Hi Drew On Sat, May 8, 2021 at 2:10 PM Drew Fustini <drew@beagleboard.org> wrote: > > On Sat, May 8, 2021 at 9:02 AM Khem Raj <raj.khem@gmail.com> wrote: > > > > On Sat, May 8, 2021 at 12:48 AM Drew Fustini <drew@beagleboard.org> wrote: > > > > > > On Sat, May 8, 2021 at 12:37 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > > > > > > > Drew, All, > > > > > > > > On 2021-05-07 16:30 -0700, Drew Fustini spake thusly: > > > > > On Fri, May 7, 2021, 15:04 Yann E. MORIN < [1]yann.morin.1998@free.fr> wrote: > > > > > On 2021-05-04 22:51 +0200, Thomas Petazzoni spake thusly: > > > > > > This commit adds a package for the DDR initialization code used on the > > > > > > BeagleV platform. > > > > > > > > > > The upstream package name is beaglev-ddrlnit, yes, with an 'l' instead > > > > > of an 'i'. I've renamed the package to match upstream name, so that > > > > > users that look for it can actually find it. > > > > > Would it be helpful if I get StarFive to fix the typo and rename it to ddrinit? > > > > > I am thinking that would probably be good to have happen before other projects > > > > > start pointing to it. Thomas was so fast with the buildroot patches I think it > > > > > is the first to notice this. > > > > > > > > It is not so important that the upstream name gets fixed; in fact quite > > > > the opposite: we are now already referencing it. Granted, it's brand > > > > new, and we can fix it quick before the release. But note that our > > > > 2021.05-rc1 is due this WE, for example; we can still fix this kind of > > > > thing post rc1, of course, but we can't fix a release... > > > > > > > > But as you mention, once other projects start referencing it, it will be > > > > too late. For example, Khem Raj already has started such support: > > > > > > > > https://github.com/riscv/meta-riscv/blob/master/beaglev.yml > > > > https://github.com/YoeDistro/yoe-distro/blob/master/beaglev-starlight-jh7100-envsetup.sh > > > > > > > > So even if it is still very early, I think it is already too late to > > > > rename the repository... > > > > Is there general consensus on what it should be called ? > > I am happy to remove references to SOC name, if we have clear naming > > convention and strategy to also name future iterations of beagleV based on RISCV > > The board that Thomas and you received is the beta prototype version > of BeagleV Starlight board with the StarFive JH7100 SoC, which is a > low quantity test SoC. BeagleV is BeagleBoard.org Foundation's name > for RISC-V boards. BeagleV Starlight is a BeagleBoard.org board with > a StarFive RISC-V SoC. > > The production BeagleV Starlight will have the StarFive JH7110, the > mass production SoC. Due to the different SoC models, BeagleV > Starlight JH7100 would refer to the beta prototype, and BeagleV > Starlight JH7110 would be the product that will be launched later this > year. > > That README is the best public URL to reference in documentation and > patches and it includes guidance on naming conventions: > https://github.com/beagleboard/beaglev-starlight#guidance-on-naming-conventions So perhaps we could call this machine as beaglev-beta ? and the final one beaglev in Yocto machine names ? I am not sure adding SOC info adds some meaningful information, unless you plan to have other SOCs also in beagleV boards variants > > Thanks. > Drew
On 08/05/2021 00:04, Yann E. MORIN wrote: > On 2021-05-04 22:51 +0200, Thomas Petazzoni spake thusly: >> This commit adds a package for the DDR initialization code used on the >> BeagleV platform. > > The upstream package name is beaglev-ddrlnit, yes, with an 'l' instead > of an 'i'. I've renamed the package to match upstream name, so that > users that look for it can actually find it. What's done is done of course, but in this case, I think we should have stuck to ddrinit with an eye. That name makes much more sense, and in fact when people search for it (with / in menuconfig) they're IMHO much more likely to search for it with an eye than with an el. The el you'd probably only use when you copy and paste the name from github, but who does that? @Drew/Bing, on github, when you rename a repository, the old name will still redirect to the new one (at least until you create a new repo with that name). So I'd go ahead and to the rename to ddrinit, it should break anything. Regards, Arnout > > Applied to master, thanks. > > Regards, > Yann E. MORIN. > >> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> >> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> >> --- >> DEVELOPERS | 1 + >> boot/Config.in | 1 + >> boot/beaglev-ddrinit/Config.in | 9 ++++++++ >> boot/beaglev-ddrinit/beaglev-ddrinit.mk | 29 +++++++++++++++++++++++++ >> 4 files changed, 40 insertions(+) >> create mode 100644 boot/beaglev-ddrinit/Config.in >> create mode 100644 boot/beaglev-ddrinit/beaglev-ddrinit.mk >> >> diff --git a/DEVELOPERS b/DEVELOPERS >> index 7ce78742fc..39bc71ea34 100644 >> --- a/DEVELOPERS >> +++ b/DEVELOPERS >> @@ -2604,6 +2604,7 @@ N: Thomas Petazzoni <thomas.petazzoni@bootlin.com> >> F: arch/Config.in.arm >> F: board/beaglev/ >> F: board/stmicroelectronics/stm32mp157c-dk2/ >> +F: boot/beaglev-ddrinit/ >> F: boot/boot-wrapper-aarch64/ >> F: boot/grub2/ >> F: boot/gummiboot/ >> diff --git a/boot/Config.in b/boot/Config.in >> index b3adbfc8bc..f581205c6c 100644 >> --- a/boot/Config.in >> +++ b/boot/Config.in >> @@ -6,6 +6,7 @@ source "boot/at91bootstrap3/Config.in" >> source "boot/at91dataflashboot/Config.in" >> source "boot/arm-trusted-firmware/Config.in" >> source "boot/barebox/Config.in" >> +source "boot/beaglev-ddrinit/Config.in" >> source "boot/binaries-marvell/Config.in" >> source "boot/boot-wrapper-aarch64/Config.in" >> source "boot/grub2/Config.in" >> diff --git a/boot/beaglev-ddrinit/Config.in b/boot/beaglev-ddrinit/Config.in >> new file mode 100644 >> index 0000000000..5392f49088 >> --- /dev/null >> +++ b/boot/beaglev-ddrinit/Config.in >> @@ -0,0 +1,9 @@ >> +config BR2_TARGET_BEAGLEV_DDRINIT >> + bool "beaglev-ddrinit" >> + depends on BR2_riscv >> + depends on BR2_HOSTARCH = "x86_64" # host-riscv64-elf-toolchain >> + help >> + This package builds the DDRinit firmware used on the BeagleV >> + platform. >> + >> + https://github.com/starfive-tech/beagle_ddrlnit >> diff --git a/boot/beaglev-ddrinit/beaglev-ddrinit.mk b/boot/beaglev-ddrinit/beaglev-ddrinit.mk >> new file mode 100644 >> index 0000000000..72e6aea965 >> --- /dev/null >> +++ b/boot/beaglev-ddrinit/beaglev-ddrinit.mk >> @@ -0,0 +1,29 @@ >> +################################################################################ >> +# >> +# beaglev-ddrinit >> +# >> +################################################################################ >> + >> +# HEAD of the starfive branch >> +BEAGLEV_DDRINIT_VERSION = 15b80de81263996affb2a29332aa681925709983 >> +BEAGLEV_DDRINIT_SITE = $(call github,starfive-tech,beagle_ddrlnit,$(BEAGLEV_DDRINIT_VERSION)) >> +BEAGLEV_DDRINIT_INSTALL_TARGET = NO >> +BEAGLEV_DDRINIT_INSTALL_IMAGES = YES >> +BEAGLEV_DDRINIT_DEPENDENCIES = host-riscv64-elf-toolchain >> +# unfortunately, no real license file, but several sources files are >> +# under GPL-2.0+, making the whole work GPL-2.0+ >> +BEAGLEV_DDRINIT_LICENSE = GPL-2.0+ >> + >> +define BEAGLEV_DDRINIT_BUILD_CMDS >> + $(MAKE) -C $(@D)/build \ >> + CROSSCOMPILE=$(HOST_DIR)/bin/riscv64-unknown-elf- \ >> + SUFFIX=buildroot \ >> + GIT_VERSION=$(BEAGLEV_DDRINIT_VERSION) >> +endef >> + >> +define BEAGLEV_DDRINIT_INSTALL_IMAGES_CMDS >> + $(INSTALL) -D -m 0644 $(@D)/build/ddrinit-2133-buildroot.bin.out \ >> + $(BINARIES_DIR)/ddrinit-2133-buildroot.bin.out >> +endef >> + >> +$(eval $(generic-package)) >> -- >> 2.30.2 >> >> _______________________________________________ >> buildroot mailing list >> buildroot@busybox.net >> http://lists.busybox.net/mailman/listinfo/buildroot >
On 09/05/2021 13:03, Arnout Vandecappelle wrote: > > > On 08/05/2021 00:04, Yann E. MORIN wrote: >> On 2021-05-04 22:51 +0200, Thomas Petazzoni spake thusly: >>> This commit adds a package for the DDR initialization code used on the >>> BeagleV platform. >> >> The upstream package name is beaglev-ddrlnit, yes, with an 'l' instead >> of an 'i'. I've renamed the package to match upstream name, so that >> users that look for it can actually find it. > > What's done is done of course, but in this case, I think we should have stuck > to ddrinit with an eye. That name makes much more sense, and in fact when people > search for it (with / in menuconfig) they're IMHO much more likely to search for > it with an eye than with an el. The el you'd probably only use when you copy and > paste the name from github, but who does that? > > > @Drew/Bing, on github, when you rename a repository, the old name will still > redirect to the new one (at least until you create a new repo with that name). > So I'd go ahead and to the rename to ddrinit, it should break anything. I forgot the reference: https://docs.github.com/en/github/administering-a-repository/renaming-a-repository Regards, Arnout
On Sat, May 8, 2021, 15:10 Khem Raj <raj.khem@gmail.com> wrote: > > Hi Drew > > On Sat, May 8, 2021 at 2:10 PM Drew Fustini <drew@beagleboard.org> wrote: > > > > On Sat, May 8, 2021 at 9:02 AM Khem Raj <raj.khem@gmail.com> wrote: > > > > > > On Sat, May 8, 2021 at 12:48 AM Drew Fustini <drew@beagleboard.org> wrote: > > > > > > > > On Sat, May 8, 2021 at 12:37 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > > > > > > > > > Drew, All, > > > > > > > > > > On 2021-05-07 16:30 -0700, Drew Fustini spake thusly: > > > > > > On Fri, May 7, 2021, 15:04 Yann E. MORIN < [1]yann.morin.1998@free.fr> wrote: > > > > > > On 2021-05-04 22:51 +0200, Thomas Petazzoni spake thusly: > > > > > > > This commit adds a package for the DDR initialization code used on the > > > > > > > BeagleV platform. > > > > > > > > > > > > The upstream package name is beaglev-ddrlnit, yes, with an 'l' instead > > > > > > of an 'i'. I've renamed the package to match upstream name, so that > > > > > > users that look for it can actually find it. > > > > > > Would it be helpful if I get StarFive to fix the typo and rename it to ddrinit? > > > > > > I am thinking that would probably be good to have happen before other projects > > > > > > start pointing to it. Thomas was so fast with the buildroot patches I think it > > > > > > is the first to notice this. > > > > > > > > > > It is not so important that the upstream name gets fixed; in fact quite > > > > > the opposite: we are now already referencing it. Granted, it's brand > > > > > new, and we can fix it quick before the release. But note that our > > > > > 2021.05-rc1 is due this WE, for example; we can still fix this kind of > > > > > thing post rc1, of course, but we can't fix a release... > > > > > > > > > > But as you mention, once other projects start referencing it, it will be > > > > > too late. For example, Khem Raj already has started such support: > > > > > > > > > > https://github.com/riscv/meta-riscv/blob/master/beaglev.yml > > > > > https://github.com/YoeDistro/yoe-distro/blob/master/beaglev-starlight-jh7100-envsetup.sh > > > > > > > > > > So even if it is still very early, I think it is already too late to > > > > > rename the repository... > > > > > > Is there general consensus on what it should be called ? > > > I am happy to remove references to SOC name, if we have clear naming > > > convention and strategy to also name future iterations of beagleV based on RISCV > > > > The board that Thomas and you received is the beta prototype version > > of BeagleV Starlight board with the StarFive JH7100 SoC, which is a > > low quantity test SoC. BeagleV is BeagleBoard.org Foundation's name > > for RISC-V boards. BeagleV Starlight is a BeagleBoard.org board with > > a StarFive RISC-V SoC. > > > > The production BeagleV Starlight will have the StarFive JH7110, the > > mass production SoC. Due to the different SoC models, BeagleV > > Starlight JH7100 would refer to the beta prototype, and BeagleV > > Starlight JH7110 would be the product that will be launched later this > > year. > > > > That README is the best public URL to reference in documentation and > > patches and it includes guidance on naming conventions: > > https://github.com/beagleboard/beaglev-starlight#guidance-on-naming-conventions > > So perhaps we could call this machine as beaglev-beta ? and the final > one beaglev in Yocto machine names ? > I am not sure adding SOC info adds some meaningful information, unless > you plan to have other SOCs also in > beagleV boards variants BeagleV is a name that will exist for long into the future for any BeagleBoard.org board with a RISC-V processor. Therefore I think beaglev-starlight-beta would be a good machine name which would represent the beta version of BeagleV Starlight with StarFive JH7100 SoC. Machine beagle-starlight could then represent the production BeagleV Starlight with StarFive JH7110 SoC. Thank you, Drew
On Sun, May 9, 2021 at 1:23 PM Drew Fustini <drew@beagleboard.org> wrote: > > On Sat, May 8, 2021, 15:10 Khem Raj <raj.khem@gmail.com> wrote: > > > > Hi Drew > > > > On Sat, May 8, 2021 at 2:10 PM Drew Fustini <drew@beagleboard.org> wrote: > > > > > > On Sat, May 8, 2021 at 9:02 AM Khem Raj <raj.khem@gmail.com> wrote: > > > > > > > > On Sat, May 8, 2021 at 12:48 AM Drew Fustini <drew@beagleboard.org> wrote: > > > > > > > > > > On Sat, May 8, 2021 at 12:37 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > > > > > > > > > > > Drew, All, > > > > > > > > > > > > On 2021-05-07 16:30 -0700, Drew Fustini spake thusly: > > > > > > > On Fri, May 7, 2021, 15:04 Yann E. MORIN < [1]yann.morin.1998@free.fr> wrote: > > > > > > > On 2021-05-04 22:51 +0200, Thomas Petazzoni spake thusly: > > > > > > > > This commit adds a package for the DDR initialization code used on the > > > > > > > > BeagleV platform. > > > > > > > > > > > > > > The upstream package name is beaglev-ddrlnit, yes, with an 'l' instead > > > > > > > of an 'i'. I've renamed the package to match upstream name, so that > > > > > > > users that look for it can actually find it. > > > > > > > Would it be helpful if I get StarFive to fix the typo and rename it to ddrinit? > > > > > > > I am thinking that would probably be good to have happen before other projects > > > > > > > start pointing to it. Thomas was so fast with the buildroot patches I think it > > > > > > > is the first to notice this. > > > > > > > > > > > > It is not so important that the upstream name gets fixed; in fact quite > > > > > > the opposite: we are now already referencing it. Granted, it's brand > > > > > > new, and we can fix it quick before the release. But note that our > > > > > > 2021.05-rc1 is due this WE, for example; we can still fix this kind of > > > > > > thing post rc1, of course, but we can't fix a release... > > > > > > > > > > > > But as you mention, once other projects start referencing it, it will be > > > > > > too late. For example, Khem Raj already has started such support: > > > > > > > > > > > > https://github.com/riscv/meta-riscv/blob/master/beaglev.yml > > > > > > https://github.com/YoeDistro/yoe-distro/blob/master/beaglev-starlight-jh7100-envsetup.sh > > > > > > > > > > > > So even if it is still very early, I think it is already too late to > > > > > > rename the repository... > > > > > > > > Is there general consensus on what it should be called ? > > > > I am happy to remove references to SOC name, if we have clear naming > > > > convention and strategy to also name future iterations of beagleV based on RISCV > > > > > > The board that Thomas and you received is the beta prototype version > > > of BeagleV Starlight board with the StarFive JH7100 SoC, which is a > > > low quantity test SoC. BeagleV is BeagleBoard.org Foundation's name > > > for RISC-V boards. BeagleV Starlight is a BeagleBoard.org board with > > > a StarFive RISC-V SoC. > > > > > > The production BeagleV Starlight will have the StarFive JH7110, the > > > mass production SoC. Due to the different SoC models, BeagleV > > > Starlight JH7100 would refer to the beta prototype, and BeagleV > > > Starlight JH7110 would be the product that will be launched later this > > > year. > > > > > > That README is the best public URL to reference in documentation and > > > patches and it includes guidance on naming conventions: > > > https://github.com/beagleboard/beaglev-starlight#guidance-on-naming-conventions > > > > So perhaps we could call this machine as beaglev-beta ? and the final > > one beaglev in Yocto machine names ? > > I am not sure adding SOC info adds some meaningful information, unless > > you plan to have other SOCs also in > > beagleV boards variants > > BeagleV is a name that will exist for long into the future for any > BeagleBoard.org board with a RISC-V processor. Therefore I think > beaglev-starlight-beta would be a good machine name which would > represent the beta version of BeagleV Starlight with StarFive JH7100 > SoC. Machine beagle-starlight could then represent the production > BeagleV Starlight with StarFive JH7110 SoC. OK, but I was also thinking that tomorrow there might be a different starlight soc in beagleV next version in future so perhal beaglev-<SOC-Vendor>-<SOC-name> might be future proof > > Thank you, > Drew
On Sun, May 9, 2021 at 4:04 AM Arnout Vandecappelle <arnout@mind.be> wrote: > > > > On 09/05/2021 13:03, Arnout Vandecappelle wrote: > > > > > > On 08/05/2021 00:04, Yann E. MORIN wrote: > >> On 2021-05-04 22:51 +0200, Thomas Petazzoni spake thusly: > >>> This commit adds a package for the DDR initialization code used on the > >>> BeagleV platform. > >> > >> The upstream package name is beaglev-ddrlnit, yes, with an 'l' instead > >> of an 'i'. I've renamed the package to match upstream name, so that > >> users that look for it can actually find it. > > > > What's done is done of course, but in this case, I think we should have stuck > > to ddrinit with an eye. That name makes much more sense, and in fact when people > > search for it (with / in menuconfig) they're IMHO much more likely to search for > > it with an eye than with an el. The el you'd probably only use when you copy and > > paste the name from github, but who does that? > > > > > > @Drew/Bing, on github, when you rename a repository, the old name will still > > redirect to the new one (at least until you create a new repo with that name). > > So I'd go ahead and to the rename to ddrinit, it should break anything. > > I forgot the reference: > > https://docs.github.com/en/github/administering-a-repository/renaming-a-repository Thank you. I knew that the redirect worked on the website, but this clarifies that it also works for git clone as well. Therefore, it seems like I should ask starfive to fix the typo as the old repo url with the typo will still work. -Drew
On Sun, May 9, 2021 at 1:29 PM Drew Fustini <drew@beagleboard.org> wrote: > > On Sun, May 9, 2021 at 4:04 AM Arnout Vandecappelle <arnout@mind.be> wrote: > > > > > > > > On 09/05/2021 13:03, Arnout Vandecappelle wrote: > > > > > > > > > On 08/05/2021 00:04, Yann E. MORIN wrote: > > >> On 2021-05-04 22:51 +0200, Thomas Petazzoni spake thusly: > > >>> This commit adds a package for the DDR initialization code used on the > > >>> BeagleV platform. > > >> > > >> The upstream package name is beaglev-ddrlnit, yes, with an 'l' instead > > >> of an 'i'. I've renamed the package to match upstream name, so that > > >> users that look for it can actually find it. > > > > > > What's done is done of course, but in this case, I think we should have stuck > > > to ddrinit with an eye. That name makes much more sense, and in fact when people > > > search for it (with / in menuconfig) they're IMHO much more likely to search for > > > it with an eye than with an el. The el you'd probably only use when you copy and > > > paste the name from github, but who does that? > > > > > > > > > @Drew/Bing, on github, when you rename a repository, the old name will still > > > redirect to the new one (at least until you create a new repo with that name). > > > So I'd go ahead and to the rename to ddrinit, it should break anything. > > > > I forgot the reference: > > > > https://docs.github.com/en/github/administering-a-repository/renaming-a-repository > > Thank you. I knew that the redirect worked on the website, but this > clarifies that it also works for git clone as well. Therefore, it > seems like I should ask starfive to fix the typo as the old repo url > with the typo will still work. yes renaming in github repos should be painless w.r.t. redirects IIRC > > -Drew
On Sun, May 9, 2021 at 1:27 PM Khem Raj <raj.khem@gmail.com> wrote: > > On Sun, May 9, 2021 at 1:23 PM Drew Fustini <drew@beagleboard.org> wrote: > > > > On Sat, May 8, 2021, 15:10 Khem Raj <raj.khem@gmail.com> wrote: > > > > > > Hi Drew > > > > > > On Sat, May 8, 2021 at 2:10 PM Drew Fustini <drew@beagleboard.org> wrote: > > > > > > > > On Sat, May 8, 2021 at 9:02 AM Khem Raj <raj.khem@gmail.com> wrote: > > > > > > > > > > On Sat, May 8, 2021 at 12:48 AM Drew Fustini <drew@beagleboard.org> wrote: > > > > > > > > > > > > On Sat, May 8, 2021 at 12:37 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > > > > > > > > > > > > > Drew, All, > > > > > > > > > > > > > > On 2021-05-07 16:30 -0700, Drew Fustini spake thusly: > > > > > > > > On Fri, May 7, 2021, 15:04 Yann E. MORIN < [1]yann.morin.1998@free.fr> wrote: > > > > > > > > On 2021-05-04 22:51 +0200, Thomas Petazzoni spake thusly: > > > > > > > > > This commit adds a package for the DDR initialization code used on the > > > > > > > > > BeagleV platform. > > > > > > > > > > > > > > > > The upstream package name is beaglev-ddrlnit, yes, with an 'l' instead > > > > > > > > of an 'i'. I've renamed the package to match upstream name, so that > > > > > > > > users that look for it can actually find it. > > > > > > > > Would it be helpful if I get StarFive to fix the typo and rename it to ddrinit? > > > > > > > > I am thinking that would probably be good to have happen before other projects > > > > > > > > start pointing to it. Thomas was so fast with the buildroot patches I think it > > > > > > > > is the first to notice this. > > > > > > > > > > > > > > It is not so important that the upstream name gets fixed; in fact quite > > > > > > > the opposite: we are now already referencing it. Granted, it's brand > > > > > > > new, and we can fix it quick before the release. But note that our > > > > > > > 2021.05-rc1 is due this WE, for example; we can still fix this kind of > > > > > > > thing post rc1, of course, but we can't fix a release... > > > > > > > > > > > > > > But as you mention, once other projects start referencing it, it will be > > > > > > > too late. For example, Khem Raj already has started such support: > > > > > > > > > > > > > > https://github.com/riscv/meta-riscv/blob/master/beaglev.yml > > > > > > > https://github.com/YoeDistro/yoe-distro/blob/master/beaglev-starlight-jh7100-envsetup.sh > > > > > > > > > > > > > > So even if it is still very early, I think it is already too late to > > > > > > > rename the repository... > > > > > > > > > > Is there general consensus on what it should be called ? > > > > > I am happy to remove references to SOC name, if we have clear naming > > > > > convention and strategy to also name future iterations of beagleV based on RISCV > > > > > > > > The board that Thomas and you received is the beta prototype version > > > > of BeagleV Starlight board with the StarFive JH7100 SoC, which is a > > > > low quantity test SoC. BeagleV is BeagleBoard.org Foundation's name > > > > for RISC-V boards. BeagleV Starlight is a BeagleBoard.org board with > > > > a StarFive RISC-V SoC. > > > > > > > > The production BeagleV Starlight will have the StarFive JH7110, the > > > > mass production SoC. Due to the different SoC models, BeagleV > > > > Starlight JH7100 would refer to the beta prototype, and BeagleV > > > > Starlight JH7110 would be the product that will be launched later this > > > > year. > > > > > > > > That README is the best public URL to reference in documentation and > > > > patches and it includes guidance on naming conventions: > > > > https://github.com/beagleboard/beaglev-starlight#guidance-on-naming-conventions > > > > > > So perhaps we could call this machine as beaglev-beta ? and the final > > > one beaglev in Yocto machine names ? > > > I am not sure adding SOC info adds some meaningful information, unless > > > you plan to have other SOCs also in > > > beagleV boards variants > > > > BeagleV is a name that will exist for long into the future for any > > BeagleBoard.org board with a RISC-V processor. Therefore I think > > beaglev-starlight-beta would be a good machine name which would > > represent the beta version of BeagleV Starlight with StarFive JH7100 > > SoC. Machine beagle-starlight could then represent the production > > BeagleV Starlight with StarFive JH7110 SoC. > > OK, but I was also thinking that tomorrow there might be a different > starlight soc > in beagleV next version in future so perhal > beaglev-<SOC-Vendor>-<SOC-name> might be future proof yes, this is a good idea. thus we would have: beaglev-starfive-jh7100: beta BeagleV Starlight board with StarFive JH7100 SoC beaglev-starfive-jh7110: production BeagleV Starlight board with StarFive JH7110 SoC I do like using the SoC model instead of words like beta and production. The name 'Starlight' in the context of the BeagleV Starlight board is the result of StarFive believing it would have a positive meaning in Chinese. Starlight does not really mean anything in a technical sense so I think that "starfive" is more useful to have in the machine name such as 'beaglev-starfive-jh7100'. thanks, drew
On Sun, May 9, 2021 at 1:29 PM Drew Fustini <drew@beagleboard.org> wrote: > > On Sun, May 9, 2021 at 4:04 AM Arnout Vandecappelle <arnout@mind.be> wrote: > > > > > > > > On 09/05/2021 13:03, Arnout Vandecappelle wrote: > > > > > > > > > On 08/05/2021 00:04, Yann E. MORIN wrote: > > >> On 2021-05-04 22:51 +0200, Thomas Petazzoni spake thusly: > > >>> This commit adds a package for the DDR initialization code used on the > > >>> BeagleV platform. > > >> > > >> The upstream package name is beaglev-ddrlnit, yes, with an 'l' instead > > >> of an 'i'. I've renamed the package to match upstream name, so that > > >> users that look for it can actually find it. > > > > > > What's done is done of course, but in this case, I think we should have stuck > > > to ddrinit with an eye. That name makes much more sense, and in fact when people > > > search for it (with / in menuconfig) they're IMHO much more likely to search for > > > it with an eye than with an el. The el you'd probably only use when you copy and > > > paste the name from github, but who does that? > > > > > > > > > @Drew/Bing, on github, when you rename a repository, the old name will still > > > redirect to the new one (at least until you create a new repo with that name). > > > So I'd go ahead and to the rename to ddrinit, it should break anything. > > > > I forgot the reference: > > > > https://docs.github.com/en/github/administering-a-repository/renaming-a-repository > > Thank you. I knew that the redirect worked on the website, but this > clarifies that it also works for git clone as well. Therefore, it > seems like I should ask starfive to fix the typo as the old repo url > with the typo will still work. The typo has now been fixed by Michael Zhu at StarFive: https://github.com/starfive-tech/beagle_ddrinit/issues/6 The typo name (with "l") does still work: https://github.com/starfive-tech/beagle_ddrlnit but it will redirect to the correct name (with "i"): https://github.com/starfive-tech/beagle_ddrinit thank you, drew
>>>>> "Drew" == Drew Fustini <drew@beagleboard.org> writes: Hi, > The typo has now been fixed by Michael Zhu at StarFive: > https://github.com/starfive-tech/beagle_ddrinit/issues/6 > The typo name (with "l") does still work: > https://github.com/starfive-tech/beagle_ddrlnit > but it will redirect to the correct name (with "i"): > https://github.com/starfive-tech/beagle_ddrinit Great, thanks. I've sent a patch to rename the corresponding package: https://patchwork.ozlabs.org/project/buildroot/patch/20210510090658.24276-1-peter@korsgaard.com/
diff --git a/DEVELOPERS b/DEVELOPERS index 7ce78742fc..39bc71ea34 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -2604,6 +2604,7 @@ N: Thomas Petazzoni <thomas.petazzoni@bootlin.com> F: arch/Config.in.arm F: board/beaglev/ F: board/stmicroelectronics/stm32mp157c-dk2/ +F: boot/beaglev-ddrinit/ F: boot/boot-wrapper-aarch64/ F: boot/grub2/ F: boot/gummiboot/ diff --git a/boot/Config.in b/boot/Config.in index b3adbfc8bc..f581205c6c 100644 --- a/boot/Config.in +++ b/boot/Config.in @@ -6,6 +6,7 @@ source "boot/at91bootstrap3/Config.in" source "boot/at91dataflashboot/Config.in" source "boot/arm-trusted-firmware/Config.in" source "boot/barebox/Config.in" +source "boot/beaglev-ddrinit/Config.in" source "boot/binaries-marvell/Config.in" source "boot/boot-wrapper-aarch64/Config.in" source "boot/grub2/Config.in" diff --git a/boot/beaglev-ddrinit/Config.in b/boot/beaglev-ddrinit/Config.in new file mode 100644 index 0000000000..5392f49088 --- /dev/null +++ b/boot/beaglev-ddrinit/Config.in @@ -0,0 +1,9 @@ +config BR2_TARGET_BEAGLEV_DDRINIT + bool "beaglev-ddrinit" + depends on BR2_riscv + depends on BR2_HOSTARCH = "x86_64" # host-riscv64-elf-toolchain + help + This package builds the DDRinit firmware used on the BeagleV + platform. + + https://github.com/starfive-tech/beagle_ddrlnit diff --git a/boot/beaglev-ddrinit/beaglev-ddrinit.mk b/boot/beaglev-ddrinit/beaglev-ddrinit.mk new file mode 100644 index 0000000000..72e6aea965 --- /dev/null +++ b/boot/beaglev-ddrinit/beaglev-ddrinit.mk @@ -0,0 +1,29 @@ +################################################################################ +# +# beaglev-ddrinit +# +################################################################################ + +# HEAD of the starfive branch +BEAGLEV_DDRINIT_VERSION = 15b80de81263996affb2a29332aa681925709983 +BEAGLEV_DDRINIT_SITE = $(call github,starfive-tech,beagle_ddrlnit,$(BEAGLEV_DDRINIT_VERSION)) +BEAGLEV_DDRINIT_INSTALL_TARGET = NO +BEAGLEV_DDRINIT_INSTALL_IMAGES = YES +BEAGLEV_DDRINIT_DEPENDENCIES = host-riscv64-elf-toolchain +# unfortunately, no real license file, but several sources files are +# under GPL-2.0+, making the whole work GPL-2.0+ +BEAGLEV_DDRINIT_LICENSE = GPL-2.0+ + +define BEAGLEV_DDRINIT_BUILD_CMDS + $(MAKE) -C $(@D)/build \ + CROSSCOMPILE=$(HOST_DIR)/bin/riscv64-unknown-elf- \ + SUFFIX=buildroot \ + GIT_VERSION=$(BEAGLEV_DDRINIT_VERSION) +endef + +define BEAGLEV_DDRINIT_INSTALL_IMAGES_CMDS + $(INSTALL) -D -m 0644 $(@D)/build/ddrinit-2133-buildroot.bin.out \ + $(BINARIES_DIR)/ddrinit-2133-buildroot.bin.out +endef + +$(eval $(generic-package))