From patchwork Sun May 2 21:49:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Romain Naour X-Patchwork-Id: 1472921 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=ZyDa7/Do; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FYKXM0yZvz9s1l for ; Mon, 3 May 2021 07:50:11 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 1BB1B60876; Sun, 2 May 2021 21:50:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id udMsb72b5w6e; Sun, 2 May 2021 21:50:08 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 7865260861; Sun, 2 May 2021 21:50:07 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id DF7CC1BF5AE for ; Sun, 2 May 2021 21:49:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id CEB5C4033F for ; Sun, 2 May 2021 21:49:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hpNIj73H4uZK for ; Sun, 2 May 2021 21:49:29 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by smtp2.osuosl.org (Postfix) with ESMTPS id 8A9F1400CB for ; Sun, 2 May 2021 21:49:29 +0000 (UTC) Received: by mail-wr1-x433.google.com with SMTP id t18so3596851wry.1 for ; Sun, 02 May 2021 14:49:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PGzj3BGruiGrwsSSVS7fnesrZo8Ki7lyOSzBG0aN+NM=; b=ZyDa7/Doad1L+kg6pilwpI8c9Wqfi3nQlv4YQ4u5i6qC7X5cS1slilqQqzArUfmvb3 i2NnvKgr4PlngUWo3EjqV5ItOtxS5zKw+/HoxUggAiMsV/w4yVvrMo3ja1TU+EgkCge6 KFvUz+ngll24Bh4SUYFNLnIuHmx0patgldNECbbxGJqQxkkobUwQ0O9cNa3s+hJO3V8P 1qApX6IDfOFqjsEJvRScplTXSi1zdRCGmLIMnNgYF19+6QF8wtoimyvGZJLJCLeP+2/Q aT+cpMq6MW/sHKRBviiUPGo8qW7Uh1M4+lxj3f/14h+uprtYrR6MFkrGiX95VBDIVwOe F8uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PGzj3BGruiGrwsSSVS7fnesrZo8Ki7lyOSzBG0aN+NM=; b=DbezPz8Qjr2gIRiqj81MIrWdtoTK+S239tD9NpIHtj5UbBFXJKqhicBUUFRgfc5evN dtrcg+iwg+np11ZSzaD4vGc+3RAw32h5OFj9/ymNlQyh4qrbuyOLQE3f352AGrGY3oC6 V5BDAhu8UgRw2S5eoR0IbW7eIAPZwrUe78bh2jjx+HKGmdPA/vsqb8U/n/Ya0kd47dvn g/lJV0oaeOhas2HwGeFM4l7yhVTpftWZRdGTFPPx0Z3iL3YgvMRs/gaDmnKnV9uAvkep +LJzfB6fSKGNdyw1La7m+/mkdSg3WZo/kdgS+6MI3ZOnQIu8FbzhgIBNMOmVGSLSaO/W Y/bA== X-Gm-Message-State: AOAM530j4mXk91f+cRJxdULpQG+VyierdiTXYBsMmL/HE0G6K3MXrAEg tVqXuVGusoiCtsVyZEAij3HMLoC6S7c= X-Google-Smtp-Source: ABdhPJwHOOWIMmR9oNjJeW8cY7XQhSjiVrTvYaNATRoBUFTqFUbd5gCfr1vom/kg/6OgwUTgaLyU5g== X-Received: by 2002:adf:ff81:: with SMTP id j1mr4569034wrr.336.1619992167851; Sun, 02 May 2021 14:49:27 -0700 (PDT) Received: from localhost.localdomain (2a01cb058f8a180002e04cfffe680084.ipv6.abo.wanadoo.fr. [2a01:cb05:8f8a:1800:2e0:4cff:fe68:84]) by smtp.gmail.com with ESMTPSA id o17sm8679439wmq.47.2021.05.02.14.49.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 May 2021 14:49:27 -0700 (PDT) From: Romain Naour To: buildroot@buildroot.org Date: Sun, 2 May 2021 23:49:19 +0200 Message-Id: <20210502214919.1826571-6-romain.naour@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210502214919.1826571-1-romain.naour@gmail.com> References: <20210502214919.1826571-1-romain.naour@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCH 5/5] package/poke: enable uClibc-ng support X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Romain Naour Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" poke bundle gnulib that doesn't support the case where host_os='linux-uclibc'. When cross-compiling, the guessed answers are mostly wrong and gnulib will try to replace snprintf with rpl_snprintf. This lead to "undefined reference to `rpl_snprintf'" errors. Signed-off-by: Romain Naour --- package/poke/Config.in | 4 ---- package/poke/poke.mk | 25 +++++++++++++++++++++++++ 2 files changed, 25 insertions(+), 4 deletions(-) diff --git a/package/poke/Config.in b/package/poke/Config.in index 5d391bfb43..762ed0221d 100644 --- a/package/poke/Config.in +++ b/package/poke/Config.in @@ -4,7 +4,6 @@ config BR2_PACKAGE_POKE depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # less depends on BR2_USE_WCHAR # needs wctomb depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL - depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL # gnulib select BR2_PACKAGE_BDWGC select BR2_PACKAGE_LESS # runtime select BR2_PACKAGE_READLINE @@ -26,6 +25,3 @@ config BR2_PACKAGE_POKE comment "poke needs a toolchain w/ NPTL, wchar" depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_USE_WCHAR - -comment "poke needs glibc or musl" - depends on !(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL) diff --git a/package/poke/poke.mk b/package/poke/poke.mk index 268b9598d7..cff52d37bf 100644 --- a/package/poke/poke.mk +++ b/package/poke/poke.mk @@ -15,6 +15,31 @@ POKE_AUTORECONF = YES POKE_DEPENDENCIES = host-flex host-bison host-pkgconf bdwgc readline +# poke bundle gnulib that doesn't support the case where +# host_os='linux-uclibc'. When cross-compiling, the guessed +# answers are mostly wrong and gnulib will try to replace +# snprintf with rpl_snprintf. This lead to "undefined reference +# to `rpl_snprintf'" errors. +ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y) +POKE_CONF_ENV = gl_cv_func_printf_positions=yes \ + gl_cv_func_snprintf_retval_c99=yes \ + gl_cv_func_printf_sizes_c99=yes \ + gl_cv_func_printf_infinite_long_double=yes \ + gl_cv_func_snprintf_retval_c99=yes \ + gl_cv_func_snprintf_truncation_c99=yes \ + gl_cv_func_snprintf_usable=yes \ + gl_cv_func_strerror_0_works=yes \ + gl_cv_header_working_stdint_h=yes \ + gl_cv_func_printf_infinite=yes \ + gl_cv_func_printf_flag_zero=yes \ + gl_cv_func_printf_enomem=yes \ + gl_cv_func_printf_directive_f=yes \ + gl_cv_func_printf_directive_a=yes \ + gl_cv_func_snprintf_directive_n=yes \ + gl_cv_func_vsnprintf_posix=yes \ + gl_cv_func_vsnprintf_zerosize_c99=yes +endif + POKE_CONF_OPTS = --disable-gui \ --disable-libnbd \ --with-libreadline-prefix=$(STAGING_DIR)