| Message ID | 20210314223207.13460-2-ps.report@gmx.net |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v1,1/2] package/batman-adv: fix compile with BR2_PACKAGE_BATMAN_ADV_BATMAN_V disabled | expand |
Peter, All, On 2021-03-14 23:32 +0100, Peter Seiderer spake thusly: > As upstream enables CONFIG_BATMAN_ADV_BATMAN_V option since > 2018.2 by defaullt ([1]) honor this in buildroot and do > the same (and remove the leagcy experimental comment accordingly). > > [1] https://git.open-mesh.org/batman-adv.git/blob/HEAD:/CHANGELOG.rst#l174 > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> > --- > package/batman-adv/Config.in | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/package/batman-adv/Config.in b/package/batman-adv/Config.in > index 9d3d7967b9..f3ac974296 100644 > --- a/package/batman-adv/Config.in > +++ b/package/batman-adv/Config.in > @@ -25,11 +25,10 @@ config BR2_PACKAGE_BATMAN_ADV_NC > https://www.open-mesh.org/projects/batman-adv/wiki/NetworkCoding > > config BR2_PACKAGE_BATMAN_ADV_BATMAN_V > - bool "enable B.A.T.M.A.N. V protocol (experimental)" > + bool "enable B.A.T.M.A.N. V protocol" Upstream seems to still consider this to be experimental [0]. > + default y What we talked about earlier [1], was to always enable it, not to change the default. Now, people that have a defconfig file with BATMAN-V disabled (i.e. there would be nothing in the defconfig as 'is not set' is the default), will have it enabled now. So, if upstream recommends to not disable it (do you have a ref?), then we should just drop our option, and to always enable it. Thoughts? [0] https://git.open-mesh.org/batman-adv.git/blob/HEAD:/Makefile#l7 [1] http://lists.busybox.net/pipermail/buildroot/2021-March/305811.html Regards, Yann E. MORIN. > help > Enables B.A.T.M.A.N. V network protocol. > - This is the next-gen protocol and is experimental at this > - time. > > https://www.open-mesh.org/projects/batman-adv/wiki/BATMAN_V > > -- > 2.30.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Yann, On Mon, Mar 15, 2021 at 12:59 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > config BR2_PACKAGE_BATMAN_ADV_BATMAN_V > > - bool "enable B.A.T.M.A.N. V protocol (experimental)" > > + bool "enable B.A.T.M.A.N. V protocol" > > Upstream seems to still consider this to be experimental [0]. > > > + default y > > What we talked about earlier [1], was to always enable it, not to change > the default. > > Now, people that have a defconfig file with BATMAN-V disabled (i.e. > there would be nothing in the defconfig as 'is not set' is the default), > will have it enabled now. > > So, if upstream recommends to not disable it (do you have a ref?), then > we should just drop our option, and to always enable it. > > Thoughts? > > [0] https://git.open-mesh.org/batman-adv.git/blob/HEAD:/Makefile#l7 > [1] http://lists.busybox.net/pipermail/buildroot/2021-March/305811.html What would the advantage be for removing the ability to disable the CONFIG_BATMAN_ADV_BATMAN_V option from the Buildroot config? I guess if someone doesn't need it it could still be good to remove to simplify things. Best, Christian
Hello Yann, On Mon, 15 Mar 2021 20:59:00 +0100, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote: > Peter, All, > > On 2021-03-14 23:32 +0100, Peter Seiderer spake thusly: > > As upstream enables CONFIG_BATMAN_ADV_BATMAN_V option since > > 2018.2 by defaullt ([1]) honor this in buildroot and do > > the same (and remove the leagcy experimental comment accordingly). > > > > [1] https://git.open-mesh.org/batman-adv.git/blob/HEAD:/CHANGELOG.rst#l174 > > > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> > > --- > > package/batman-adv/Config.in | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/package/batman-adv/Config.in b/package/batman-adv/Config.in > > index 9d3d7967b9..f3ac974296 100644 > > --- a/package/batman-adv/Config.in > > +++ b/package/batman-adv/Config.in > > @@ -25,11 +25,10 @@ config BR2_PACKAGE_BATMAN_ADV_NC > > https://www.open-mesh.org/projects/batman-adv/wiki/NetworkCoding > > > > config BR2_PACKAGE_BATMAN_ADV_BATMAN_V > > - bool "enable B.A.T.M.A.N. V protocol (experimental)" > > + bool "enable B.A.T.M.A.N. V protocol" > > Upstream seems to still consider this to be experimental [0]. Would count this as a oversight/leftover...and after 3 years of default to enabled would not count it as experimental... > > > + default y > > What we talked about earlier [1], was to always enable it, not to change > the default. > > Now, people that have a defconfig file with BATMAN-V disabled (i.e. > there would be nothing in the defconfig as 'is not set' is the default), > will have it enabled now. I believe the count of people who have BATMAN-V disabled is zero (or they are to shy to report the compile failure which should occur since the introduction of BATMAN-V as the ifdef pattern did not change since 2016, see [2])... > > So, if upstream recommends to not disable it (do you have a ref?), then > we should just drop our option, and to always enable it. > Same rationale as Christian in the follow-up mail... Regards, Peter [2] https://git.open-mesh.org/batman-adv.git/blobdiff/ec46535b827539e29628881fa46e5644ec84eba7..a4b88af77e28f90e650c779f673a84d5b8cb5985:/net/batman-adv/bat_algo.h > Thoughts? > > [0] https://git.open-mesh.org/batman-adv.git/blob/HEAD:/Makefile#l7 > [1] http://lists.busybox.net/pipermail/buildroot/2021-March/305811.html > > Regards, > Yann E. MORIN. > > > help > > Enables B.A.T.M.A.N. V network protocol. > > - This is the next-gen protocol and is experimental at this > > - time. > > > > https://www.open-mesh.org/projects/batman-adv/wiki/BATMAN_V > > > > -- > > 2.30.1 > > > > _______________________________________________ > > buildroot mailing list > > buildroot@busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot >
On 14/03/2021 23:32, Peter Seiderer wrote: > As upstream enables CONFIG_BATMAN_ADV_BATMAN_V option since > 2018.2 by defaullt ([1]) honor this in buildroot and do > the same (and remove the leagcy experimental comment accordingly). > > [1] https://git.open-mesh.org/batman-adv.git/blob/HEAD:/CHANGELOG.rst#l174 > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> I finally applied to master with just a bit extension of the commit message to indicate that upstream's label of it being experimental is no longer really true. Regards, Arnout > --- > package/batman-adv/Config.in | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/package/batman-adv/Config.in b/package/batman-adv/Config.in > index 9d3d7967b9..f3ac974296 100644 > --- a/package/batman-adv/Config.in > +++ b/package/batman-adv/Config.in > @@ -25,11 +25,10 @@ config BR2_PACKAGE_BATMAN_ADV_NC > https://www.open-mesh.org/projects/batman-adv/wiki/NetworkCoding > > config BR2_PACKAGE_BATMAN_ADV_BATMAN_V > - bool "enable B.A.T.M.A.N. V protocol (experimental)" > + bool "enable B.A.T.M.A.N. V protocol" > + default y > help > Enables B.A.T.M.A.N. V network protocol. > - This is the next-gen protocol and is experimental at this > - time. > > https://www.open-mesh.org/projects/batman-adv/wiki/BATMAN_V >
diff --git a/package/batman-adv/Config.in b/package/batman-adv/Config.in index 9d3d7967b9..f3ac974296 100644 --- a/package/batman-adv/Config.in +++ b/package/batman-adv/Config.in @@ -25,11 +25,10 @@ config BR2_PACKAGE_BATMAN_ADV_NC https://www.open-mesh.org/projects/batman-adv/wiki/NetworkCoding config BR2_PACKAGE_BATMAN_ADV_BATMAN_V - bool "enable B.A.T.M.A.N. V protocol (experimental)" + bool "enable B.A.T.M.A.N. V protocol" + default y help Enables B.A.T.M.A.N. V network protocol. - This is the next-gen protocol and is experimental at this - time. https://www.open-mesh.org/projects/batman-adv/wiki/BATMAN_V
As upstream enables CONFIG_BATMAN_ADV_BATMAN_V option since 2018.2 by defaullt ([1]) honor this in buildroot and do the same (and remove the leagcy experimental comment accordingly). [1] https://git.open-mesh.org/batman-adv.git/blob/HEAD:/CHANGELOG.rst#l174 Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- package/batman-adv/Config.in | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)