diff mbox series

[PATCH/next,v1] package/ifupdown-scripts: send udhcpc to background in case lease is not obtained

Message ID 20210216202022.27264-1-ps.report@gmx.net
State New
Headers show
Series [PATCH/next,v1] package/ifupdown-scripts: send udhcpc to background in case lease is not obtained | expand

Commit Message

Peter Seiderer Feb. 16, 2021, 8:20 p.m. UTC
- Add the 'udhcpc_opts -b' option to /etc/network/interfaces for the
  system dhcp configured interface. With this option ('-b: background if
  lease is not obtained') the udhcpc keeps running in case the initial
  dhcp requests are not answered immediately.

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/ifupdown-scripts/ifupdown-scripts.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Peter Korsgaard Feb. 17, 2021, 4:33 p.m. UTC | #1
>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:

 > - Add the 'udhcpc_opts -b' option to /etc/network/interfaces for the
 >   system dhcp configured interface. With this option ('-b: background if
 >   lease is not obtained') the udhcpc keeps running in case the initial
 >   dhcp requests are not answered immediately.

 > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
 > ---
 >  package/ifupdown-scripts/ifupdown-scripts.mk | 1 +
 >  1 file changed, 1 insertion(+)

 > diff --git a/package/ifupdown-scripts/ifupdown-scripts.mk b/package/ifupdown-scripts/ifupdown-scripts.mk
 > index 5ef032142c..d3135b18b6 100644
 > --- a/package/ifupdown-scripts/ifupdown-scripts.mk
 > +++ b/package/ifupdown-scripts/ifupdown-scripts.mk
 > @@ -28,6 +28,7 @@ define IFUPDOWN_SCRIPTS_DHCP
 >  		echo "  pre-up /etc/network/nfs_check"; \
 >  		echo "  wait-delay 15"; \
 >  		echo "  hostname \$$(hostname)"; \
 > +		echo "  udhcpc_opts -b"; \

Wouldn't it make more sense to change the value of
CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS in our default busybox.config instead
of hardcoding it here?

Does this still do the right thing for the fallback to IPv4LL addressing
if avahi-autoipd is enabled?
Thomas Petazzoni Aug. 1, 2021, 10:07 a.m. UTC | #2
Hello Peter,

On Tue, 16 Feb 2021 21:20:22 +0100
Peter Seiderer <ps.report@gmx.net> wrote:

> - Add the 'udhcpc_opts -b' option to /etc/network/interfaces for the
>   system dhcp configured interface. With this option ('-b: background if
>   lease is not obtained') the udhcpc keeps running in case the initial
>   dhcp requests are not answered immediately.
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  package/ifupdown-scripts/ifupdown-scripts.mk | 1 +
>  1 file changed, 1 insertion(+)

There has been some feedback from Peter Korsgaard on your patch, but
you didn't reply to it. Could you follow-up so that we can move forward?

Thanks a lot!

Thomas
diff mbox series

Patch

diff --git a/package/ifupdown-scripts/ifupdown-scripts.mk b/package/ifupdown-scripts/ifupdown-scripts.mk
index 5ef032142c..d3135b18b6 100644
--- a/package/ifupdown-scripts/ifupdown-scripts.mk
+++ b/package/ifupdown-scripts/ifupdown-scripts.mk
@@ -28,6 +28,7 @@  define IFUPDOWN_SCRIPTS_DHCP
 		echo "  pre-up /etc/network/nfs_check"; \
 		echo "  wait-delay 15"; \
 		echo "  hostname \$$(hostname)"; \
+		echo "  udhcpc_opts -b"; \
 	) >> $(TARGET_DIR)/etc/network/interfaces
 endef
 define IFUPDOWN_SCRIPTS_DHCP_OPENRC