diff mbox series

[1/2] package/chartjs: move 'v' version prefix out of CHARTJS_VERSION

Message ID 20210119154607.11101-1-patrickdepinguin@gmail.com
State Accepted
Headers show
Series [1/2] package/chartjs: move 'v' version prefix out of CHARTJS_VERSION | expand

Commit Message

Thomas De Schampheleire Jan. 19, 2021, 3:46 p.m. UTC 
From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>

chartjs 2.9.3 has a security vulnerability (CVE-2020-7746) which is not
detected by the CVE scripts, presumably because our version variable starts
with a 'v'.

Move that 'v' prefix out of the version variable to fix that.

Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
---
 package/chartjs/chartjs.hash | 2 +-
 package/chartjs/chartjs.mk   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Peter Korsgaard Jan. 19, 2021, 5:57 p.m. UTC | #1 
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:

 > From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
 > chartjs 2.9.3 has a security vulnerability (CVE-2020-7746) which is not
 > detected by the CVE scripts, presumably because our version variable starts
 > with a 'v'.

 > Move that 'v' prefix out of the version variable to fix that.

 > Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>

Committed, thanks.
Peter Korsgaard Feb. 4, 2021, 3:34 p.m. UTC | #2 
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:

 > From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
 > chartjs 2.9.3 has a security vulnerability (CVE-2020-7746) which is not
 > detected by the CVE scripts, presumably because our version variable starts
 > with a 'v'.

 > Move that 'v' prefix out of the version variable to fix that.

 > Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>

Committed to 2020.11.x, thanks.
diff mbox series

Patch

diff --git a/package/chartjs/chartjs.hash b/package/chartjs/chartjs.hash
index d2426ea614..a029d16ab1 100644
--- a/package/chartjs/chartjs.hash
+++ b/package/chartjs/chartjs.hash
@@ -1,3 +1,3 @@ 
 # Locally computed:
-sha256	8079d8fd39131fcfaec33f1c7799412bcf8e051e25b10bd6e37fc16159417aa1  chartjs-v2.9.3.tar.gz
+sha256	8079d8fd39131fcfaec33f1c7799412bcf8e051e25b10bd6e37fc16159417aa1  chartjs-2.9.3.tar.gz
 sha256	7b43caae91f31b18dc81fae6e0f7aa1acbecaa6d84e3249905cbe15308307d67  LICENSE.md
diff --git a/package/chartjs/chartjs.mk b/package/chartjs/chartjs.mk
index 171e0a4a7c..960b3e24af 100644
--- a/package/chartjs/chartjs.mk
+++ b/package/chartjs/chartjs.mk
@@ -4,8 +4,8 @@ 
 #
 ################################################################################
 
-CHARTJS_VERSION = v2.9.3
-CHARTJS_SITE = $(call github,chartjs,Chart.js,$(CHARTJS_VERSION))
+CHARTJS_VERSION = 2.9.3
+CHARTJS_SITE = $(call github,chartjs,Chart.js,v$(CHARTJS_VERSION))
 CHARTJS_LICENSE = MIT
 CHARTJS_LICENSE_FILES = LICENSE.md