diff mbox series

[RFC,v1,1/6] package/vulkan-headers: new package

Message ID 20201223224553.8570-2-ps.report@gmx.net
State Changes Requested
Headers show
Series Vulkan support | expand

Commit Message

Peter Seiderer Dec. 23, 2020, 10:45 p.m. UTC 
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/Config.in                          |  1 +
 package/vulkan-headers/Config.in           |  7 +++++++
 package/vulkan-headers/vulkan-headers.hash |  3 +++
 package/vulkan-headers/vulkan-headers.mk   | 13 +++++++++++++
 4 files changed, 24 insertions(+)
 create mode 100644 package/vulkan-headers/Config.in
 create mode 100644 package/vulkan-headers/vulkan-headers.hash
 create mode 100644 package/vulkan-headers/vulkan-headers.mk

Comments

Yann E. MORIN Dec. 30, 2020, 8:42 a.m. UTC | #1 
Peter, All,

On 2020-12-23 23:45 +0100, Peter Seiderer spake thusly:
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
[--SNIP--]
> diff --git a/package/vulkan-headers/vulkan-headers.mk b/package/vulkan-headers/vulkan-headers.mk
> new file mode 100644
> index 0000000000..a20f4d789c
> --- /dev/null
> +++ b/package/vulkan-headers/vulkan-headers.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# vulkan-headers
> +#
> +################################################################################
> +
> +VULKAN_HEADERS_VERSION = 1.2.165

As stated in there READ:E:

    Marked version releases have undergone thorough testing but do not
    imply the same quality level as SDK tags. SDK tags follow the
    sdk-<version>.<patch> format (e.g., sdk-1.1.92.0).

Shouldn't we use SDK tags, rather than mere versions?

(Comment valid for the three Vulkan-related packages in your series).

Regards,
Yann E. MORIN.

> +VULKAN_HEADERS_SITE = $(call github,KhronosGroup,Vulkan-Headers,v$(VULKAN_HEADERS_VERSION))
> +VULKAN_HEADERS_LICENSE = Apache-2.0 License
> +VULKAN_HEADERS_LICENSE_FILES = LICENSE.txt
> +VULKAN_HEADERS_INSTALL_STAGING = YES
> +
> +$(eval $(cmake-package))
> -- 
> 2.29.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Seiderer Dec. 30, 2020, 2:23 p.m. UTC | #2 
Hello Yann,

On Wed, 30 Dec 2020 09:42:49 +0100, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Peter, All,
>
> On 2020-12-23 23:45 +0100, Peter Seiderer spake thusly:
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> [--SNIP--]
> > diff --git a/package/vulkan-headers/vulkan-headers.mk b/package/vulkan-headers/vulkan-headers.mk
> > new file mode 100644
> > index 0000000000..a20f4d789c
> > --- /dev/null
> > +++ b/package/vulkan-headers/vulkan-headers.mk
> > @@ -0,0 +1,13 @@
> > +################################################################################
> > +#
> > +# vulkan-headers
> > +#
> > +################################################################################
> > +
> > +VULKAN_HEADERS_VERSION = 1.2.165
>
> As stated in there READ:E:
>
>     Marked version releases have undergone thorough testing but do not
>     imply the same quality level as SDK tags. SDK tags follow the
>     sdk-<version>.<patch> format (e.g., sdk-1.1.92.0).
>
> Shouldn't we use SDK tags, rather than mere versions?

One reason why this patch series is sent as RFC ;-), but will update/or
downgrade to an SDK tag (if it works) on next patch series iteration...

Regards,
Peter

>
> (Comment valid for the three Vulkan-related packages in your series).
>
> Regards,
> Yann E. MORIN.
>
> > +VULKAN_HEADERS_SITE = $(call github,KhronosGroup,Vulkan-Headers,v$(VULKAN_HEADERS_VERSION))
> > +VULKAN_HEADERS_LICENSE = Apache-2.0 License
> > +VULKAN_HEADERS_LICENSE_FILES = LICENSE.txt
> > +VULKAN_HEADERS_INSTALL_STAGING = YES
> > +
> > +$(eval $(cmake-package))
> > --
> > 2.29.2
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
diff mbox series

Patch

diff --git a/package/Config.in b/package/Config.in
index c3677dd15e..9ede3b770f 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -334,6 +334,7 @@  comment "Graphic libraries"
 	source "package/sdl2_net/Config.in"
 	source "package/sdl2_ttf/Config.in"
 	source "package/tk/Config.in"
+	source "package/vulkan-headers/Config.in"
 
 comment "Other GUIs"
 	source "package/qt5/Config.in"
diff --git a/package/vulkan-headers/Config.in b/package/vulkan-headers/Config.in
new file mode 100644
index 0000000000..c0fc8f20b0
--- /dev/null
+++ b/package/vulkan-headers/Config.in
@@ -0,0 +1,7 @@ 
+config BR2_PACKAGE_VULKAN_HEADERS
+	bool "vulkan-headers"
+	help
+	  The Khronos official Vulkan header files and API
+	  registry.
+
+	  https://github.com/KhronosGroup/Vulkan-Headers
diff --git a/package/vulkan-headers/vulkan-headers.hash b/package/vulkan-headers/vulkan-headers.hash
new file mode 100644
index 0000000000..678a38e0d4
--- /dev/null
+++ b/package/vulkan-headers/vulkan-headers.hash
@@ -0,0 +1,3 @@ 
+# Locally calculated
+sha256  3f9435a93ba13d94d0c3265a47e0436579e46bb9ca085e9b16a753458e4d79d2  vulkan-headers-1.2.165.tar.gz
+sha256  cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30  LICENSE.txt
diff --git a/package/vulkan-headers/vulkan-headers.mk b/package/vulkan-headers/vulkan-headers.mk
new file mode 100644
index 0000000000..a20f4d789c
--- /dev/null
+++ b/package/vulkan-headers/vulkan-headers.mk
@@ -0,0 +1,13 @@ 
+################################################################################
+#
+# vulkan-headers
+#
+################################################################################
+
+VULKAN_HEADERS_VERSION = 1.2.165
+VULKAN_HEADERS_SITE = $(call github,KhronosGroup,Vulkan-Headers,v$(VULKAN_HEADERS_VERSION))
+VULKAN_HEADERS_LICENSE = Apache-2.0 License
+VULKAN_HEADERS_LICENSE_FILES = LICENSE.txt
+VULKAN_HEADERS_INSTALL_STAGING = YES
+
+$(eval $(cmake-package))