| Message ID | 20201209145925.20850-1-patrickdepinguin@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/ncurses: don't attempt calling ldconfig in host-ncurses | expand |
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes: > From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> > The host-ncurses install step attempts to run ldconfig, causing a permission > failure: > cd /buildroot/output/host/lib && (ln -s -f libncurses.so.6.0 libncurses.so.6; ln -s -f libncurses.so.6 libncurses.so; ) > test -z "" && /sbin/ldconfig > /sbin/ldconfig: Can't create temporary cache file /etc/ld.so.cache~: Permission denied > make[3]: [/buildroot/output/host/lib/libncurses.so.6.0] Error 1 (ignored) > The error is non-fatal and ignored, but confusing. > The ncurses makefiles already avoid calling ldconfig when DESTDIR is set > (target case) but for host-ncurses DESTDIR is empty and the output/host path > is passed via --prefix. > Pass an empty ac_cv_path_LDCONFIG to the configure step, so than ldconfig is > not called. > Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> Committed, thanks.
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes: > From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> > The host-ncurses install step attempts to run ldconfig, causing a permission > failure: > cd /buildroot/output/host/lib && (ln -s -f libncurses.so.6.0 libncurses.so.6; ln -s -f libncurses.so.6 libncurses.so; ) > test -z "" && /sbin/ldconfig > /sbin/ldconfig: Can't create temporary cache file /etc/ld.so.cache~: Permission denied > make[3]: [/buildroot/output/host/lib/libncurses.so.6.0] Error 1 (ignored) > The error is non-fatal and ignored, but confusing. > The ncurses makefiles already avoid calling ldconfig when DESTDIR is set > (target case) but for host-ncurses DESTDIR is empty and the output/host path > is passed via --prefix. > Pass an empty ac_cv_path_LDCONFIG to the configure step, so than ldconfig is > not called. > Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> Committed to 2020.02.x, 2020.08.x and 2020.11.x, thanks.
diff --git a/package/ncurses/ncurses.mk b/package/ncurses/ncurses.mk index f4e4784a3c..4d8dcecc3a 100644 --- a/package/ncurses/ncurses.mk +++ b/package/ncurses/ncurses.mk @@ -187,6 +187,9 @@ define HOST_NCURSES_BUILD_CMDS $(HOST_MAKE_ENV) $(MAKE) -C $(@D)/progs tic endef +HOST_NCURSES_CONF_ENV = \ + ac_cv_path_LDCONFIG="" + HOST_NCURSES_CONF_OPTS = \ --with-shared \ --without-gpm \