| Message ID | 20201118131323.3166176-1-buildroot@heine.tech |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/gvfs: show warning when BR2_STATIC_LIBS=y | expand |
Hi, Le mer. 18 nov. 2020 à 14:13, Michael Nosthoff <buildroot@heine.tech> a écrit : > > Fixes: > > showing "gvfs needs a toolchain w/ wchar, threads, dynamic library" > while also showing "gvfs[ ]" > when !BR2_STATIC_LIBS Thanks for fixing this mistake. Reviewed-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > introduced by 4266c9f54f635e8a9d0a7fdedfb1c84c1de10785 > > Signed-off-by: Michael Nosthoff <buildroot@heine.tech> > --- > package/gvfs/Config.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/gvfs/Config.in b/package/gvfs/Config.in > index 5a6b3e73ec..68ad291436 100644 > --- a/package/gvfs/Config.in > +++ b/package/gvfs/Config.in > @@ -20,4 +20,4 @@ config BR2_PACKAGE_GVFS > comment "gvfs needs a toolchain w/ wchar, threads, dynamic library" > depends on BR2_USE_MMU > depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \ > - !BR2_STATIC_LIBS > + BR2_STATIC_LIBS > -- > 2.25.1 > Best Regards, Fabrice
>>>>> "Michael" == Michael Nosthoff via buildroot <buildroot@busybox.net> writes: > Fixes: > showing "gvfs needs a toolchain w/ wchar, threads, dynamic library" > while also showing "gvfs[ ]" > when !BR2_STATIC_LIBS > introduced by 4266c9f54f635e8a9d0a7fdedfb1c84c1de10785 > Signed-off-by: Michael Nosthoff <buildroot@heine.tech> Committed, thanks.
>>>>> "Michael" == Michael Nosthoff via buildroot <buildroot@busybox.net> writes: > Fixes: > showing "gvfs needs a toolchain w/ wchar, threads, dynamic library" > while also showing "gvfs[ ]" > when !BR2_STATIC_LIBS > introduced by 4266c9f54f635e8a9d0a7fdedfb1c84c1de10785 > Signed-off-by: Michael Nosthoff <buildroot@heine.tech> Committed to 2020.08.x, thanks.
diff --git a/package/gvfs/Config.in b/package/gvfs/Config.in index 5a6b3e73ec..68ad291436 100644 --- a/package/gvfs/Config.in +++ b/package/gvfs/Config.in @@ -20,4 +20,4 @@ config BR2_PACKAGE_GVFS comment "gvfs needs a toolchain w/ wchar, threads, dynamic library" depends on BR2_USE_MMU depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \ - !BR2_STATIC_LIBS + BR2_STATIC_LIBS
Fixes: showing "gvfs needs a toolchain w/ wchar, threads, dynamic library" while also showing "gvfs[ ]" when !BR2_STATIC_LIBS introduced by 4266c9f54f635e8a9d0a7fdedfb1c84c1de10785 Signed-off-by: Michael Nosthoff <buildroot@heine.tech> --- package/gvfs/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)