diff mbox series

[v2,1/1] package/qt5/qt5base: add -syslog option

Message ID 20201104181221.390041-1-jzignego@hedcontrols.com
State Accepted
Headers show
Series [v2,1/1] package/qt5/qt5base: add -syslog option | expand

Commit Message

Voss, Samuel M Collins via buildroot Nov. 4, 2020, 6:12 p.m. UTC
From: Jeff Zignego <jzignego@hedcontrols.com>

QT can default to outputting the logs to syslog instead of to the
console with this compile time switch. That behavior can still be
overridden by setting the environment variable QT_LOGGING_TO_CONSOLE to
1.

Signed-off-by: Jeff Zignego <jzignego@hedcontrols.com>

---
Changes v1 -> v2:
    - all v2 changes suggested by Peter Seiderer
    - create a BR2_PACKAGE_QT5BASE_SYSLOG config option
    - only control with config option and not previous method
---
 package/qt5/qt5base/Config.in  | 5 +++++
 package/qt5/qt5base/qt5base.mk | 6 ++++++
 2 files changed, 11 insertions(+)

Comments

Thomas Petazzoni Nov. 7, 2020, 1:46 p.m. UTC | #1
On Wed,  4 Nov 2020 12:12:21 -0600
jzignego--- via buildroot <buildroot@busybox.net> wrote:

> From: Jeff Zignego <jzignego@hedcontrols.com>
> 
> QT can default to outputting the logs to syslog instead of to the
> console with this compile time switch. That behavior can still be
> overridden by setting the environment variable QT_LOGGING_TO_CONSOLE to
> 1.
> 
> Signed-off-by: Jeff Zignego <jzignego@hedcontrols.com>
> 
> ---
> Changes v1 -> v2:
>     - all v2 changes suggested by Peter Seiderer
>     - create a BR2_PACKAGE_QT5BASE_SYSLOG config option
>     - only control with config option and not previous method
> ---
>  package/qt5/qt5base/Config.in  | 5 +++++
>  package/qt5/qt5base/qt5base.mk | 6 ++++++
>  2 files changed, 11 insertions(+)

Applied to next, thanks.

Thomas
diff mbox series

Patch

diff --git a/package/qt5/qt5base/Config.in b/package/qt5/qt5base/Config.in
index ce7230c728..ce7b5f0770 100644
--- a/package/qt5/qt5base/Config.in
+++ b/package/qt5/qt5base/Config.in
@@ -263,6 +263,11 @@  config BR2_PACKAGE_QT5BASE_PNG
 
 endif
 
+config BR2_PACKAGE_QT5BASE_SYSLOG
+	bool "syslog"
+	help
+	  Logs to the standard UNIX logging mechanism.
+
 config BR2_PACKAGE_QT5BASE_DBUS
 	bool "DBus module"
 	depends on BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
index ed308c1fa2..fa92625738 100644
--- a/package/qt5/qt5base/qt5base.mk
+++ b/package/qt5/qt5base/qt5base.mk
@@ -254,6 +254,12 @@  else
 QT5BASE_CONFIGURE_OPTS += -no-journald
 endif
 
+ifeq ($(BR2_PACKAGE_QT5BASE_SYSLOG),y)
+QT5BASE_CONIGURE_OPTS += -syslog
+else
+QT5BASE_CONFIGURE_OPTS += -no-syslog
+endif
+
 ifeq ($(BR2_PACKAGE_IMX_GPU_VIV),y)
 # use vivante backend
 QT5BASE_EGLFS_DEVICE = EGLFS_DEVICE_INTEGRATION = eglfs_viv