diff mbox series

package/python-remi: bump version to 2020.10.30

Message ID 20201102140000.1753870-1-gwenj@trabucayre.com
State Accepted
Headers show
Series package/python-remi: bump version to 2020.10.30 | expand

Commit Message

Gwenhael Goavec-Merou Nov. 2, 2020, 2 p.m. UTC
From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
---
 package/python-remi/python-remi.hash | 4 ++--
 package/python-remi/python-remi.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Peter Korsgaard Nov. 4, 2020, 8:04 a.m. UTC | #1
>>>>> "Gwenhael" == Gwenhael Goavec-Merou <gwenj@trabucayre.com> writes:

 > From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
 > Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>

This causes a number of build errors:

LookupError: setuptools-scm was unable to detect version for u'/tmp/instance-0/output-1/build/python-remi-2020.10.30'.

Make sure you're either building from a fully intact git repository or PyPI tarballs. Most other sources (such as GitHub's tarballs, a git checkout without the .git folder) don't contain the necessary metadata and will not work.

For example, if you're using pip, instead of https://github.com/user/proj/archive/master.zip use git+https://github.com/user/proj.git#egg=proj
make: *** [package/pkg-generic.mk:250: /tmp/instance-0/output-1/build/python-remi-2020.10.30/.stamp_built] Error 1

http://autobuild.buildroot.net/results/3a6/3a62359d0e183d45e50e999fc2c58f7805bda142/build-end.log

Any specific reason to not get the package from pypi?
Gwenhael Goavec-Merou Nov. 4, 2020, 10:05 a.m. UTC | #2
Peter, all,

On Wed, 04 Nov 2020 09:04:02 +0100
Peter Korsgaard <peter@korsgaard.com> wrote:

> >>>>> "Gwenhael" == Gwenhael Goavec-Merou <gwenj@trabucayre.com> writes:  
> 
>  > From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
>  > Signed-off-by: Gwenhael Goavec-Merou
>  > <gwenhael.goavec-merou@trabucayre.com>  
> 
> This causes a number of build errors:
> 
> LookupError: setuptools-scm was unable to detect version for
> u'/tmp/instance-0/output-1/build/python-remi-2020.10.30'.
> 
> Make sure you're either building from a fully intact git repository or PyPI
> tarballs. Most other sources (such as GitHub's tarballs, a git checkout
> without the .git folder) don't contain the necessary metadata and will not
> work.
> 
> For example, if you're using pip, instead of
> https://github.com/user/proj/archive/master.zip use
> git+https://github.com/user/proj.git#egg=proj make: ***
> [package/pkg-generic.mk:250:
> /tmp/instance-0/output-1/build/python-remi-2020.10.30/.stamp_built] Error 1
> 
> http://autobuild.buildroot.net/results/3a6/3a62359d0e183d45e50e999fc2c58f7805bda142/build-end.log
>
Weird: I'm unable to reproduce this failure... (in-tree and out-tree build). 
>
> Any specific reason to not get the package from pypi?
> 
No. I will try it if it's fix this error. But this requires to downgrade
python-remi to 2020.8.6
> -- 
> Bye, Peter Korsgaard

Bye,

Gwenhael Goavec-Merou
Peter Korsgaard Nov. 4, 2020, 11:19 a.m. UTC | #3
>>>>> "Gwenhael" == Gwenhael Goavec-Merou <gwenj@trabucayre.com> writes:

Hello,

 >> For example, if you're using pip, instead of
 >> https://github.com/user/proj/archive/master.zip use
 >> git+https://github.com/user/proj.git#egg=proj make: ***
 >> [package/pkg-generic.mk:250:
 >> /tmp/instance-0/output-1/build/python-remi-2020.10.30/.stamp_built] Error 1
 >> 
 >> http://autobuild.buildroot.net/results/3a6/3a62359d0e183d45e50e999fc2c58f7805bda142/build-end.log
 >> 
 > Weird: I'm unable to reproduce this failure... (in-tree and out-tree build). 

Notice that both failures are with python 2.7, so possibly it is related
to that?


 >> Any specific reason to not get the package from pypi?
 >> 
 > No. I will try it if it's fix this error. But this requires to downgrade
 > python-remi to 2020.8.6

Ok. Mayve contact upstream and ask why pypi isn't updated?
Gwenhael Goavec-Merou Nov. 4, 2020, 2:02 p.m. UTC | #4
Peter,
On Wed, 04 Nov 2020 12:19:16 +0100
Peter Korsgaard <peter@korsgaard.com> wrote:

> >>>>> "Gwenhael" == Gwenhael Goavec-Merou <gwenj@trabucayre.com> writes:  
> 
> Hello,
> 
>  >> For example, if you're using pip, instead of
>  >> https://github.com/user/proj/archive/master.zip use
>  >> git+https://github.com/user/proj.git#egg=proj make: ***
>  >> [package/pkg-generic.mk:250:
>  >> /tmp/instance-0/output-1/build/python-remi-2020.10.30/.stamp_built] Error
>  >> 1
>  >> 
>  >> http://autobuild.buildroot.net/results/3a6/3a62359d0e183d45e50e999fc2c58f7805bda142/build-end.log
>  >>   
>  > Weird: I'm unable to reproduce this failure... (in-tree and out-tree
>  > build).   
> 
> Notice that both failures are with python 2.7, so possibly it is related
> to that?
> 
I found why I'm not able to reproduce: my docker has no setuptools-scm.
Since https://github.com/dddomodossola/remi/pull/404 setuptools-scm is required
to obtain version from git instead of setup.py variable.
With an archive, no .git directory...
> 
>  >> Any specific reason to not get the package from pypi?
>  >>   
>  > No. I will try it if it's fix this error. But this requires to downgrade
>  > python-remi to 2020.8.6  
> 
> Ok. Mayve contact upstream and ask why pypi isn't updated?
> 
2020.10.30 is a bit recent...
I prepare a fix to downgrade python-remi and to move to pypi.
> -- 
> Bye, Peter Korsgaard

Gwen
diff mbox series

Patch

diff --git a/package/python-remi/python-remi.hash b/package/python-remi/python-remi.hash
index 2355380163..aecdbc0bb0 100644
--- a/package/python-remi/python-remi.hash
+++ b/package/python-remi/python-remi.hash
@@ -1,3 +1,3 @@ 
 # Locally computed
-sha256 678c9caf1ecffc03c4a3d59931906520545d77e9a8027ff1a1ca90fc580f56e2  python-remi-2019.9.tar.gz
-sha256 bc198f9846c1da3a1c1b1fa2b12909b021365d1e7fe9b4039245edfcec3b7f7f  LICENSE
+sha256  afe28d799d147d39954e18377e81101d045affe9c634eed5bf8dfdf888202650  python-remi-2020.10.30.tar.gz
+sha256  bc198f9846c1da3a1c1b1fa2b12909b021365d1e7fe9b4039245edfcec3b7f7f  LICENSE
diff --git a/package/python-remi/python-remi.mk b/package/python-remi/python-remi.mk
index df0e1df5a4..53836be9eb 100644
--- a/package/python-remi/python-remi.mk
+++ b/package/python-remi/python-remi.mk
@@ -4,7 +4,7 @@ 
 #
 ################################################################################
 
-PYTHON_REMI_VERSION = 2019.9
+PYTHON_REMI_VERSION = 2020.10.30
 PYTHON_REMI_SITE = $(call github,dddomodossola,remi,$(PYTHON_REMI_VERSION))
 PYTHON_REMI_LICENSE = Apache-2.0
 PYTHON_REMI_LICENSE_FILES = LICENSE