| Message ID | 20200927143752.1498115-2-romain.naour@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/3] support/scripts/gen-bootlin-toolchains: add missing glibc toolchain dependencies | expand |
Hello, On Sun, 27 Sep 2020 16:37:51 +0200 Romain Naour <romain.naour@gmail.com> wrote: > glibc toolchains must be disabled for MMU less configuration. > > Signed-off-by: Romain Naour <romain.naour@gmail.com> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> I am wondering if this one really makes sense. If there is a Bootlin toolchain that exists for a given architecture, then it really does exist. So adding another BR2_USE_MMU dependency here feels useless, no? Thomas
Hello Thomas, Le 28/09/2020 à 22:23, Thomas Petazzoni a écrit : > Hello, > > On Sun, 27 Sep 2020 16:37:51 +0200 > Romain Naour <romain.naour@gmail.com> wrote: > >> glibc toolchains must be disabled for MMU less configuration. >> >> Signed-off-by: Romain Naour <romain.naour@gmail.com> >> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > > I am wondering if this one really makes sense. If there is a Bootlin > toolchain that exists for a given architecture, then it really does > exist. So adding another BR2_USE_MMU dependency here feels useless, no? Indeed, It just about being in sync with BR2_TOOLCHAIN_BUILDROOT_GLIBC dependencies. Ok if you want to drop it. Best regards, Romain > > Thomas >
diff --git a/support/scripts/gen-bootlin-toolchains b/support/scripts/gen-bootlin-toolchains index bfc7237d48..62cdb48478 100755 --- a/support/scripts/gen-bootlin-toolchains +++ b/support/scripts/gen-bootlin-toolchains @@ -244,12 +244,16 @@ class Toolchain: if frag.startswith("BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC"): selects.append("BR2_TOOLCHAIN_EXTERNAL_UCLIBC") elif frag.startswith("BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC"): + # glibc needs mmu support + depends.append("BR2_USE_MMU") # glibc doesn't support static only configuration depends.append("!BR2_STATIC_LIBS") selects.append("BR2_TOOLCHAIN_EXTERNAL_GLIBC") # all glibc toolchains have RPC support selects.append("BR2_TOOLCHAIN_HAS_NATIVE_RPC") elif frag.startswith("BR2_TOOLCHAIN_EXTERNAL_CUSTOM_MUSL"): + # musl needs mmu support + depends.append("BR2_USE_MMU") selects.append("BR2_TOOLCHAIN_EXTERNAL_MUSL") # gcc version
glibc toolchains must be disabled for MMU less configuration. Signed-off-by: Romain Naour <romain.naour@gmail.com> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> --- support/scripts/gen-bootlin-toolchains | 4 ++++ 1 file changed, 4 insertions(+)