| Message ID | 20200921181246.88781-3-bilalwasim676@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Buildroot support for Chromebook Elm | expand |
Hello Bilal, Thanks for your contribution! On Mon, 21 Sep 2020 23:12:45 +0500 Bilal Wasim <bilalwasim676@gmail.com> wrote: > The same script is used by Chromebook Elm to generate a bootable > SD / USB image. Therefore, move the script out of the snow folder > to one level above (boards/chromebook/snow -> boards/chromebook). > > Update the Chrome snow defconfig to reflect the new location of the > script. > > Signed-off-by: Bilal Wasim <bilalwasim676@gmail.com> > --- > board/chromebook/{snow => }/mksd.sh | 0 > configs/chromebook_snow_defconfig | 2 +- > 2 files changed, 1 insertion(+), 1 deletion(-) > rename board/chromebook/{snow => }/mksd.sh (100%) I fixed up a bit the commit title and commit log, and applied. This indeed is needed as a pre-requisite to adding the Chromebook Elm configuration. Another question: could you see if this mksd.sh script can be dropped in favor of using genimage to generate the SD card image? Indeed, genimage now has support for GPT partitions, so I believe it should be able to generate a working image. Do you think you could have a look at that ? Thanks! Thomas
diff --git a/board/chromebook/snow/mksd.sh b/board/chromebook/mksd.sh similarity index 100% rename from board/chromebook/snow/mksd.sh rename to board/chromebook/mksd.sh diff --git a/configs/chromebook_snow_defconfig b/configs/chromebook_snow_defconfig index 5558c101d6..bcb94b716b 100644 --- a/configs/chromebook_snow_defconfig +++ b/configs/chromebook_snow_defconfig @@ -4,7 +4,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_15=y BR2_TARGET_GENERIC_GETTY_PORT="tty1" BR2_TARGET_GENERIC_GETTY_TERM="linux" BR2_ROOTFS_POST_BUILD_SCRIPT="board/chromebook/snow/sign.sh" -BR2_ROOTFS_POST_IMAGE_SCRIPT="board/chromebook/snow/mksd.sh" +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/chromebook/mksd.sh" BR2_LINUX_KERNEL=y BR2_LINUX_KERNEL_CUSTOM_VERSION=y BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.15"
The same script is used by Chromebook Elm to generate a bootable SD / USB image. Therefore, move the script out of the snow folder to one level above (boards/chromebook/snow -> boards/chromebook). Update the Chrome snow defconfig to reflect the new location of the script. Signed-off-by: Bilal Wasim <bilalwasim676@gmail.com> --- board/chromebook/{snow => }/mksd.sh | 0 configs/chromebook_snow_defconfig | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename board/chromebook/{snow => }/mksd.sh (100%)