| Message ID | 20200919201904.15883-1-vadim4j@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | package/mstpd: new package | expand |
Hello Vadym, Thanks for this contribution. See below for a number of comments. On Sat, 19 Sep 2020 23:19:04 +0300 Vadym Kochan <vadim4j@gmail.com> wrote: > diff --git a/package/mstpd/Config.in b/package/mstpd/Config.in > new file mode 100644 > index 0000000000..ac921b0d2b > --- /dev/null > +++ b/package/mstpd/Config.in > @@ -0,0 +1,11 @@ > +config BR2_PACKAGE_MSTPD > + bool "mstpd" > + select BR2_PACKAGE_BASH # init Are you sure bash is needed? For what? I don't see an init script being installed. > diff --git a/package/mstpd/mstpd.mk b/package/mstpd/mstpd.mk > new file mode 100644 > index 0000000000..49dc769509 > --- /dev/null > +++ b/package/mstpd/mstpd.mk > @@ -0,0 +1,20 @@ > +################################################################################ > +# > +# mstpd > +# > +################################################################################ > + > +MSTPD_VERSION = 0.0.8 > +MSTPD_SOURCE = $(MSTPD_VERSION).tar.gz > +MSTPD_SITE = https://github.com/mstpd/mstpd/archive Please use the github macro, since they haven't uploaded their own tarball. > +MSTPD_LICENSE = GPL-2.0 The license is actually GPL-2.0+ > +MSTPD_LICENSE_FILES = LICENSE > +MSTPD_AUTORECONF = YES > + > +# mstpd requires that it is installed into /sbin, not /usr/sbin > +MSTPD_CONF_OPTS = \ > + --prefix=/ \ > + --exec-prefix=/ \ > + --sbindir=/sbin This doesn't work, because it puts the stuff that normally go into /usr/share into /share, and so the manpages are still on the target as they are not located at the usual /usr/share/man location. ├── share │ ├── doc │ │ └── mstpd │ │ └── README.VLANs │ └── man │ ├── man5 │ │ └── mstpctl-utils-interfaces.5.gz │ └── man8 │ └── mstpctl.8.gz Would it be possible instead to fix things so that it can be installed into /usr/sbin ? Thanks! Thomas
Hi Thomas, On Tue, Sep 22, 2020 at 09:58:18PM +0200, Thomas Petazzoni wrote: > Hello Vadym, > > Thanks for this contribution. See below for a number of comments. > > On Sat, 19 Sep 2020 23:19:04 +0300 > Vadym Kochan <vadim4j@gmail.com> wrote: > > > diff --git a/package/mstpd/Config.in b/package/mstpd/Config.in > > new file mode 100644 > > index 0000000000..ac921b0d2b > > --- /dev/null > > +++ b/package/mstpd/Config.in > > @@ -0,0 +1,11 @@ > > +config BR2_PACKAGE_MSTPD > > + bool "mstpd" > > + select BR2_PACKAGE_BASH # init > Might be a mistake. > Are you sure bash is needed? For what? I don't see an init script being > installed. > > > diff --git a/package/mstpd/mstpd.mk b/package/mstpd/mstpd.mk > > new file mode 100644 > > index 0000000000..49dc769509 > > --- /dev/null > > +++ b/package/mstpd/mstpd.mk > > @@ -0,0 +1,20 @@ > > +################################################################################ > > +# > > +# mstpd > > +# > > +################################################################################ > > + > > +MSTPD_VERSION = 0.0.8 > > +MSTPD_SOURCE = $(MSTPD_VERSION).tar.gz > > +MSTPD_SITE = https://github.com/mstpd/mstpd/archive > > Please use the github macro, since they haven't uploaded their own > tarball. > > > +MSTPD_LICENSE = GPL-2.0 > > The license is actually GPL-2.0+ > > > +MSTPD_LICENSE_FILES = LICENSE > > +MSTPD_AUTORECONF = YES > > + > > +# mstpd requires that it is installed into /sbin, not /usr/sbin > > +MSTPD_CONF_OPTS = \ > > + --prefix=/ \ > > + --exec-prefix=/ \ > > + --sbindir=/sbin > > This doesn't work, because it puts the stuff that normally go into > /usr/share into /share, and so the manpages are still on the target as > they are not located at the usual /usr/share/man location. > > ├── share > │ ├── doc > │ │ └── mstpd > │ │ └── README.VLANs > │ └── man > │ ├── man5 > │ │ └── mstpctl-utils-interfaces.5.gz > │ └── man8 > │ └── mstpctl.8.gz > > Would it be possible instead to fix things so that it can be installed > into /usr/sbin ? I think you are right about the default prefix and --exec-prefix, but regarding --sbindir it looks like it should point to /sbin because Linux's bridge implementation calls /sbin/bridge-stp in case the STP handling is delegated to user space. > > Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Regards, Vadym Kochan
diff --git a/DEVELOPERS b/DEVELOPERS index 506e675587..15708d26ed 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -2654,6 +2654,7 @@ N: Vadim Kochan <vadim4j@gmail.com> F: package/brcm-patchram-plus/ F: package/frr/ F: package/gettext-tiny/ +F: package/mstpd/ F: package/tinyssh/ N: Valentin Korenblit <valentinkorenblit@gmail.com> diff --git a/package/Config.in b/package/Config.in index 2f30252891..737c0695c0 100644 --- a/package/Config.in +++ b/package/Config.in @@ -2145,6 +2145,7 @@ menu "Networking applications" source "package/mosquitto/Config.in" source "package/mrouted/Config.in" source "package/mrp/Config.in" + source "package/mstpd/Config.in" source "package/mtr/Config.in" source "package/nbd/Config.in" source "package/ncftp/Config.in" diff --git a/package/mstpd/Config.in b/package/mstpd/Config.in new file mode 100644 index 0000000000..ac921b0d2b --- /dev/null +++ b/package/mstpd/Config.in @@ -0,0 +1,11 @@ +config BR2_PACKAGE_MSTPD + bool "mstpd" + select BR2_PACKAGE_BASH # init + depends on BR2_USE_MMU # bash + help + Multiple Spanning Tree Protocol Daemon + + MSTPD is an open source user-space daemon licensed + under GPLv2. + + https://github.com/mstpd/mstpd diff --git a/package/mstpd/mstpd.hash b/package/mstpd/mstpd.hash new file mode 100644 index 0000000000..6cb6e2f166 --- /dev/null +++ b/package/mstpd/mstpd.hash @@ -0,0 +1,3 @@ +# Locally calculated +sha256 dd6492039368efff0bd13b3f9c8bb32d859ebfe258a70ef23b2163c4b6c35f0c 0.0.8.tar.gz +sha256 c38aee9e3c8c4d5d594ff548a1be05453023016d6286931f6512db215ec1fd42 LICENSE diff --git a/package/mstpd/mstpd.mk b/package/mstpd/mstpd.mk new file mode 100644 index 0000000000..49dc769509 --- /dev/null +++ b/package/mstpd/mstpd.mk @@ -0,0 +1,20 @@ +################################################################################ +# +# mstpd +# +################################################################################ + +MSTPD_VERSION = 0.0.8 +MSTPD_SOURCE = $(MSTPD_VERSION).tar.gz +MSTPD_SITE = https://github.com/mstpd/mstpd/archive +MSTPD_LICENSE = GPL-2.0 +MSTPD_LICENSE_FILES = LICENSE +MSTPD_AUTORECONF = YES + +# mstpd requires that it is installed into /sbin, not /usr/sbin +MSTPD_CONF_OPTS = \ + --prefix=/ \ + --exec-prefix=/ \ + --sbindir=/sbin + +$(eval $(autotools-package))