| Message ID | 20200911132907.11748-3-buildroot@heine.tech |
|---|---|
| State | Superseded |
| Headers | show |
| Series | bump grpc to 1.32 | expand |
On Fri, 11 Sep 2020 15:29:07 +0200 Michael Nosthoff via buildroot <buildroot@busybox.net> wrote: > Signed-off-by: Michael Nosthoff <buildroot@heine.tech> > --- > package/protobuf/protobuf.hash | 2 +- > package/protobuf/protobuf.mk | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/protobuf/protobuf.hash b/package/protobuf/protobuf.hash > index aa9d871561..c11f54edc3 100644 > --- a/package/protobuf/protobuf.hash > +++ b/package/protobuf/protobuf.hash > @@ -1,3 +1,3 @@ > # Locally calculated > sha256 6e5e117324afd944dcf67f36cf329843bc1a92229a8cd9bb573d7a83130fea7d LICENSE > -sha256 ccfbaaba52f67e0e6536a05f3df3f6618620d255513cfca3a07f5935b624e26b protobuf-cpp-3.12.4.tar.gz > +sha256 f8a547dfe143a9f61fadafba47fa6573713a33cb80909307c1502e26e1102298 protobuf-cpp-3.13.0.tar.gz > diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk > index 04fea3063e..2395221313 100644 > --- a/package/protobuf/protobuf.mk > +++ b/package/protobuf/protobuf.mk > @@ -7,7 +7,7 @@ > # When bumping this package, make sure to also verify if the > # python-protobuf package still works, as they share the same > # version/site variables. > -PROTOBUF_VERSION = 3.12.4 > +PROTOBUF_VERSION = 3.13.0 You need to update package/python-protobuf/python-protobuf.hash as well. We should actually update the comment above to make this clear. Thanks! Thomas
Hi, On 11.09.2020 15:49, Thomas Petazzoni wrote: > On Fri, 11 Sep 2020 15:29:07 +0200 > Michael Nosthoff via buildroot <buildroot@busybox.net> wrote: > >> # When bumping this package, make sure to also verify if the >> # python-protobuf package still works, as they share the same >> # version/site variables. >> -PROTOBUF_VERSION = 3.12.4 >> +PROTOBUF_VERSION = 3.13.0 > > You need to update package/python-protobuf/python-protobuf.hash as > well. We should actually update the comment above to make this clear. > Oops, that slipped me. I'll update this as well. What I noticed: the python-protobuf description contains a link to the protobuf-c project [0]. Which is, from what I take from the description on its website, an independently developed project. So it doesn't seem to have a connection to the python package. Wouldn't it make more sense to put the link to the google protobuf site [1] as it is in the protobuf package? Regards, Michael [0] https://github.com/protobuf-c/protobuf-c [1] https://developers.google.com/protocol-buffers
diff --git a/package/protobuf/protobuf.hash b/package/protobuf/protobuf.hash index aa9d871561..c11f54edc3 100644 --- a/package/protobuf/protobuf.hash +++ b/package/protobuf/protobuf.hash @@ -1,3 +1,3 @@ # Locally calculated sha256 6e5e117324afd944dcf67f36cf329843bc1a92229a8cd9bb573d7a83130fea7d LICENSE -sha256 ccfbaaba52f67e0e6536a05f3df3f6618620d255513cfca3a07f5935b624e26b protobuf-cpp-3.12.4.tar.gz +sha256 f8a547dfe143a9f61fadafba47fa6573713a33cb80909307c1502e26e1102298 protobuf-cpp-3.13.0.tar.gz diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk index 04fea3063e..2395221313 100644 --- a/package/protobuf/protobuf.mk +++ b/package/protobuf/protobuf.mk @@ -7,7 +7,7 @@ # When bumping this package, make sure to also verify if the # python-protobuf package still works, as they share the same # version/site variables. -PROTOBUF_VERSION = 3.12.4 +PROTOBUF_VERSION = 3.13.0 PROTOBUF_SOURCE = protobuf-cpp-$(PROTOBUF_VERSION).tar.gz PROTOBUF_SITE = https://github.com/google/protobuf/releases/download/v$(PROTOBUF_VERSION) PROTOBUF_LICENSE = BSD-3-Clause
Signed-off-by: Michael Nosthoff <buildroot@heine.tech> --- package/protobuf/protobuf.hash | 2 +- package/protobuf/protobuf.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)