| Message ID | 20200808155527.24726-1-paul@crapouillou.net |
|---|---|
| State | Accepted |
| Headers | show |
| Series | system: set default PATH according to BR2_ROOTFS_MERGED_USR | expand |
Paul, All, On 2020-08-08 17:55 +0200, Paul Cercueil spake thusly: > Use "/usr/bin:/usr/sbin" as the default path if BR2_ROOTFS_MERGED_USR > is enabled, otherwise use "/bin:/sbin:/usr/bin:/usr/sbin". Why? Is it fixing an issue, or is it just for the beauty of it? However, see below... > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > system/Config.in | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/system/Config.in b/system/Config.in > index 5063797976..b8b7c16529 100644 > --- a/system/Config.in > +++ b/system/Config.in > @@ -402,7 +402,8 @@ endif # BR2_ROOTFS_SKELETON_DEFAULT > > config BR2_SYSTEM_DEFAULT_PATH > string "Set the system's default PATH" > - default "/bin:/sbin:/usr/bin:/usr/sbin" This default is a bit unfortunate. Traditionally, distributions have a default set to /usr/sbin:/usr/bin:/sbin:/bin (i.e. exactly the reverse order that we have). However, we have that to keep the behaviour prior to 375f7488758. > + default "/usr/bin:/usr/sbin" if BR2_ROOTFS_MERGED_USR > + default "/bin:/sbin:/usr/bin:/usr/sbin" if !BR2_ROOTFS_MERGED_USR I have no strong opinion, but I wonder why you had to do that... Regards, Yann E. MORIN. > help > Sets the system's default PATH. It is being used in > /etc/profile in the skeleton-init-common package and by some > -- > 2.28.0 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hi Yann, Le jeu. 13 août 2020 à 23:38, Yann E. MORIN <yann.morin.1998@free.fr> a écrit : > Paul, All, > > On 2020-08-08 17:55 +0200, Paul Cercueil spake thusly: >> Use "/usr/bin:/usr/sbin" as the default path if >> BR2_ROOTFS_MERGED_USR >> is enabled, otherwise use "/bin:/sbin:/usr/bin:/usr/sbin". > > Why? Is it fixing an issue, or is it just for the beauty of it? I got a PR to remove /bin:/sbin from the BR2_SYSTEM_DEFAULT_PATH in my tree, I thought it made more sense to do it this way. Cheers, -Paul > However, see below... > >> Signed-off-by: Paul Cercueil <paul@crapouillou.net> >> --- >> system/Config.in | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/system/Config.in b/system/Config.in >> index 5063797976..b8b7c16529 100644 >> --- a/system/Config.in >> +++ b/system/Config.in >> @@ -402,7 +402,8 @@ endif # BR2_ROOTFS_SKELETON_DEFAULT >> >> config BR2_SYSTEM_DEFAULT_PATH >> string "Set the system's default PATH" >> - default "/bin:/sbin:/usr/bin:/usr/sbin" > > This default is a bit unfortunate. Traditionally, distributions have a > default set to /usr/sbin:/usr/bin:/sbin:/bin (i.e. exactly the reverse > order that we have). > > However, we have that to keep the behaviour prior to 375f7488758. > >> + default "/usr/bin:/usr/sbin" if BR2_ROOTFS_MERGED_USR >> + default "/bin:/sbin:/usr/bin:/usr/sbin" if !BR2_ROOTFS_MERGED_USR > > I have no strong opinion, but I wonder why you had to do that... > > Regards, > Yann E. MORIN. > >> help >> Sets the system's default PATH. It is being used in >> /etc/profile in the skeleton-init-common package and by some >> -- >> 2.28.0 >> >> _______________________________________________ >> buildroot mailing list >> buildroot@busybox.net >> http://lists.busybox.net/mailman/listinfo/buildroot > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' > conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ > | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ > There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v > conspiracy. | > '------------------------------^-------^------------------^--------------------'
Paul, All, On 2020-08-08 17:55 +0200, Paul Cercueil spake thusly: > Use "/usr/bin:/usr/sbin" as the default path if BR2_ROOTFS_MERGED_USR > is enabled, otherwise use "/bin:/sbin:/usr/bin:/usr/sbin". > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> Applied to next, thanks. Regards, Yann E. MORIN. > --- > system/Config.in | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/system/Config.in b/system/Config.in > index 5063797976..b8b7c16529 100644 > --- a/system/Config.in > +++ b/system/Config.in > @@ -402,7 +402,8 @@ endif # BR2_ROOTFS_SKELETON_DEFAULT > > config BR2_SYSTEM_DEFAULT_PATH > string "Set the system's default PATH" > - default "/bin:/sbin:/usr/bin:/usr/sbin" > + default "/usr/bin:/usr/sbin" if BR2_ROOTFS_MERGED_USR > + default "/bin:/sbin:/usr/bin:/usr/sbin" if !BR2_ROOTFS_MERGED_USR > help > Sets the system's default PATH. It is being used in > /etc/profile in the skeleton-init-common package and by some > -- > 2.28.0 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
diff --git a/system/Config.in b/system/Config.in index 5063797976..b8b7c16529 100644 --- a/system/Config.in +++ b/system/Config.in @@ -402,7 +402,8 @@ endif # BR2_ROOTFS_SKELETON_DEFAULT config BR2_SYSTEM_DEFAULT_PATH string "Set the system's default PATH" - default "/bin:/sbin:/usr/bin:/usr/sbin" + default "/usr/bin:/usr/sbin" if BR2_ROOTFS_MERGED_USR + default "/bin:/sbin:/usr/bin:/usr/sbin" if !BR2_ROOTFS_MERGED_USR help Sets the system's default PATH. It is being used in /etc/profile in the skeleton-init-common package and by some
Use "/usr/bin:/usr/sbin" as the default path if BR2_ROOTFS_MERGED_USR is enabled, otherwise use "/bin:/sbin:/usr/bin:/usr/sbin". Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- system/Config.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)