diff mbox series

[1/2] package/rpi-firmware: select BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT when needed

Message ID 20200516140221.1464063-1-thomas.petazzoni@bootlin.com
State Accepted
Headers show
Series [1/2] package/rpi-firmware: select BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT when needed | expand

Commit Message

Thomas Petazzoni May 16, 2020, 2:02 p.m. UTC
When BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS is enabled, and the
DTBs are built by Linux (i.e BR2_LINUX_KERNEL_DTS_SUPPORT is enabled),
these DTBs should be built with the -@ Device Tree compiler option, so
that they can be used together with DTB overlays. So let's select
BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT in this situation.

Fixes:

  https://bugs.busybox.net/show_bug.cgi?id=12831

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/rpi-firmware/Config.in | 2 ++
 1 file changed, 2 insertions(+)

Comments

Yann E. MORIN May 16, 2020, 7:43 p.m. UTC | #1
Thomas, All,

On 2020-05-16 16:02 +0200, Thomas Petazzoni spake thusly:
> When BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS is enabled, and the
> DTBs are built by Linux (i.e BR2_LINUX_KERNEL_DTS_SUPPORT is enabled),
> these DTBs should be built with the -@ Device Tree compiler option, so
> that they can be used together with DTB overlays. So let's select
> BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT in this situation.
> 
> Fixes:
> 
>   https://bugs.busybox.net/show_bug.cgi?id=12831
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Both appiled to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/rpi-firmware/Config.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/rpi-firmware/Config.in b/package/rpi-firmware/Config.in
> index 7cebc5e7ca..cced53f017 100644
> --- a/package/rpi-firmware/Config.in
> +++ b/package/rpi-firmware/Config.in
> @@ -85,6 +85,8 @@ config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS
>  	default y
>  	depends on BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS \
>  		|| BR2_LINUX_KERNEL_DTS_SUPPORT
> +	select BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT \
> +		if BR2_LINUX_KERNEL_DTS_SUPPORT
>  	help
>  	  Say 'y' here if you need to load one or more of the DTB
>  	  overlays, to support HATs (Hardware Attached on Top, add-on
> -- 
> 2.26.2
>
Peter Korsgaard May 29, 2020, 8:59 p.m. UTC | #2
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > When BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS is enabled, and the
 > DTBs are built by Linux (i.e BR2_LINUX_KERNEL_DTS_SUPPORT is enabled),
 > these DTBs should be built with the -@ Device Tree compiler option, so
 > that they can be used together with DTB overlays. So let's select
 > BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT in this situation.

 > Fixes:

 >   https://bugs.busybox.net/show_bug.cgi?id=12831

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2020.02.x, thanks.
diff mbox series

Patch

diff --git a/package/rpi-firmware/Config.in b/package/rpi-firmware/Config.in
index 7cebc5e7ca..cced53f017 100644
--- a/package/rpi-firmware/Config.in
+++ b/package/rpi-firmware/Config.in
@@ -85,6 +85,8 @@  config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS
 	default y
 	depends on BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS \
 		|| BR2_LINUX_KERNEL_DTS_SUPPORT
+	select BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT \
+		if BR2_LINUX_KERNEL_DTS_SUPPORT
 	help
 	  Say 'y' here if you need to load one or more of the DTB
 	  overlays, to support HATs (Hardware Attached on Top, add-on