From patchwork Fri Mar 13 01:06:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos Santos X-Patchwork-Id: 1254104 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=atQbH9EW; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48dnZj0KNqz9sPF for ; Fri, 13 Mar 2020 12:06:20 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 00DFE86E3F; Fri, 13 Mar 2020 01:06:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CcGIuA4yCoLf; Fri, 13 Mar 2020 01:06:18 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 48F8A86E35; Fri, 13 Mar 2020 01:06:18 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id DCB7A1BF364 for ; Fri, 13 Mar 2020 01:06:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id D8DF32634D for ; Fri, 13 Mar 2020 01:06:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V06WZMb4CeZ7 for ; Fri, 13 Mar 2020 01:06:16 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by silver.osuosl.org (Postfix) with ESMTPS id A20D5265DF for ; Fri, 13 Mar 2020 01:06:16 +0000 (UTC) Received: by mail-qk1-f177.google.com with SMTP id z25so4915004qkj.4 for ; Thu, 12 Mar 2020 18:06:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=2LXHXWNTu6tLMfDsidFw3OLwGkgUTOXUEnCfYowgj8Q=; b=atQbH9EWiYc7dM4LGlXECooQJviHcqgI3B8dbR6fz2rWOGvyCKacldTnZ2ZoKUxUZd z0LdgzUsohB4iML9sKJLGUaYZVxtaHNt0KXoYDeUEdMpaeEvIUTzD+nJRAYAh4ZMoQXp soAdB2L7EXYlZxxcudVgmqT3QngNnKGI0TiZtM46OLq0Nlb7AmuiKjWaggMThISt2q5I 1MDrsMoz8D5vfm2li8kx7ymVFD3OuH97vBcY2Zb9hwr7koN4XpcLie9q8fmn6UCdmTL3 v8ce01aPDv5nnGVkDs68da+/bt+BPFYtcHk2tJ7AgYrJErfHaZHLjOStGbgYeGewCEYw EhZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2LXHXWNTu6tLMfDsidFw3OLwGkgUTOXUEnCfYowgj8Q=; b=IA7kTgAv5HkkQv9f3kDzLpyfG4eAxMDivqmYaMcX4x8QPq4lsb2+qHicWFLbTICEXA 6UQEoLzysSiIcrkDQow+QtT4Lg4YXDvHORHUtV+o+IKkjsMzYc8yziJlQlp1xdut2j+X 0bQMhoUDbZZRHqg8GC8eyIIOvfOki8Mi9IFyNTkQqBftZzTc/ChwJIhC20wlY3VVVR7p PIR6ljAUmB7qje4kH1QLg13NYm/eqTaUNYNpfuPLHqi9I5MEnYE0Gc6YcojNzCD6stnP +y0NNkAwHZi6OJX26Jc0ckFj29Vrx+PrExNHwJNIbHSnGCSTaF757DmJy+0J0XuHoBaq CugQ== X-Gm-Message-State: ANhLgQ3bG4CBvfgAAkSvaZ6TGeH+ziLkjsz9RS3X+leRNuLlBFI1IESQ metNmwK+cg4y6wzNkRS8rnU0VuK9lvE= X-Google-Smtp-Source: ADFU+vs72C2j5lX7zOUDktmCXWWAOvt2Zk8eeOgkgtHZm07b9q7xbLmwVmeHmRMafnV+jy3a3E7OQg== X-Received: by 2002:a37:741:: with SMTP id 62mr10266518qkh.422.1584061575402; Thu, 12 Mar 2020 18:06:15 -0700 (PDT) Received: from casantos.remote.com ([177.97.126.92]) by smtp.gmail.com with ESMTPSA id e66sm667052qkd.129.2020.03.12.18.06.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2020 18:06:14 -0700 (PDT) From: unixmania@gmail.com To: buildroot@buildroot.org Date: Thu, 12 Mar 2020 22:06:11 -0300 Message-Id: <20200313010611.17176-1-unixmania@gmail.com> X-Mailer: git-send-email 2.18.2 Subject: [Buildroot] [PATCH v2] package/util-linux: fix build for riscv64 and powerpc64le X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Carlos Santos MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Carlos Santos Pull two upstream patches that fix the declaration of pidfd_open and pidfd_send_signal. Fixes: http://autobuild.buildroot.net/results/2396b04478f9d358b94f2e2e05540625ddc9f205/ http://autobuild.buildroot.net/results/ed4b5ec61bd33d3ccf0ebb16000af46d0499366d/ Signed-off-by: Carlos Santos --- Chanves v1->v2: add SOB to patches --- ...-types.h-before-checking-SYS_pidfd_s.patch | 62 +++++++++++++++++++ .../0007-include-cleanup-pidfd-inckudes.patch | 40 ++++++++++++ 2 files changed, 102 insertions(+) create mode 100644 package/util-linux/0006-kill-include-sys-types.h-before-checking-SYS_pidfd_s.patch create mode 100644 package/util-linux/0007-include-cleanup-pidfd-inckudes.patch diff --git a/package/util-linux/0006-kill-include-sys-types.h-before-checking-SYS_pidfd_s.patch b/package/util-linux/0006-kill-include-sys-types.h-before-checking-SYS_pidfd_s.patch new file mode 100644 index 0000000000..183b725a32 --- /dev/null +++ b/package/util-linux/0006-kill-include-sys-types.h-before-checking-SYS_pidfd_s.patch @@ -0,0 +1,62 @@ +From 3cfde0370d3a8949df0c5bcf447cec6692910ed2 Mon Sep 17 00:00:00 2001 +From: Sami Kerola +Date: Sat, 15 Feb 2020 21:12:50 +0000 +Subject: [PATCH] kill: include sys/types.h before checking + SYS_pidfd_send_signal + +Including sys/types.h must happen before SYS_pidfd_send_signal is checked, +because that header defines variable in normal conditions. When sys/types.h +does not have SYS_pidfd_send_signal then fallback is defined in config.h +that is included by default, and has therefore worked fine before and after +this change. + +Signed-off-by: Sami Kerola +Signed-off-by: Carlos Santos +--- + include/pidfd-utils.h | 18 ++++++++++-------- + 1 file changed, 10 insertions(+), 8 deletions(-) + +diff --git a/include/pidfd-utils.h b/include/pidfd-utils.h +index 593346576..0baedd2c9 100644 +--- a/include/pidfd-utils.h ++++ b/include/pidfd-utils.h +@@ -1,26 +1,28 @@ + #ifndef UTIL_LINUX_PIDFD_UTILS + #define UTIL_LINUX_PIDFD_UTILS + +-#if defined(__linux__) && defined(SYS_pidfd_send_signal) +-# include ++#if defined(__linux__) + # include ++# if defined(SYS_pidfd_send_signal) ++# include + +-# ifndef HAVE_PIDFD_OPEN ++# ifndef HAVE_PIDFD_OPEN + static inline int pidfd_send_signal(int pidfd, int sig, siginfo_t *info, + unsigned int flags) + { + return syscall(SYS_pidfd_send_signal, pidfd, sig, info, flags); + } +-# endif ++# endif + +-# ifndef HAVE_PIDFD_SEND_SIGNAL ++# ifndef HAVE_PIDFD_SEND_SIGNAL + static inline int pidfd_open(pid_t pid, unsigned int flags) + { + return syscall(SYS_pidfd_open, pid, flags); + } +-# endif ++# endif + +-# define UL_HAVE_PIDFD 1 ++# define UL_HAVE_PIDFD 1 + +-#endif /* __linux__ && SYS_pidfd_send_signal */ ++# endif /* SYS_pidfd_send_signal */ ++#endif /* __linux__ */ + #endif /* UTIL_LINUX_PIDFD_UTILS */ +-- +2.18.2 + diff --git a/package/util-linux/0007-include-cleanup-pidfd-inckudes.patch b/package/util-linux/0007-include-cleanup-pidfd-inckudes.patch new file mode 100644 index 0000000000..73f3118b0a --- /dev/null +++ b/package/util-linux/0007-include-cleanup-pidfd-inckudes.patch @@ -0,0 +1,40 @@ +From 0a4035ff2e4fd5b5ae0cf8f8665696c2aff53b75 Mon Sep 17 00:00:00 2001 +From: Karel Zak +Date: Tue, 10 Mar 2020 11:43:16 +0100 +Subject: [PATCH] include: cleanup pidfd inckudes + +Signed-off-by: Karel Zak +Signed-off-by: Carlos Santos +--- + include/pidfd-utils.h | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/include/pidfd-utils.h b/include/pidfd-utils.h +index 0baedd2c9..4a6c3a604 100644 +--- a/include/pidfd-utils.h ++++ b/include/pidfd-utils.h +@@ -3,10 +3,10 @@ + + #if defined(__linux__) + # include +-# if defined(SYS_pidfd_send_signal) ++# if defined(SYS_pidfd_send_signal) && defined(SYS_pidfd_open) + # include + +-# ifndef HAVE_PIDFD_OPEN ++# ifndef HAVE_PIDFD_SEND_SIGNAL + static inline int pidfd_send_signal(int pidfd, int sig, siginfo_t *info, + unsigned int flags) + { +@@ -14,7 +14,7 @@ static inline int pidfd_send_signal(int pidfd, int sig, siginfo_t *info, + } + # endif + +-# ifndef HAVE_PIDFD_SEND_SIGNAL ++# ifndef HAVE_PIDFD_OPEN + static inline int pidfd_open(pid_t pid, unsigned int flags) + { + return syscall(SYS_pidfd_open, pid, flags); +-- +2.18.2 +