| Message ID | 20200224172652.30932-2-vadim4j@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/3] package/libyang: enable LYD_PRIV option | expand |
On Mon, 24 Feb 2020 19:26:50 +0200 Vadim Kochan <vadim4j@gmail.com> wrote: > This option is required by frr package, so enable it by default. > > Signed-off-by: Vadim Kochan <vadim4j@gmail.com> What is this option doing? How much more space does it require? In other words, do we want to enable it unconditionally, or do we want to make it optional ? Thomas
On Mon, Feb 24, 2020 at 08:52:06PM +0100, Thomas Petazzoni wrote: > On Mon, 24 Feb 2020 19:26:50 +0200 > Vadim Kochan <vadim4j@gmail.com> wrote: > > > This option is required by frr package, so enable it by default. > > > > Signed-off-by: Vadim Kochan <vadim4j@gmail.com> > > What is this option doing? How much more space does it require? In > other words, do we want to enable it unconditionally, or do we want to > make it optional ? > Sorry, I did not compare it, actually this option might be turned on if rtrlib is selected. Moreover rtrlib adding might be dropped from this series because (my mistake I missed this) frr requires rtrlib for rpki support only, which might be not enabled by default. Regards, Vadim Kochan
diff --git a/package/libyang/libyang.mk b/package/libyang/libyang.mk index 648ffeb6a3..e701c6f448 100644 --- a/package/libyang/libyang.mk +++ b/package/libyang/libyang.mk @@ -15,7 +15,8 @@ HOST_LIBYANG_DEPENDENCIES = host-pcre LIBYANG_CONF_OPTS = \ -DENABLE_VALGRIND_TESTS=OFF \ - -DGEN_PYTHON_BINDINGS=OFF + -DGEN_PYTHON_BINDINGS=OFF \ + -DENABLE_LYD_PRIV=ON HOST_LIBYANG_CONF_OPTS = \ -DENABLE_VALGRIND_TESTS=OFF \
This option is required by frr package, so enable it by default. Signed-off-by: Vadim Kochan <vadim4j@gmail.com> --- package/libyang/libyang.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)