diff mbox series

[RFC,1/1] package/rauc: select fw_printenv for uboot based systems

Message ID 20191205094238.69841-1-titouan.christophe@railnova.eu
State Accepted
Headers show
Series [RFC,1/1] package/rauc: select fw_printenv for uboot based systems | expand

Commit Message

Titouan Christophe Dec. 5, 2019, 9:42 a.m. UTC
When operating on a uboot based system, rauc interacts with
the bootloader environment using fw_printenv and fw_setenv [1].

These commands should therefore be present on the target if
the system being built uses uboot.

[1] See:
https://github.com/rauc/rauc/blob/v1.2/src/bootchooser.c#L21-L22
https://github.com/rauc/rauc/blob/v1.2/src/bootchooser.c#L644-L645

Signed-off-by: Titouan Christophe <titouan.christophe@railnova.eu>
---
Note: we should maybe do the same for EFI, Grub and Barebox, but
      I'm not familiar with these ones.
---
 package/rauc/Config.in | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Petazzoni Dec. 5, 2019, 8:38 p.m. UTC | #1
On Thu,  5 Dec 2019 10:42:38 +0100
Titouan Christophe <titouan.christophe@railnova.eu> wrote:

> When operating on a uboot based system, rauc interacts with
> the bootloader environment using fw_printenv and fw_setenv [1].
> 
> These commands should therefore be present on the target if
> the system being built uses uboot.
> 
> [1] See:
> https://github.com/rauc/rauc/blob/v1.2/src/bootchooser.c#L21-L22
> https://github.com/rauc/rauc/blob/v1.2/src/bootchooser.c#L644-L645
> 
> Signed-off-by: Titouan Christophe <titouan.christophe@railnova.eu>
> ---
> Note: we should maybe do the same for EFI, Grub and Barebox, but
>       I'm not familiar with these ones.
> ---
>  package/rauc/Config.in | 2 ++
>  1 file changed, 2 insertions(+)

Applied to master, thanks.

Thomas
Peter Korsgaard Dec. 7, 2019, 11:09 a.m. UTC | #2
>>>>> "Titouan" == Titouan Christophe <titouan.christophe@railnova.eu> writes:

 > When operating on a uboot based system, rauc interacts with
 > the bootloader environment using fw_printenv and fw_setenv [1].

 > These commands should therefore be present on the target if
 > the system being built uses uboot.

 > [1] See:
 > https://github.com/rauc/rauc/blob/v1.2/src/bootchooser.c#L21-L22
 > https://github.com/rauc/rauc/blob/v1.2/src/bootchooser.c#L644-L645

 > Signed-off-by: Titouan Christophe <titouan.christophe@railnova.eu>

Committed to 2019.02.x, 2019.08.x and 2019.11.x, thanks.
diff mbox series

Patch

diff --git a/package/rauc/Config.in b/package/rauc/Config.in
index 4a1516a595..676ff42b51 100644
--- a/package/rauc/Config.in
+++ b/package/rauc/Config.in
@@ -7,6 +7,8 @@  config BR2_PACKAGE_RAUC
 	select BR2_PACKAGE_OPENSSL
 	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_SQUASHFS # run-time dependency
+	select BR2_PACKAGE_UBOOT_TOOLS if BR2_TARGET_UBOOT # run-time dependency
+	select BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV if BR2_TARGET_UBOOT
 	help
 	  RAUC is the Robust Auto-Update Controller developed by
 	  Pengutronix. It supports updating embedded Linux