| Message ID | 20191030132759.8643-3-unixmania@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | support hooks and tables in virtual packages | expand |
On 30/10/2019 14:27, unixmania@gmail.com wrote: > From: Carlos Santos <unixmania@gmail.com> > > Use LUAINTERPRETER_TARGET_FINALIZE_HOOKS, now that it's suported by > virtual packages. > > Signed-off-by: Carlos Santos <unixmania@gmail.com> > --- > package/luainterpreter/luainterpreter.mk | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/package/luainterpreter/luainterpreter.mk b/package/luainterpreter/luainterpreter.mk > index 58d421b183..828b71e8d2 100644 > --- a/package/luainterpreter/luainterpreter.mk > +++ b/package/luainterpreter/luainterpreter.mk > @@ -6,16 +6,11 @@ > > LUAINTERPRETER_ABIVER = $(call qstrip,$(BR2_PACKAGE_LUAINTERPRETER_ABI_VERSION)) > > -# Lua packages often install documentation, clean that up globally This comment was still relevant, so I kept that and applied to next, thanks. Regards, Arnout > -# Since luainterpreter is a virtual package, we can't use > -# LUAINTERPRETER_TARGET_FINALIZE_HOOKS > -ifeq ($(BR2_PACKAGE_HAS_LUAINTERPRETER),y) > define LUAINTERPRETER_REMOVE_DOC > rm -rf $(TARGET_DIR)/usr/share/lua/$(LUAINTERPRETER_ABIVER)/doc > endef > > -TARGET_FINALIZE_HOOKS += LUAINTERPRETER_REMOVE_DOC > -endif > +LUAINTERPRETER_TARGET_FINALIZE_HOOKS += LUAINTERPRETER_REMOVE_DOC > > $(eval $(virtual-package)) > $(eval $(host-virtual-package)) >
diff --git a/package/luainterpreter/luainterpreter.mk b/package/luainterpreter/luainterpreter.mk index 58d421b183..828b71e8d2 100644 --- a/package/luainterpreter/luainterpreter.mk +++ b/package/luainterpreter/luainterpreter.mk @@ -6,16 +6,11 @@ LUAINTERPRETER_ABIVER = $(call qstrip,$(BR2_PACKAGE_LUAINTERPRETER_ABI_VERSION)) -# Lua packages often install documentation, clean that up globally -# Since luainterpreter is a virtual package, we can't use -# LUAINTERPRETER_TARGET_FINALIZE_HOOKS -ifeq ($(BR2_PACKAGE_HAS_LUAINTERPRETER),y) define LUAINTERPRETER_REMOVE_DOC rm -rf $(TARGET_DIR)/usr/share/lua/$(LUAINTERPRETER_ABIVER)/doc endef -TARGET_FINALIZE_HOOKS += LUAINTERPRETER_REMOVE_DOC -endif +LUAINTERPRETER_TARGET_FINALIZE_HOOKS += LUAINTERPRETER_REMOVE_DOC $(eval $(virtual-package)) $(eval $(host-virtual-package))