diff mbox series

[3/3,DO,NOT,MERGE] board/beelink_gs1: add root passwd and eth0 auto

Message ID 20190920190813.21516-4-peron.clem@gmail.com
State Changes Requested
Headers show
Series Add Beelink GS1 board | expand

Commit Message

Clément Péron Sept. 20, 2019, 7:08 p.m. UTC 
Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
 board/beelink/gs1/rootfs_overlay/etc/network/interfaces | 7 +++++++
 configs/beelink_gs1_defconfig                           | 2 ++
 2 files changed, 9 insertions(+)
 create mode 100644 board/beelink/gs1/rootfs_overlay/etc/network/interfaces

Comments

Arnout Vandecappelle Sept. 21, 2019, 10:36 a.m. UTC | #1 
On 20/09/2019 21:08, Clément Péron wrote:
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
>  board/beelink/gs1/rootfs_overlay/etc/network/interfaces | 7 +++++++
>  configs/beelink_gs1_defconfig                           | 2 ++
>  2 files changed, 9 insertions(+)
>  create mode 100644 board/beelink/gs1/rootfs_overlay/etc/network/interfaces
> 
> diff --git a/board/beelink/gs1/rootfs_overlay/etc/network/interfaces b/board/beelink/gs1/rootfs_overlay/etc/network/interfaces
> new file mode 100644
> index 0000000000..0af5845617
> --- /dev/null
> +++ b/board/beelink/gs1/rootfs_overlay/etc/network/interfaces
> @@ -0,0 +1,7 @@
> +# Configure Loopback
> +auto lo
> +iface lo inet loopback
> +
> +# Configure eth0 with DHCP
> +auto eth0
> +iface eth0 inet dhcp

 Doesn't BR2_SYSTEM_DHCP="eth0" work? We do that in a lot of other defconfigs.

 Regards,
 Arnout

> diff --git a/configs/beelink_gs1_defconfig b/configs/beelink_gs1_defconfig
> index ccf4771cc7..4794df7914 100644
> --- a/configs/beelink_gs1_defconfig
> +++ b/configs/beelink_gs1_defconfig
> @@ -3,6 +3,8 @@ BR2_aarch64=y
>  BR2_ARM_FPU_VFPV4=y
>  BR2_TARGET_GENERIC_ISSUE="Welcome to Beelink GS1"
>  BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
> +BR2_TARGET_GENERIC_ROOT_PASSWD="admin"
> +BR2_ROOTFS_OVERLAY="board/beelink/gs1/rootfs_overlay"
>  BR2_ROOTFS_POST_BUILD_SCRIPT="board/beelink/gs1/post-build.sh"
>  BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
>  BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/beelink/gs1/genimage.cfg"
>
Clément Péron Oct. 10, 2019, 6:12 p.m. UTC | #2 
Hi Arnout,

On Sat, 21 Sep 2019 at 12:36, Arnout Vandecappelle <arnout@mind.be> wrote:
>
>
>
> On 20/09/2019 21:08, Clément Péron wrote:
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > ---
> >  board/beelink/gs1/rootfs_overlay/etc/network/interfaces | 7 +++++++
> >  configs/beelink_gs1_defconfig                           | 2 ++
> >  2 files changed, 9 insertions(+)
> >  create mode 100644 board/beelink/gs1/rootfs_overlay/etc/network/interfaces
> >
> > diff --git a/board/beelink/gs1/rootfs_overlay/etc/network/interfaces b/board/beelink/gs1/rootfs_overlay/etc/network/interfaces
> > new file mode 100644
> > index 0000000000..0af5845617
> > --- /dev/null
> > +++ b/board/beelink/gs1/rootfs_overlay/etc/network/interfaces
> > @@ -0,0 +1,7 @@
> > +# Configure Loopback
> > +auto lo
> > +iface lo inet loopback
> > +
> > +# Configure eth0 with DHCP
> > +auto eth0
> > +iface eth0 inet dhcp
>
>  Doesn't BR2_SYSTEM_DHCP="eth0" work? We do that in a lot of other defconfigs.
Thanks for the tips, I didn't know about this option.

Regards,
Clément

>
>  Regards,
>  Arnout
>
> > diff --git a/configs/beelink_gs1_defconfig b/configs/beelink_gs1_defconfig
> > index ccf4771cc7..4794df7914 100644
> > --- a/configs/beelink_gs1_defconfig
> > +++ b/configs/beelink_gs1_defconfig
> > @@ -3,6 +3,8 @@ BR2_aarch64=y
> >  BR2_ARM_FPU_VFPV4=y
> >  BR2_TARGET_GENERIC_ISSUE="Welcome to Beelink GS1"
> >  BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
> > +BR2_TARGET_GENERIC_ROOT_PASSWD="admin"
> > +BR2_ROOTFS_OVERLAY="board/beelink/gs1/rootfs_overlay"
> >  BR2_ROOTFS_POST_BUILD_SCRIPT="board/beelink/gs1/post-build.sh"
> >  BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> >  BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/beelink/gs1/genimage.cfg"
> >
diff mbox series

Patch

diff --git a/board/beelink/gs1/rootfs_overlay/etc/network/interfaces b/board/beelink/gs1/rootfs_overlay/etc/network/interfaces
new file mode 100644
index 0000000000..0af5845617
--- /dev/null
+++ b/board/beelink/gs1/rootfs_overlay/etc/network/interfaces
@@ -0,0 +1,7 @@ 
+# Configure Loopback
+auto lo
+iface lo inet loopback
+
+# Configure eth0 with DHCP
+auto eth0
+iface eth0 inet dhcp
diff --git a/configs/beelink_gs1_defconfig b/configs/beelink_gs1_defconfig
index ccf4771cc7..4794df7914 100644
--- a/configs/beelink_gs1_defconfig
+++ b/configs/beelink_gs1_defconfig
@@ -3,6 +3,8 @@  BR2_aarch64=y
 BR2_ARM_FPU_VFPV4=y
 BR2_TARGET_GENERIC_ISSUE="Welcome to Beelink GS1"
 BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
+BR2_TARGET_GENERIC_ROOT_PASSWD="admin"
+BR2_ROOTFS_OVERLAY="board/beelink/gs1/rootfs_overlay"
 BR2_ROOTFS_POST_BUILD_SCRIPT="board/beelink/gs1/post-build.sh"
 BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
 BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/beelink/gs1/genimage.cfg"