| Message ID | 20190903211341.10341-9-jerzy.m.grzegorek@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Improve alphabetical order checking of Config.in files | expand |
Hello,
On Tue, Sep 03, 2019 at 06:13 PM, Jerzy Grzegorek wrote:
> Because function get_line() has only one line so use it inline.
IMO it was better before this patch, so I would drop it, but if your patch
convince a maintainer, I am OK too.
So I will not give a tag, but it is not incorrect.
Regards,
Ricardo
Hi Ricardo, > Hello, > > On Tue, Sep 03, 2019 at 06:13 PM, Jerzy Grzegorek wrote: > >> Because function get_line() has only one line so use it inline. > IMO it was better before this patch, so I would drop it, but if your patch > convince a maintainer, I am OK too. > So I will not give a tag, but it is not incorrect. Ok, so I'll drop this patch. Thanks for the review. Regards, Jerzy > Regards, Ricardo
diff --git a/utils/checkpackagelib/lib_config.py b/utils/checkpackagelib/lib_config.py index 3d8f08cac9..f39a4b0599 100644 --- a/utils/checkpackagelib/lib_config.py +++ b/utils/checkpackagelib/lib_config.py @@ -69,9 +69,6 @@ class CommentsMenusPackagesOrder(_CheckFunction): self.state = "" self.new_package = "" - def get_level(self): - return len(self.state.split('-')) - 1 - def initialize_package_level_elements(self, text): try: self.menu_of_packages[self.level] = text[:-1] @@ -83,7 +80,7 @@ class CommentsMenusPackagesOrder(_CheckFunction): self.print_package_warning.append(True) def initialize_level_elements(self, text): - self.level = self.get_level() + self.level = len(self.state.split('-')) - 1 self.initialize_package_level_elements(text) def check_line(self, lineno, text): @@ -123,7 +120,7 @@ class CommentsMenusPackagesOrder(_CheckFunction): elif text.startswith("endmenu"): self.state = self.state[:-5] - self.level = self.get_level() + self.level = len(self.state.split('-')) - 1 elif source_line: self.new_package = source_line.group(1)
Because function get_line() has only one line so use it inline. Signed-off-by: Jerzy Grzegorek <jerzy.m.grzegorek@gmail.com> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> --- utils/checkpackagelib/lib_config.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)