| Message ID | 20190705065015.29773-1-abloemert@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/1] package/gstreamer1/gst1-plugins-good: add option to enable/disable shout2 plugin | expand |
Hello Arnould, a little shorter subject line as the following should be enough: package/gst1-plugins-good: add shout2 plugin option On Fri, 5 Jul 2019 08:50:15 +0200, Arnold Bloemert <abloemert@gmail.com> wrote: > Currently there is no way to turn the shout2 plugin on. > Create a menu entry allowing users to disable or enable the plugin, > like we have for other features (for example the Pulseaudio plugin). Given text is more suitable for a cover letter ;-), no special justification for adding a missing option needed.... > > Signed-off-by: Arnold Bloemert <abloemert@gmail.com> > --- > package/gstreamer1/gst1-plugins-good/Config.in | 6 ++++++ > .../gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 9 +++++++-- > 2 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/package/gstreamer1/gst1-plugins-good/Config.in b/package/gstreamer1/gst1-plugins-good/Config.in > index 433084fd6b..ce85388eb0 100644 > --- a/package/gstreamer1/gst1-plugins-good/Config.in > +++ b/package/gstreamer1/gst1-plugins-good/Config.in > @@ -300,6 +300,12 @@ comment "qmlgl (qt5) plugin needs an OpenGL-capable Qt5 backend" > depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE > depends on !BR2_PACKAGE_QT5_GL_AVAILABLE && !BR2_PACKAGE_QT5_VERSION_LATEST > > +config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2 > + bool "shout2" > + select BR2_PACKAGE_LIBSHOUT > + help > + Elements to send data to an icecast server using libshout2 > + > config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2 > bool "v4l2" > depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # multi planar api > diff --git a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk > index 829d27a2da..0a6cc77208 100644 > --- a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk > +++ b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk > @@ -25,8 +25,7 @@ GST1_PLUGINS_GOOD_CONF_OPTS = \ > # Options which require currently unpackaged libraries > GST1_PLUGINS_GOOD_CONF_OPTS += \ > --disable-libdv \ > - --disable-dv1394 \ > - --disable-shout2 > + --disable-dv1394 > > GST1_PLUGINS_GOOD_DEPENDENCIES = gstreamer1 gst1-plugins-base > > @@ -343,6 +342,12 @@ else > GST1_PLUGINS_GOOD_CONF_OPTS += --disable-qt > endif > > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2),y) > +GST1_PLUGINS_GOOD_CONF_OPTS += --enable-shout2 ...missing: GST1_PLUGINS_GOOD_DEPENDENCIES += libshout Otherwise looks good! Regards, Peter > +else > +GST1_PLUGINS_GOOD_CONF_OPTS += --disable-shout2 > +endif > + > ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2),y) > GST1_PLUGINS_GOOD_CONF_OPTS += --enable-gst_v4l2 > else
Hi Peter, I tried to create a patch in the same style as the patch for jack by Adam, but I like your proposal to simplify. The missing dependency in the .mk file was a stupid mistake, thanks for noticing it! I'll create a new revision of the patch, contributing to Buildroot is new for me, so hopefully I'm doing it right. Kind regards, Arnold Op vr 5 jul. 2019 om 17:18 schreef Peter Seiderer <ps.report@gmx.net>: > Hello Arnould, > > a little shorter subject line as the following should be enough: > > package/gst1-plugins-good: add shout2 plugin option > > > On Fri, 5 Jul 2019 08:50:15 +0200, Arnold Bloemert <abloemert@gmail.com> > wrote: > > > Currently there is no way to turn the shout2 plugin on. > > Create a menu entry allowing users to disable or enable the plugin, > > like we have for other features (for example the Pulseaudio plugin). > > Given text is more suitable for a cover letter ;-), no special > justification > for adding a missing option needed.... > > > > > Signed-off-by: Arnold Bloemert <abloemert@gmail.com> > > --- > > package/gstreamer1/gst1-plugins-good/Config.in | 6 ++++++ > > .../gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 9 +++++++-- > > 2 files changed, 13 insertions(+), 2 deletions(-) > > > > diff --git a/package/gstreamer1/gst1-plugins-good/Config.in > b/package/gstreamer1/gst1-plugins-good/Config.in > > index 433084fd6b..ce85388eb0 100644 > > --- a/package/gstreamer1/gst1-plugins-good/Config.in > > +++ b/package/gstreamer1/gst1-plugins-good/Config.in > > @@ -300,6 +300,12 @@ comment "qmlgl (qt5) plugin needs an OpenGL-capable > Qt5 backend" > > depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE > > depends on !BR2_PACKAGE_QT5_GL_AVAILABLE && > !BR2_PACKAGE_QT5_VERSION_LATEST > > > > +config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2 > > + bool "shout2" > > + select BR2_PACKAGE_LIBSHOUT > > + help > > + Elements to send data to an icecast server using libshout2 > > + > > config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2 > > bool "v4l2" > > depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # multi planar api > > diff --git a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk > b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk > > index 829d27a2da..0a6cc77208 100644 > > --- a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk > > +++ b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk > > @@ -25,8 +25,7 @@ GST1_PLUGINS_GOOD_CONF_OPTS = \ > > # Options which require currently unpackaged libraries > > GST1_PLUGINS_GOOD_CONF_OPTS += \ > > --disable-libdv \ > > - --disable-dv1394 \ > > - --disable-shout2 > > + --disable-dv1394 > > > > GST1_PLUGINS_GOOD_DEPENDENCIES = gstreamer1 gst1-plugins-base > > > > @@ -343,6 +342,12 @@ else > > GST1_PLUGINS_GOOD_CONF_OPTS += --disable-qt > > endif > > > > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2),y) > > +GST1_PLUGINS_GOOD_CONF_OPTS += --enable-shout2 > > ...missing: > > GST1_PLUGINS_GOOD_DEPENDENCIES += libshout > > Otherwise looks good! > > Regards, > Peter > > > +else > > +GST1_PLUGINS_GOOD_CONF_OPTS += --disable-shout2 > > +endif > > + > > ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2),y) > > GST1_PLUGINS_GOOD_CONF_OPTS += --enable-gst_v4l2 > > else > >
Hello Arnold, On Fri, 5 Jul 2019 23:48:33 +0200, Arnold Bloemert <abloemert@gmail.com> wrote: > Hi Peter, > > I tried to create a patch in the same style as the patch for jack by Adam, > but I like your proposal to simplify. Ohhh, I see (the comments are mainly a matter of taste)... > > The missing dependency in the .mk file was a stupid mistake, thanks for > noticing it! No problem (catching it is the main purpose of the review process ;-) )... > > I'll create a new revision of the patch, contributing to Buildroot is new > for me, so hopefully I'm doing it right. Many thanks for contributing, every patch is welcome! Yours is nearly perfect, only one nitpick (see comment on v2 of the patch)... Regards, Peter > > Kind regards, > > Arnold > > Op vr 5 jul. 2019 om 17:18 schreef Peter Seiderer <ps.report@gmx.net>: > > > Hello Arnould, > > > > a little shorter subject line as the following should be enough: > > > > package/gst1-plugins-good: add shout2 plugin option > > > > > > On Fri, 5 Jul 2019 08:50:15 +0200, Arnold Bloemert <abloemert@gmail.com> > > wrote: > > > > > Currently there is no way to turn the shout2 plugin on. > > > Create a menu entry allowing users to disable or enable the plugin, > > > like we have for other features (for example the Pulseaudio plugin). > > > > Given text is more suitable for a cover letter ;-), no special > > justification > > for adding a missing option needed.... > > > > > > > > Signed-off-by: Arnold Bloemert <abloemert@gmail.com> > > > --- > > > package/gstreamer1/gst1-plugins-good/Config.in | 6 ++++++ > > > .../gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 9 +++++++-- > > > 2 files changed, 13 insertions(+), 2 deletions(-) > > > > > > diff --git a/package/gstreamer1/gst1-plugins-good/Config.in > > b/package/gstreamer1/gst1-plugins-good/Config.in > > > index 433084fd6b..ce85388eb0 100644 > > > --- a/package/gstreamer1/gst1-plugins-good/Config.in > > > +++ b/package/gstreamer1/gst1-plugins-good/Config.in > > > @@ -300,6 +300,12 @@ comment "qmlgl (qt5) plugin needs an OpenGL-capable > > Qt5 backend" > > > depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE > > > depends on !BR2_PACKAGE_QT5_GL_AVAILABLE && > > !BR2_PACKAGE_QT5_VERSION_LATEST > > > > > > +config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2 > > > + bool "shout2" > > > + select BR2_PACKAGE_LIBSHOUT > > > + help > > > + Elements to send data to an icecast server using libshout2 > > > + > > > config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2 > > > bool "v4l2" > > > depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # multi planar api > > > diff --git a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk > > b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk > > > index 829d27a2da..0a6cc77208 100644 > > > --- a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk > > > +++ b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk > > > @@ -25,8 +25,7 @@ GST1_PLUGINS_GOOD_CONF_OPTS = \ > > > # Options which require currently unpackaged libraries > > > GST1_PLUGINS_GOOD_CONF_OPTS += \ > > > --disable-libdv \ > > > - --disable-dv1394 \ > > > - --disable-shout2 > > > + --disable-dv1394 > > > > > > GST1_PLUGINS_GOOD_DEPENDENCIES = gstreamer1 gst1-plugins-base > > > > > > @@ -343,6 +342,12 @@ else > > > GST1_PLUGINS_GOOD_CONF_OPTS += --disable-qt > > > endif > > > > > > +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2),y) > > > +GST1_PLUGINS_GOOD_CONF_OPTS += --enable-shout2 > > > > ...missing: > > > > GST1_PLUGINS_GOOD_DEPENDENCIES += libshout > > > > Otherwise looks good! > > > > Regards, > > Peter > > > > > +else > > > +GST1_PLUGINS_GOOD_CONF_OPTS += --disable-shout2 > > > +endif > > > + > > > ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2),y) > > > GST1_PLUGINS_GOOD_CONF_OPTS += --enable-gst_v4l2 > > > else > > > >
diff --git a/package/gstreamer1/gst1-plugins-good/Config.in b/package/gstreamer1/gst1-plugins-good/Config.in index 433084fd6b..ce85388eb0 100644 --- a/package/gstreamer1/gst1-plugins-good/Config.in +++ b/package/gstreamer1/gst1-plugins-good/Config.in @@ -300,6 +300,12 @@ comment "qmlgl (qt5) plugin needs an OpenGL-capable Qt5 backend" depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE depends on !BR2_PACKAGE_QT5_GL_AVAILABLE && !BR2_PACKAGE_QT5_VERSION_LATEST +config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2 + bool "shout2" + select BR2_PACKAGE_LIBSHOUT + help + Elements to send data to an icecast server using libshout2 + config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2 bool "v4l2" depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # multi planar api diff --git a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk index 829d27a2da..0a6cc77208 100644 --- a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +++ b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk @@ -25,8 +25,7 @@ GST1_PLUGINS_GOOD_CONF_OPTS = \ # Options which require currently unpackaged libraries GST1_PLUGINS_GOOD_CONF_OPTS += \ --disable-libdv \ - --disable-dv1394 \ - --disable-shout2 + --disable-dv1394 GST1_PLUGINS_GOOD_DEPENDENCIES = gstreamer1 gst1-plugins-base @@ -343,6 +342,12 @@ else GST1_PLUGINS_GOOD_CONF_OPTS += --disable-qt endif +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2),y) +GST1_PLUGINS_GOOD_CONF_OPTS += --enable-shout2 +else +GST1_PLUGINS_GOOD_CONF_OPTS += --disable-shout2 +endif + ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2),y) GST1_PLUGINS_GOOD_CONF_OPTS += --enable-gst_v4l2 else
Currently there is no way to turn the shout2 plugin on. Create a menu entry allowing users to disable or enable the plugin, like we have for other features (for example the Pulseaudio plugin). Signed-off-by: Arnold Bloemert <abloemert@gmail.com> --- package/gstreamer1/gst1-plugins-good/Config.in | 6 ++++++ .../gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 9 +++++++-- 2 files changed, 13 insertions(+), 2 deletions(-)