diff mbox series

[v2,01/12] toolchain: specify GCC_BUG_85180 is true only if GCC version < 8.x

Message ID 20190521133932.81841-2-giulio.benetti@micronovasrl.com
State Accepted
Headers show
Series Fix GCC BUG 85180 per-package | expand

Commit Message

Giulio Benetti May 21, 2019, 1:39 p.m. UTC 
Bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
has been fixed on Gcc version >= 8.x

So:
- add 'depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8' to 'config
  BR2_TOOLCHAIN_HAS_GCC_BUG_85180'.

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
---
 toolchain/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni May 22, 2019, 8:52 p.m. UTC | #1 
On Tue, 21 May 2019 15:39:21 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> Bug 85180:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
> has been fixed on Gcc version >= 8.x
> 
> So:
> - add 'depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8' to 'config
>   BR2_TOOLCHAIN_HAS_GCC_BUG_85180'.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
> ---
>  toolchain/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Applied to master with a tweaked commit log/title. Thanks!

Thomas
Giulio Benetti May 22, 2019, 9:23 p.m. UTC | #2 
Hello,

Il 22/05/2019 22:52, Thomas Petazzoni ha scritto:
> On Tue, 21 May 2019 15:39:21 +0200
> Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
> 
>> Bug 85180:
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
>> has been fixed on Gcc version >= 8.x
>>
>> So:
>> - add 'depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8' to 'config
>>    BR2_TOOLCHAIN_HAS_GCC_BUG_85180'.
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
>> Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
>> ---
>>   toolchain/Config.in | 1 +
>>   1 file changed, 1 insertion(+)
> 
> Applied to master with a tweaked commit log/title. Thanks!

Thank you for rewording. Need to improve commit logs in general...

Kind regards
Peter Korsgaard June 6, 2019, 12:46 p.m. UTC | #3 
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@micronovasrl.com> writes:

 > Bug 85180:
 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
 > has been fixed on Gcc version >= 8.x

 > So:
 > - add 'depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8' to 'config
 >   BR2_TOOLCHAIN_HAS_GCC_BUG_85180'.

 > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
 > Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Committed to 2019.02.x, thanks.
diff mbox series

Patch

diff --git a/toolchain/Config.in b/toolchain/Config.in
index 467d6bd84f..d05ad88af4 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -129,6 +129,7 @@  config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
 config BR2_TOOLCHAIN_HAS_GCC_BUG_85180
 	bool
 	default y if BR2_microblaze
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8
 
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85862
 # An infinite loop exists in the find_base_term() logic of 6.x