| Message ID | 20190514202547.18076-1-vadim4j@gmail.com |
|---|---|
| State | Accepted |
| Commit | d0126c5d4b169d636bb4aa7f9fd6de118c9537b5 |
| Headers | show |
| Series | [1/1] package/lynx: fix build with libidn | expand |
>>>>> "Vadim" == Vadim Kochan <vadim4j@gmail.com> writes: > In case of BR2_STATIC_LIBS=y the linking with libidn fails because > linker can't resolve libiconv symbols needed by libidn. Fix it by > required LIBS for libidn generated by pkg-conf. > The issue can be reproduced with the following defconfig: > BR2_x86_i686=y > BR2_STATIC_LIBS=y > BR2_PACKAGE_LIBICONV=y > BR2_PACKAGE_LIBIDN=y > BR2_PACKAGE_LYNX=y > Fixes: > http://autobuild.buildroot.net/results/23a421e15c32b17ff2f69f183a2e8620ecb93316/ > Signed-off-by: Vadim Kochan <vadim4j@gmail.com> Committed, thanks.
>>>>> "Vadim" == Vadim Kochan <vadim4j@gmail.com> writes: > In case of BR2_STATIC_LIBS=y the linking with libidn fails because > linker can't resolve libiconv symbols needed by libidn. Fix it by > required LIBS for libidn generated by pkg-conf. > The issue can be reproduced with the following defconfig: > BR2_x86_i686=y > BR2_STATIC_LIBS=y > BR2_PACKAGE_LIBICONV=y > BR2_PACKAGE_LIBIDN=y > BR2_PACKAGE_LYNX=y > Fixes: > http://autobuild.buildroot.net/results/23a421e15c32b17ff2f69f183a2e8620ecb93316/ > Signed-off-by: Vadim Kochan <vadim4j@gmail.com> Committed to 2019.02.x, thanks.
diff --git a/package/lynx/lynx.mk b/package/lynx/lynx.mk index 3ac5b4cabf..b6cc1b2b91 100644 --- a/package/lynx/lynx.mk +++ b/package/lynx/lynx.mk @@ -23,7 +23,7 @@ endif ifeq ($(BR2_PACKAGE_OPENSSL),y) LYNX_DEPENDENCIES += host-pkgconf openssl LYNX_CONF_OPTS += --with-ssl=$(STAGING_DIR)/usr -LYNX_CONF_ENV = LIBS=`$(PKG_CONFIG_HOST_BINARY) --libs openssl` +LYNX_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs openssl` else ifeq ($(BR2_PACKAGE_GNUTLS),y) LYNX_DEPENDENCIES += gnutls LYNX_CONF_OPTS += --with-gnutls @@ -36,4 +36,11 @@ else LYNX_CONF_OPTS += --without-zlib endif +ifeq ($(BR2_PACKAGE_LIBIDN),y) +LYNX_DEPENDENCIES += libidn +LYNX_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libidn` +endif + +LYNX_CONF_ENV = LIBS="$(LYNX_LIBS)" + $(eval $(autotools-package))
In case of BR2_STATIC_LIBS=y the linking with libidn fails because linker can't resolve libiconv symbols needed by libidn. Fix it by required LIBS for libidn generated by pkg-conf. The issue can be reproduced with the following defconfig: BR2_x86_i686=y BR2_STATIC_LIBS=y BR2_PACKAGE_LIBICONV=y BR2_PACKAGE_LIBIDN=y BR2_PACKAGE_LYNX=y Fixes: http://autobuild.buildroot.net/results/23a421e15c32b17ff2f69f183a2e8620ecb93316/ Signed-off-by: Vadim Kochan <vadim4j@gmail.com> --- package/lynx/lynx.mk | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)