| Message ID | 20181226223112.24456-2-nerv@dawncrow.de |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/9] board/freescale/imx8mqevk: Fix typos in readme | expand |
Hello, On Wed, 26 Dec 2018 23:31:05 +0100, André Hentschel wrote: > Signed-off-by: André Hentschel <nerv@dawncrow.de> > --- > package/freescale-imx/firmware-imx/firmware-imx.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/freescale-imx/firmware-imx/firmware-imx.mk b/package/freescale-imx/firmware-imx/firmware-imx.mk > index 0a503d7a66..240985297c 100644 > --- a/package/freescale-imx/firmware-imx/firmware-imx.mk > +++ b/package/freescale-imx/firmware-imx/firmware-imx.mk > @@ -35,7 +35,7 @@ endef > > define FIRMWARE_IMX_INSTALL_IMAGES_CMDS > # Create padded versions of lpddr4_pmu_* and generate lpddr4_pmu_train_fw.bin. > - # lpddr4_pmu_train_fw.bin isneeded when generating imx-boot-imx8mqevk-sd.bin > + # lpddr4_pmu_train_fw.bin is needed when generating imx-boot-sd.bin Ditto, isn't this imx8-boot-sd.bin ? Best regards, Thomas
Am 27.12.18 um 10:02 schrieb Thomas Petazzoni: > Hello, > > On Wed, 26 Dec 2018 23:31:05 +0100, André Hentschel wrote: >> Signed-off-by: André Hentschel <nerv@dawncrow.de> >> --- >> package/freescale-imx/firmware-imx/firmware-imx.mk | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/package/freescale-imx/firmware-imx/firmware-imx.mk b/package/freescale-imx/firmware-imx/firmware-imx.mk >> index 0a503d7a66..240985297c 100644 >> --- a/package/freescale-imx/firmware-imx/firmware-imx.mk >> +++ b/package/freescale-imx/firmware-imx/firmware-imx.mk >> @@ -35,7 +35,7 @@ endef >> >> define FIRMWARE_IMX_INSTALL_IMAGES_CMDS >> # Create padded versions of lpddr4_pmu_* and generate lpddr4_pmu_train_fw.bin. >> - # lpddr4_pmu_train_fw.bin isneeded when generating imx-boot-imx8mqevk-sd.bin >> + # lpddr4_pmu_train_fw.bin is needed when generating imx-boot-sd.bin > > Ditto, isn't this imx8-boot-sd.bin ? > > Best regards, > > Thomas > Hi, Thanks for having a look! You are right, I better should not introduce new typos...
diff --git a/package/freescale-imx/firmware-imx/firmware-imx.mk b/package/freescale-imx/firmware-imx/firmware-imx.mk index 0a503d7a66..240985297c 100644 --- a/package/freescale-imx/firmware-imx/firmware-imx.mk +++ b/package/freescale-imx/firmware-imx/firmware-imx.mk @@ -35,7 +35,7 @@ endef define FIRMWARE_IMX_INSTALL_IMAGES_CMDS # Create padded versions of lpddr4_pmu_* and generate lpddr4_pmu_train_fw.bin. - # lpddr4_pmu_train_fw.bin isneeded when generating imx-boot-imx8mqevk-sd.bin + # lpddr4_pmu_train_fw.bin is needed when generating imx-boot-sd.bin # which is done in post-image script. $(call FIRMWARE_IMX_PREPARE_LPDDR4_FW,1d) $(call FIRMWARE_IMX_PREPARE_LPDDR4_FW,2d)
Signed-off-by: André Hentschel <nerv@dawncrow.de> --- package/freescale-imx/firmware-imx/firmware-imx.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)