Message ID | 20181116112618.17034-1-abrodkin@synopsys.com |
---|---|
State | Accepted |
Headers | show |
Series | [v2] gcc: Enable __cxa_atexit for final GCC | expand |
Hello, On Fri, 16 Nov 2018 14:26:18 +0300, Alexey Brodkin wrote: > This is what GCC manual says [1]: > -------------------------->8---------------------- > --enable-__cxa_atexit I've applied to next, but after dropping the "for final GCC" from the commit title, since cxa_atexit is now used for both the initial gcc and the final gcc. Thanks! Thomas
Hi Peter, On Thu, Nov 29, 2018 at 7:15 PM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > Hello, > > On Fri, 16 Nov 2018 14:26:18 +0300, Alexey Brodkin wrote: > > This is what GCC manual says [1]: > > -------------------------->8---------------------- > > --enable-__cxa_atexit > > I've applied to next, but after dropping the "for final GCC" from the > commit title, since cxa_atexit is now used for both the initial gcc and > the final gcc. Could this one be applied to Buildroot stable? The lack of this patch causes is causing issues on Mesa: https://www.mail-archive.com/mesa-dev@lists.freedesktop.org/msg212440.html
Hello *, On Mon, 21 Jan 2019 13:04:46 -0200, Fabio Estevam <festevam@gmail.com> wrote: > Hi Peter, > > On Thu, Nov 29, 2018 at 7:15 PM Thomas Petazzoni > <thomas.petazzoni@bootlin.com> wrote: > > > > Hello, > > > > On Fri, 16 Nov 2018 14:26:18 +0300, Alexey Brodkin wrote: > > > This is what GCC manual says [1]: > > > -------------------------->8---------------------- > > > --enable-__cxa_atexit > > > > I've applied to next, but after dropping the "for final GCC" from the > > commit title, since cxa_atexit is now used for both the initial gcc and > > the final gcc. > > Could this one be applied to Buildroot stable? +1 > > The lack of this patch causes is causing issues on Mesa: > https://www.mail-archive.com/mesa-dev@lists.freedesktop.org/msg212440.html Did re-run the same buildroot-2018.11/mesa/etnaviv test, could confirm enabling __cxa_atexit fixes the mesa double-free on exit... Regards, Peter > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
>>>>> "Fabio" == Fabio Estevam <festevam@gmail.com> writes: > Hi Peter, > On Thu, Nov 29, 2018 at 7:15 PM Thomas Petazzoni > <thomas.petazzoni@bootlin.com> wrote: >> >> Hello, >> >> On Fri, 16 Nov 2018 14:26:18 +0300, Alexey Brodkin wrote: >> > This is what GCC manual says [1]: >> > -------------------------->8---------------------- >> > --enable-__cxa_atexit >> >> I've applied to next, but after dropping the "for final GCC" from the >> commit title, since cxa_atexit is now used for both the initial gcc and >> the final gcc. > Could this one be applied to Buildroot stable? > The lack of this patch causes is causing issues on Mesa: > https://www.mail-archive.com/mesa-dev@lists.freedesktop.org/msg212440.html Yes, sorry for the delay - Committed to 2018.02.x and 2018.11.x, thanks.
diff --git a/package/gcc/gcc.mk b/package/gcc/gcc.mk index e47435677e..5901624ea5 100644 --- a/package/gcc/gcc.mk +++ b/package/gcc/gcc.mk @@ -87,7 +87,7 @@ HOST_GCC_COMMON_DEPENDENCIES = \ HOST_GCC_COMMON_CONF_OPTS = \ --target=$(GNU_TARGET_NAME) \ --with-sysroot=$(STAGING_DIR) \ - --disable-__cxa_atexit \ + --enable-__cxa_atexit \ --with-gnu-ld \ --disable-libssp \ --disable-multilib \