| Message ID | 20181011123641.10103-1-grzegorz@blach.pl |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] pigpio: depends on BR2_TOOLCHAIN_HAS_THREADS | expand |
Hello, On Thu, 11 Oct 2018 14:36:41 +0200, Grzegorz Blach wrote: > piogpio needs pthreads > > Signed-off-by: Grzegorz Blach <grzegorz@blach.pl> > --- > package/pigpio/Config.in | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Thanks for your patch. When a patch fixes a build issue detected by the autobuilders, we always add a reference to the autobuilder failure in the commit log, like this: """ Fixes: http://autobuild.buildroot.net/results/2f64c993db402decf92a5f8010033acdbc6b884f/ """ I've fixed the commit log with this additional information before applying, but I wanted to let you know for your future contributions! Thanks, Thomas
On 10/11/18 4:43 PM, Thomas Petazzoni wrote: > Hello, > > On Thu, 11 Oct 2018 14:36:41 +0200, Grzegorz Blach wrote: >> piogpio needs pthreads >> >> Signed-off-by: Grzegorz Blach <grzegorz@blach.pl> >> --- >> package/pigpio/Config.in | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) > > Thanks for your patch. When a patch fixes a build issue detected by the > autobuilders, we always add a reference to the autobuilder failure in > the commit log, like this: > > """ > Fixes: > > http://autobuild.buildroot.net/results/2f64c993db402decf92a5f8010033acdbc6b884f/ > """ > > I've fixed the commit log with this additional information before > applying, but I wanted to let you know for your future contributions! > Ok, I'll remember that. > Thanks, > > Thomas >
diff --git a/package/pigpio/Config.in b/package/pigpio/Config.in index fee496b2ef..2180ab0de6 100644 --- a/package/pigpio/Config.in +++ b/package/pigpio/Config.in @@ -1,6 +1,7 @@ config BR2_PACKAGE_PIGPIO bool "pigpio" depends on BR2_aarch64 || BR2_arm + depends on BR2_TOOLCHAIN_HAS_THREADS depends on !BR2_STATIC_LIBS help Pigpio is a library for the Raspberry Pi which allows @@ -8,6 +9,6 @@ config BR2_PACKAGE_PIGPIO http://abyz.me.uk/rpi/pigpio/ -comment "pigpio needs a toolchain w/ dynamic library" +comment "pigpio needs a toolchain w/ threads, dynamic library" depends on BR2_aarch64 || BR2_arm - depends on !BR2_STATIC_LIBS + depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
piogpio needs pthreads Signed-off-by: Grzegorz Blach <grzegorz@blach.pl> --- package/pigpio/Config.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)