| Message ID | 20180706212709.10376-1-jean-francois.tetu@savoirfairelinux.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/automake: bump version to 1.16.1 | expand |
On 06-07-18 23:27, Jean-François Têtu wrote: > If Buildroot is run from a folder containing a '@' in the path, automake > will fail since the aclocal Perl script will interpret what is after the > '@' as an array in its system include paths. This was fixed in automake > 1.16.1. > > Signed-off-by: Jean-François Têtu <jean-francois.tetu@savoirfairelinux.com> Applied to master, thanks. automake is a package that runs a risk of breaking other packages using it. Would you be willing to monitor the autobuild results in the coming weeks to find and fix breakage caused by this bump? Thanks! Regards, Arnout > --- > package/automake/automake.hash | 2 +- > package/automake/automake.mk | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/automake/automake.hash b/package/automake/automake.hash > index b194c3c2bc..9ff55a4bae 100644 > --- a/package/automake/automake.hash > +++ b/package/automake/automake.hash > @@ -1,4 +1,4 @@ > # Locally calculated > -sha256 af6ba39142220687c500f79b4aa2f181d9b24e4f8d8ec497cea4ba26c64bedaf automake-1.15.1.tar.xz > +sha256 5d05bb38a23fd3312b10aea93840feec685bdf4a41146e78882848165d3ae921 automake-1.16.1.tar.xz > # License files, locally calculated > sha256 ab15fd526bd8dd18a9e77ebc139656bf4d33e97fc7238cd11bf60e2b9b8666c6 COPYING > diff --git a/package/automake/automake.mk b/package/automake/automake.mk > index 270337712e..92e7d64666 100644 > --- a/package/automake/automake.mk > +++ b/package/automake/automake.mk > @@ -4,7 +4,7 @@ > # > ################################################################################ > > -AUTOMAKE_VERSION = 1.15.1 > +AUTOMAKE_VERSION = 1.16.1 > AUTOMAKE_SOURCE = automake-$(AUTOMAKE_VERSION).tar.xz > AUTOMAKE_SITE = $(BR2_GNU_MIRROR)/automake > AUTOMAKE_LICENSE = GPL-2.0+ >
Hello! On Saturday, July 7, 2018 5:31:11 PM, Arnout Vandecappelle wrote: > On 06-07-18 23:27, Jean-François Têtu wrote: >> If Buildroot is run from a folder containing a '@' in the path, automake >> will fail since the aclocal Perl script will interpret what is after the >> '@' as an array in its system include paths. This was fixed in automake >> 1.16.1. >> >> Signed-off-by: Jean-François Têtu <jean-francois.tetu@savoirfairelinux.com> > > Applied to master, thanks. > Great! > automake is a package that runs a risk of breaking other packages using it. > Would you be willing to monitor the autobuild results in the coming weeks to > find and fix breakage caused by this bump? > > Thanks! > Gladly, I'll monitor the daily autobuild results and fix whatever breaks. > Regards, > Arnout > >> --- >> package/automake/automake.hash | 2 +- >> package/automake/automake.mk | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/package/automake/automake.hash b/package/automake/automake.hash >> index b194c3c2bc..9ff55a4bae 100644 >> --- a/package/automake/automake.hash >> +++ b/package/automake/automake.hash >> @@ -1,4 +1,4 @@ >> # Locally calculated >> -sha256 af6ba39142220687c500f79b4aa2f181d9b24e4f8d8ec497cea4ba26c64bedaf >> automake-1.15.1.tar.xz >> +sha256 5d05bb38a23fd3312b10aea93840feec685bdf4a41146e78882848165d3ae921 >> automake-1.16.1.tar.xz >> # License files, locally calculated >> sha256 ab15fd526bd8dd18a9e77ebc139656bf4d33e97fc7238cd11bf60e2b9b8666c6 COPYING >> diff --git a/package/automake/automake.mk b/package/automake/automake.mk >> index 270337712e..92e7d64666 100644 >> --- a/package/automake/automake.mk >> +++ b/package/automake/automake.mk >> @@ -4,7 +4,7 @@ >> # >> ################################################################################ >> >> -AUTOMAKE_VERSION = 1.15.1 >> +AUTOMAKE_VERSION = 1.16.1 >> AUTOMAKE_SOURCE = automake-$(AUTOMAKE_VERSION).tar.xz >> AUTOMAKE_SITE = $(BR2_GNU_MIRROR)/automake >> AUTOMAKE_LICENSE = GPL-2.0+ >> > > -- > Arnout Vandecappelle arnout at mind be > Senior Embedded Software Architect +32-16-286500 > Essensium/Mind http://www.mind.be > G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven > LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle > GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot Thanks! -- Jean-François Têtu
Jean-François, All, On 2018-07-07 22:44 -0400, Jean-François Têtu spake thusly: > On Saturday, July 7, 2018 5:31:11 PM, Arnout Vandecappelle wrote: > > automake is a package that runs a risk of breaking other packages using it. > > Would you be willing to monitor the autobuild results in the coming weeks to > > find and fix breakage caused by this bump? > > Gladly, I'll monitor the daily autobuild results and fix whatever breaks. It looks liek we have our first automake-bump related issues piling up: http://autobuild.buildroot.org/results/221/2215acb7e011b9fd469217abbc319941f8f6ee61/build-end.log http://autobuild.buildroot.org/results/13d/13d600c8b33017793cd0dbdd5d204ba0b01924a5/build-end.log Care to have a look? Regards, Yann E. MORIN.
On 08-07-18 12:56, Yann E. MORIN wrote: > Jean-François, All, > > On 2018-07-07 22:44 -0400, Jean-François Têtu spake thusly: >> On Saturday, July 7, 2018 5:31:11 PM, Arnout Vandecappelle wrote: >>> automake is a package that runs a risk of breaking other packages using it. >>> Would you be willing to monitor the autobuild results in the coming weeks to >>> find and fix breakage caused by this bump? >> >> Gladly, I'll monitor the daily autobuild results and fix whatever breaks. > > It looks liek we have our first automake-bump related issues piling up: > > http://autobuild.buildroot.org/results/221/2215acb7e011b9fd469217abbc319941f8f6ee61/build-end.log Looks like the AUTORECONF = YES doesn't propagate into the libltdl directory. Makes me think though: can't we use the libltdl from the libtool package? > http://autobuild.buildroot.org/results/13d/13d600c8b33017793cd0dbdd5d204ba0b01924a5/build-end.log This one looks like a problem with the timestamps, triggering an autoreconfigure though none is needed. Regards, Arnout > > Care to have a look? > > Regards, > Yann E. MORIN. >
Hello, On Fri, 6 Jul 2018 17:27:09 -0400, Jean-François Têtu wrote: > If Buildroot is run from a folder containing a '@' in the path, automake > will fail since the aclocal Perl script will interpret what is after the > '@' as an array in its system include paths. This was fixed in automake > 1.16.1. > > Signed-off-by: Jean-François Têtu <jean-francois.tetu@savoirfairelinux.com> > --- > package/automake/automake.hash | 2 +- > package/automake/automake.mk | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Since this commit was causing breakage at least in squid, for which the fix was not yet accepted, I've for now reverted the automake bump. Could you resend a patch series that includes the automake bump as well as the fixes for the different packages causing build breakage (i.e at least squid) ? Thanks! Thomas
diff --git a/package/automake/automake.hash b/package/automake/automake.hash index b194c3c2bc..9ff55a4bae 100644 --- a/package/automake/automake.hash +++ b/package/automake/automake.hash @@ -1,4 +1,4 @@ # Locally calculated -sha256 af6ba39142220687c500f79b4aa2f181d9b24e4f8d8ec497cea4ba26c64bedaf automake-1.15.1.tar.xz +sha256 5d05bb38a23fd3312b10aea93840feec685bdf4a41146e78882848165d3ae921 automake-1.16.1.tar.xz # License files, locally calculated sha256 ab15fd526bd8dd18a9e77ebc139656bf4d33e97fc7238cd11bf60e2b9b8666c6 COPYING diff --git a/package/automake/automake.mk b/package/automake/automake.mk index 270337712e..92e7d64666 100644 --- a/package/automake/automake.mk +++ b/package/automake/automake.mk @@ -4,7 +4,7 @@ # ################################################################################ -AUTOMAKE_VERSION = 1.15.1 +AUTOMAKE_VERSION = 1.16.1 AUTOMAKE_SOURCE = automake-$(AUTOMAKE_VERSION).tar.xz AUTOMAKE_SITE = $(BR2_GNU_MIRROR)/automake AUTOMAKE_LICENSE = GPL-2.0+
If Buildroot is run from a folder containing a '@' in the path, automake will fail since the aclocal Perl script will interpret what is after the '@' as an array in its system include paths. This was fixed in automake 1.16.1. Signed-off-by: Jean-François Têtu <jean-francois.tetu@savoirfairelinux.com> --- package/automake/automake.hash | 2 +- package/automake/automake.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)