diff mbox series

qt5base: remove unused definition

Message ID 20180630125713.4302-1-gael.portay@savoirfairelinux.com
State Accepted
Headers show
Series qt5base: remove unused definition | expand

Commit Message

Gaël PORTAY June 30, 2018, 12:57 p.m. UTC
Since commit 81fb33af2a (qt5base: correct eglfs support in
qmake.conf.in) the definition QT5BASE_CONFIGURE_QMAKE_CONFIG is left
unused.

Remove it since it is not used anymore.

Signed-off-by: Gaël PORTAY <gael.portay@savoirfairelinux.com>
---
 package/qt5/qt5base/qt5base.mk | 1 -
 1 file changed, 1 deletion(-)

Comments

Yann E. MORIN June 30, 2018, 4:02 p.m. UTC | #1
Gaël, All,

On 2018-06-30 08:57 -0400, Gaël PORTAY spake thusly:
> Since commit 81fb33af2a (qt5base: correct eglfs support in
> qmake.conf.in) the definition QT5BASE_CONFIGURE_QMAKE_CONFIG is left
> unused.
> 
> Remove it since it is not used anymore.
> 
> Signed-off-by: Gaël PORTAY <gael.portay@savoirfairelinux.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/qt5/qt5base/qt5base.mk | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index d5b25abcb8..9eafd593f1 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -269,7 +269,6 @@ define QT5BASE_CONFIGURE_CMDS
>  	sed 's/@EGLFS_DEVICE@/$(QT5BASE_EGLFS_DEVICE)/g' \
>  		$(QT5BASE_PKGDIR)/qmake.conf.in > \
>  		$(@D)/mkspecs/devices/linux-buildroot-g++/qmake.conf
> -	$(QT5BASE_CONFIGURE_QMAKE_CONFIG)
>  	$(INSTALL) -m 0644 -D $(QT5BASE_PKGDIR)/qplatformdefs.h \
>  		$(@D)/mkspecs/devices/linux-buildroot-g++/qplatformdefs.h
>  	$(QT5BASE_CONFIGURE_CONFIG_FILE)
> -- 
> 2.17.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni June 30, 2018, 4:10 p.m. UTC | #2
Hello,

On Sat, 30 Jun 2018 08:57:13 -0400, Gaël PORTAY wrote:
> Since commit 81fb33af2a (qt5base: correct eglfs support in
> qmake.conf.in) the definition QT5BASE_CONFIGURE_QMAKE_CONFIG is left
> unused.
> 
> Remove it since it is not used anymore.
> 
> Signed-off-by: Gaël PORTAY <gael.portay@savoirfairelinux.com>
> ---
>  package/qt5/qt5base/qt5base.mk | 1 -
>  1 file changed, 1 deletion(-)

Applied to master, thanks.

Thomas
Peter Korsgaard July 19, 2018, 9:56 a.m. UTC | #3
>>>>> "Gaël" == Gaël PORTAY <gael.portay@savoirfairelinux.com> writes:

 > Since commit 81fb33af2a (qt5base: correct eglfs support in
 > qmake.conf.in) the definition QT5BASE_CONFIGURE_QMAKE_CONFIG is left
 > unused.

 > Remove it since it is not used anymore.

 > Signed-off-by: Gaël PORTAY <gael.portay@savoirfairelinux.com>

Committed to 2018.02.x and 2018.05.x, thanks.
diff mbox series

Patch

diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
index d5b25abcb8..9eafd593f1 100644
--- a/package/qt5/qt5base/qt5base.mk
+++ b/package/qt5/qt5base/qt5base.mk
@@ -269,7 +269,6 @@  define QT5BASE_CONFIGURE_CMDS
 	sed 's/@EGLFS_DEVICE@/$(QT5BASE_EGLFS_DEVICE)/g' \
 		$(QT5BASE_PKGDIR)/qmake.conf.in > \
 		$(@D)/mkspecs/devices/linux-buildroot-g++/qmake.conf
-	$(QT5BASE_CONFIGURE_QMAKE_CONFIG)
 	$(INSTALL) -m 0644 -D $(QT5BASE_PKGDIR)/qplatformdefs.h \
 		$(@D)/mkspecs/devices/linux-buildroot-g++/qplatformdefs.h
 	$(QT5BASE_CONFIGURE_CONFIG_FILE)