| Message ID | 20180622003340.10859-2-joseph.kogut@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | chromium: new package | expand |
Hello, On Thu, 21 Jun 2018 17:33:35 -0700, Joseph Kogut wrote: > Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com> I've applied your patch, after doing a few additional fixes. See below. > diff --git a/package/at-spi2-core/Config.in b/package/at-spi2-core/Config.in > new file mode 100644 > index 0000000000..43110e0bf4 > --- /dev/null > +++ b/package/at-spi2-core/Config.in > @@ -0,0 +1,24 @@ > +config BR2_PACKAGE_AT_SPI2_CORE > + bool "at-spi2-core" > + depends on BR2_PACKAGE_XORG7 # xlib-libxtst > + depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, glib2 > + depends on BR2_USE_MMU # glib2 > + depends on BR2_USE_WCHAR # glib2 > + select BR2_PACKAGE_DBUS > + select BR2_PACKAGE_LIBGLIB2 > + select BR2_PACKAGE_XLIB_LIBXTST > + help > + The At-Spi2 Core package is a part of the GNOME > + Accessibility Project. It provides a Service Provider > + Interface for the Assistive Technologies available on the > + GNOME platform and a library against which applications > + can be linked. > + > + https://wiki.gnome.org/Accessibility > + > +comment "at-spi2-core needs a toolchain w/ wchar, threads" > + depends on BR2_USE_MMU > + depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS > + > +comment "at-spi2-core depends on X.org" I've added: depends on BR2_USE_MMU here, so that the comment doesn't show up on noMMU architectures where at-spi2-core will anyway not be available regardless of X.org availability. > + depends on !BR2_PACKAGE_XORG7 > +AT_SPI2_CORE_VERSION_MAJOR = 2.28 > +AT_SPI2_CORE_VERSION = $(AT_SPI2_CORE_VERSION_MAJOR).0 > +AT_SPI2_CORE_SOURCE = at-spi2-core-$(AT_SPI2_CORE_VERSION).tar.xz > +AT_SPI2_CORE_SITE = http://ftp.gnome.org/pub/gnome/sources/at-spi2-core/$(AT_SPI2_CORE_VERSION_MAJOR) > +AT_SPI2_CORE_LICENSE = LGPL-2.0+ > +AT_SPI2_CORE_LICENSE_FILES = COPYING > +AT_SPI2_CORE_INSTALL_STAGING = YES > +AT_SPI2_CORE_DEPENDENCIES = host-meson host-pkgconf dbus libglib2 xlib_libXtst Having host-meson in the DEPENDENCIES variable is useless, because the meson-package infrastructure takes care of that. Also, I had to specify -Ddbus_daemon=/usr/bin/dbus-daemon, otherwise it tries to search for the dbus-daemon program on the host machine, and errors out if it cannot find it. Applied with those changes. Thanks! Thomas
Hi Thomas, On Mon, Jun 25, 2018 at 2:09 PM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > Hello, > > On Thu, 21 Jun 2018 17:33:35 -0700, Joseph Kogut wrote: > > Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com> > > I've applied your patch, after doing a few additional fixes. See below. > > > diff --git a/package/at-spi2-core/Config.in b/package/at-spi2-core/Config.in > > new file mode 100644 > > index 0000000000..43110e0bf4 > > --- /dev/null > > +++ b/package/at-spi2-core/Config.in > > @@ -0,0 +1,24 @@ > > +config BR2_PACKAGE_AT_SPI2_CORE > > + bool "at-spi2-core" > > + depends on BR2_PACKAGE_XORG7 # xlib-libxtst > > + depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, glib2 > > + depends on BR2_USE_MMU # glib2 > > + depends on BR2_USE_WCHAR # glib2 > > + select BR2_PACKAGE_DBUS > > + select BR2_PACKAGE_LIBGLIB2 > > + select BR2_PACKAGE_XLIB_LIBXTST > > + help > > + The At-Spi2 Core package is a part of the GNOME > > + Accessibility Project. It provides a Service Provider > > + Interface for the Assistive Technologies available on the > > + GNOME platform and a library against which applications > > + can be linked. > > + > > + https://wiki.gnome.org/Accessibility > > + > > +comment "at-spi2-core needs a toolchain w/ wchar, threads" > > + depends on BR2_USE_MMU > > + depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS > > + > > +comment "at-spi2-core depends on X.org" > > I've added: > > depends on BR2_USE_MMU > > here, so that the comment doesn't show up on noMMU architectures where > at-spi2-core will anyway not be available regardless of X.org > availability. > > > + depends on !BR2_PACKAGE_XORG7 > I'll keep that in mind. > > +AT_SPI2_CORE_VERSION_MAJOR = 2.28 > > +AT_SPI2_CORE_VERSION = $(AT_SPI2_CORE_VERSION_MAJOR).0 > > +AT_SPI2_CORE_SOURCE = at-spi2-core-$(AT_SPI2_CORE_VERSION).tar.xz > > +AT_SPI2_CORE_SITE = http://ftp.gnome.org/pub/gnome/sources/at-spi2-core/$(AT_SPI2_CORE_VERSION_MAJOR) > > +AT_SPI2_CORE_LICENSE = LGPL-2.0+ > > +AT_SPI2_CORE_LICENSE_FILES = COPYING > > +AT_SPI2_CORE_INSTALL_STAGING = YES > > +AT_SPI2_CORE_DEPENDENCIES = host-meson host-pkgconf dbus libglib2 xlib_libXtst > > Having host-meson in the DEPENDENCIES variable is useless, because the > meson-package infrastructure takes care of that. > Good point, I missed that. > Also, I had to specify -Ddbus_daemon=/usr/bin/dbus-daemon, otherwise it > tries to search for the dbus-daemon program on the host machine, and > errors out if it cannot find it. > > Applied with those changes. Thanks! > Thanks for the fixes.
diff --git a/DEVELOPERS b/DEVELOPERS index d22ac527fa..b721b3592a 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -974,6 +974,7 @@ F: board/qemu/ppc64le-pseries/ F: configs/qemu_ppc64le_pseries_defconfig N: Joseph Kogut <joseph.kogut@gmail.com> +F: package/at-spi2-core/ F: package/gconf/ F: package/libnss/ F: package/python-cython/ diff --git a/package/Config.in b/package/Config.in index a5ecfecbf9..56e6b2f2bd 100644 --- a/package/Config.in +++ b/package/Config.in @@ -1130,6 +1130,7 @@ endmenu menu "Graphics" source "package/assimp/Config.in" + source "package/at-spi2-core/Config.in" source "package/atk/Config.in" source "package/atkmm/Config.in" source "package/bullet/Config.in" diff --git a/package/at-spi2-core/Config.in b/package/at-spi2-core/Config.in new file mode 100644 index 0000000000..43110e0bf4 --- /dev/null +++ b/package/at-spi2-core/Config.in @@ -0,0 +1,24 @@ +config BR2_PACKAGE_AT_SPI2_CORE + bool "at-spi2-core" + depends on BR2_PACKAGE_XORG7 # xlib-libxtst + depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, glib2 + depends on BR2_USE_MMU # glib2 + depends on BR2_USE_WCHAR # glib2 + select BR2_PACKAGE_DBUS + select BR2_PACKAGE_LIBGLIB2 + select BR2_PACKAGE_XLIB_LIBXTST + help + The At-Spi2 Core package is a part of the GNOME + Accessibility Project. It provides a Service Provider + Interface for the Assistive Technologies available on the + GNOME platform and a library against which applications + can be linked. + + https://wiki.gnome.org/Accessibility + +comment "at-spi2-core needs a toolchain w/ wchar, threads" + depends on BR2_USE_MMU + depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS + +comment "at-spi2-core depends on X.org" + depends on !BR2_PACKAGE_XORG7 diff --git a/package/at-spi2-core/at-spi2-core.hash b/package/at-spi2-core/at-spi2-core.hash new file mode 100644 index 0000000000..9c96da312b --- /dev/null +++ b/package/at-spi2-core/at-spi2-core.hash @@ -0,0 +1,3 @@ +# locally calculated +sha256 42a2487ab11ce43c288e73b2668ef8b1ab40a0e2b4f94e80fca04ad27b6f1c87 at-spi2-core-2.28.0.tar.xz +sha256 c6105b34ab6829ff5c70eba234f40053215fa9f8383ced271b0e370a1923624b COPYING diff --git a/package/at-spi2-core/at-spi2-core.mk b/package/at-spi2-core/at-spi2-core.mk new file mode 100644 index 0000000000..243c9192be --- /dev/null +++ b/package/at-spi2-core/at-spi2-core.mk @@ -0,0 +1,16 @@ +################################################################################ +# +# at-spi2-core +# +################################################################################ + +AT_SPI2_CORE_VERSION_MAJOR = 2.28 +AT_SPI2_CORE_VERSION = $(AT_SPI2_CORE_VERSION_MAJOR).0 +AT_SPI2_CORE_SOURCE = at-spi2-core-$(AT_SPI2_CORE_VERSION).tar.xz +AT_SPI2_CORE_SITE = http://ftp.gnome.org/pub/gnome/sources/at-spi2-core/$(AT_SPI2_CORE_VERSION_MAJOR) +AT_SPI2_CORE_LICENSE = LGPL-2.0+ +AT_SPI2_CORE_LICENSE_FILES = COPYING +AT_SPI2_CORE_INSTALL_STAGING = YES +AT_SPI2_CORE_DEPENDENCIES = host-meson host-pkgconf dbus libglib2 xlib_libXtst + +$(eval $(meson-package))
Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com> --- DEVELOPERS | 1 + package/Config.in | 1 + package/at-spi2-core/Config.in | 24 ++++++++++++++++++++++++ package/at-spi2-core/at-spi2-core.hash | 3 +++ package/at-spi2-core/at-spi2-core.mk | 16 ++++++++++++++++ 5 files changed, 45 insertions(+) create mode 100644 package/at-spi2-core/Config.in create mode 100644 package/at-spi2-core/at-spi2-core.hash create mode 100644 package/at-spi2-core/at-spi2-core.mk