diff mbox series

protobuf: bump to 3.6.0

Message ID 20180620142255.31441-1-matthew.weber@rockwellcollins.com
State Superseded
Headers show
Series protobuf: bump to 3.6.0 | expand

Commit Message

Matt Weber June 20, 2018, 2:22 p.m. UTC
Fixes the following issue and brauto builds
https://github.com/google/protobuf/issues/3937
http://autobuild.buildroot.net/results/982f727495c1d3524685015c34b1cbb1e0bbb4b0
http://autobuild.buildroot.net/results/adbd3088e24d7e681c995f8c3d1db0e14ac500ba

Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
---
 package/protobuf/protobuf.hash | 2 +-
 package/protobuf/protobuf.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Peter Korsgaard June 20, 2018, 9:24 p.m. UTC | #1
>>>>> "Matt" == Matt Weber <matthew.weber@rockwellcollins.com> writes:

 > Fixes the following issue and brauto builds
 > https://github.com/google/protobuf/issues/3937
 > http://autobuild.buildroot.net/results/982f727495c1d3524685015c34b1cbb1e0bbb4b0
 > http://autobuild.buildroot.net/results/adbd3088e24d7e681c995f8c3d1db0e14ac500ba

 > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
 > ---
 >  package/protobuf/protobuf.hash | 2 +-
 >  package/protobuf/protobuf.mk   | 2 +-
 >  2 files changed, 2 insertions(+), 2 deletions(-)

What about python-protobuf?

ERROR: No hash found for protobuf-python-3.6.0.tar.gz
package/pkg-generic.mk:135: recipe for target '/home/peko/source/buildroot/output-wireguard/build/python-protobuf-3.6.0/.stamp_downloaded' failed
Matt Weber June 20, 2018, 9:30 p.m. UTC | #2
Peter,

On Wed, Jun 20, 2018 at 4:24 PM, Peter Korsgaard <peter@korsgaard.com> wrote:
>>>>>> "Matt" == Matt Weber <matthew.weber@rockwellcollins.com> writes:
>
>  > Fixes the following issue and brauto builds
>  > https://github.com/google/protobuf/issues/3937
>  > http://autobuild.buildroot.net/results/982f727495c1d3524685015c34b1cbb1e0bbb4b0
>  > http://autobuild.buildroot.net/results/adbd3088e24d7e681c995f8c3d1db0e14ac500ba
>
>  > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
>  > ---
>  >  package/protobuf/protobuf.hash | 2 +-
>  >  package/protobuf/protobuf.mk   | 2 +-
>  >  2 files changed, 2 insertions(+), 2 deletions(-)
>
> What about python-protobuf?
>
> ERROR: No hash found for protobuf-python-3.6.0.tar.gz
> package/pkg-generic.mk:135: recipe for target '/home/peko/source/buildroot/output-wireguard/build/python-protobuf-3.6.0/.stamp_downloaded' failed

Good catch, forgot about that.  Retesting.

Matt
Matt Weber June 20, 2018, 9:42 p.m. UTC | #3
Peter,

On Wed, Jun 20, 2018 at 4:30 PM, Matthew Weber
<matthew.weber@rockwellcollins.com> wrote:
> Peter,
>
> On Wed, Jun 20, 2018 at 4:24 PM, Peter Korsgaard <peter@korsgaard.com> wrote:
>>>>>>> "Matt" == Matt Weber <matthew.weber@rockwellcollins.com> writes:
>>
>>  > Fixes the following issue and brauto builds
>>  > https://github.com/google/protobuf/issues/3937
>>  > http://autobuild.buildroot.net/results/982f727495c1d3524685015c34b1cbb1e0bbb4b0
>>  > http://autobuild.buildroot.net/results/adbd3088e24d7e681c995f8c3d1db0e14ac500ba
>>
>>  > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
>>  > ---
>>  >  package/protobuf/protobuf.hash | 2 +-
>>  >  package/protobuf/protobuf.mk   | 2 +-
>>  >  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> What about python-protobuf?
>>
>> ERROR: No hash found for protobuf-python-3.6.0.tar.gz
>> package/pkg-generic.mk:135: recipe for target '/home/peko/source/buildroot/output-wireguard/build/python-protobuf-3.6.0/.stamp_downloaded' failed
>

I sent a v2 and kicked off a complete test-pkg with the following config.
BR2_PACKAGE_PROTOBUF=y
BR2_PACKAGE_PYTHON=y
BR2_PACKAGE_PYTHON_PROTOBUF=y


http://patchwork.ozlabs.org/patch/932408/
Peter Korsgaard June 22, 2018, 6:07 p.m. UTC | #4
>>>>> "Matt" == Matt Weber <matthew.weber@rockwellcollins.com> writes:

 > Fixes the following issue and brauto builds
 > https://github.com/google/protobuf/issues/3937
 > http://autobuild.buildroot.net/results/982f727495c1d3524685015c34b1cbb1e0bbb4b0
 > http://autobuild.buildroot.net/results/adbd3088e24d7e681c995f8c3d1db0e14ac500ba

 > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>

For some reason I didn't receive v2 (but it is in the archives) -
Committed v2, thanks.
diff mbox series

Patch

diff --git a/package/protobuf/protobuf.hash b/package/protobuf/protobuf.hash
index 4492487efb..33f0e3076f 100644
--- a/package/protobuf/protobuf.hash
+++ b/package/protobuf/protobuf.hash
@@ -1,2 +1,2 @@ 
 # Locally calculated
-sha256 c28dba8782da2cfea1e11c61d335958c31a9c1bc553063546af9cbe98f204092 protobuf-cpp-3.5.1.tar.gz
+sha256 c3cab055964d554e4fd85067fe3e9eb45c9915cebcf537e97fafaa245376bce1  protobuf-cpp-3.6.0.tar.gz
diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk
index 1440589c14..9caf87ed93 100644
--- a/package/protobuf/protobuf.mk
+++ b/package/protobuf/protobuf.mk
@@ -7,7 +7,7 @@ 
 # When bumping this package, make sure to also verify if the
 # python-protobuf package still works, as they share the same
 # version/site variables.
-PROTOBUF_VERSION = 3.5.1
+PROTOBUF_VERSION = 3.6.0
 PROTOBUF_SOURCE = protobuf-cpp-$(PROTOBUF_VERSION).tar.gz
 PROTOBUF_SITE = https://github.com/google/protobuf/releases/download/v$(PROTOBUF_VERSION)
 PROTOBUF_LICENSE = BSD-3-Clause