| Message ID | 20180614224820.27126-4-joseph.kogut@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | chromium: new package | expand |
Hello Joseph, Pretty much the same comments as for the at-spi2-core package. See below. On Thu, 14 Jun 2018 15:48:14 -0700, Joseph Kogut wrote: > diff --git a/package/at-spi2-atk/Config.in b/package/at-spi2-atk/Config.in > new file mode 100644 > index 0000000000..b354c77ffe > --- /dev/null > +++ b/package/at-spi2-atk/Config.in > @@ -0,0 +1,5 @@ > +config BR2_PACKAGE_AT_SPI2_ATK > + bool "at-spi2-atk" > + select BR2_PACKAGE_AT_SPI2_CORE You also need to select BR2_PACKAGE_ATK and BR2_PACKAGE_LIBGLIB2 to be consistent with the dependencies variable in your .mk file. And of course, propagate the "depends on". > + help > + The At-Spi2 Atk package contains a library that bridges ATK to At-Spi2 D-Bus service. Line too long, missing upstream URL. Please run ./utils/check-package > diff --git a/package/at-spi2-atk/at-spi2-atk.hash b/package/at-spi2-atk/at-spi2-atk.hash > new file mode 100644 > index 0000000000..6f7d68ab87 > --- /dev/null > +++ b/package/at-spi2-atk/at-spi2-atk.hash > @@ -0,0 +1,4 @@ > +# locally calculated > +sha256 61891f0abae1689f6617a963105a3f1dcdab5970c4a36ded9c79a7a544b16a6e at-spi2-atk-2.26.2.tar.xz > +sha256 c6105b34ab6829ff5c70eba234f40053215fa9f8383ced271b0e370a1923624b COPYING > + Line not needed. > diff --git a/package/at-spi2-atk/at-spi2-atk.mk b/package/at-spi2-atk/at-spi2-atk.mk > new file mode 100644 > index 0000000000..a3bccbb0d9 > --- /dev/null > +++ b/package/at-spi2-atk/at-spi2-atk.mk > @@ -0,0 +1,17 @@ > +############################################################################### > +# > +# at-spi2-atk > +# > +############################################################################### > + > +AT_SPI2_ATK_VERSION_MAJOR = 2.26 > +AT_SPI2_ATK_VERSION = $(AT_SPI2_ATK_VERSION_MAJOR).2 > +AT_SPI2_ATK_SOURCE = at-spi2-atk-$(AT_SPI2_ATK_VERSION).tar.xz > +AT_SPI2_ATK_SITE = http://ftp.gnome.org/pub/gnome/sources/at-spi2-atk/$(AT_SPI2_ATK_VERSION_MAJOR) > +ATK_LICENSE = LGPL-2.0+ > +ATK_LICENSE_FILES = COPYING > +AT_SPI2_ATK_INSTALL_STAGING = YES > +AT_SPI2_ATK_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR) LDFLAGS=-L$(STAGING_DIR)/usr/lib install Those LDFLAGS should not be needed, they are the default. > +AT_SPI2_ATK_DEPENDENCIES = atk at-spi2-core libglib2 host-pkgconf > + > +$(eval $(autotools-package)) Thanks! Thomas Petazzoni
diff --git a/DEVELOPERS b/DEVELOPERS index 31c651b938..568f47d242 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -955,6 +955,7 @@ F: board/qemu/ppc64le-pseries/ F: configs/qemu_ppc64le_pseries_defconfig N: Joseph Kogut <joseph.kogut@gmail.com> +F: package/at-spi2-atk/ F: package/at-spi2-core/ F: package/gconf/ F: package/libnss/ diff --git a/package/Config.in b/package/Config.in index 692b422911..c2e619b317 100644 --- a/package/Config.in +++ b/package/Config.in @@ -1128,6 +1128,7 @@ endmenu menu "Graphics" source "package/assimp/Config.in" + source "package/at-spi2-atk/Config.in" source "package/at-spi2-core/Config.in" source "package/atk/Config.in" source "package/atkmm/Config.in" diff --git a/package/at-spi2-atk/Config.in b/package/at-spi2-atk/Config.in new file mode 100644 index 0000000000..b354c77ffe --- /dev/null +++ b/package/at-spi2-atk/Config.in @@ -0,0 +1,5 @@ +config BR2_PACKAGE_AT_SPI2_ATK + bool "at-spi2-atk" + select BR2_PACKAGE_AT_SPI2_CORE + help + The At-Spi2 Atk package contains a library that bridges ATK to At-Spi2 D-Bus service. diff --git a/package/at-spi2-atk/at-spi2-atk.hash b/package/at-spi2-atk/at-spi2-atk.hash new file mode 100644 index 0000000000..6f7d68ab87 --- /dev/null +++ b/package/at-spi2-atk/at-spi2-atk.hash @@ -0,0 +1,4 @@ +# locally calculated +sha256 61891f0abae1689f6617a963105a3f1dcdab5970c4a36ded9c79a7a544b16a6e at-spi2-atk-2.26.2.tar.xz +sha256 c6105b34ab6829ff5c70eba234f40053215fa9f8383ced271b0e370a1923624b COPYING + diff --git a/package/at-spi2-atk/at-spi2-atk.mk b/package/at-spi2-atk/at-spi2-atk.mk new file mode 100644 index 0000000000..a3bccbb0d9 --- /dev/null +++ b/package/at-spi2-atk/at-spi2-atk.mk @@ -0,0 +1,17 @@ +############################################################################### +# +# at-spi2-atk +# +############################################################################### + +AT_SPI2_ATK_VERSION_MAJOR = 2.26 +AT_SPI2_ATK_VERSION = $(AT_SPI2_ATK_VERSION_MAJOR).2 +AT_SPI2_ATK_SOURCE = at-spi2-atk-$(AT_SPI2_ATK_VERSION).tar.xz +AT_SPI2_ATK_SITE = http://ftp.gnome.org/pub/gnome/sources/at-spi2-atk/$(AT_SPI2_ATK_VERSION_MAJOR) +ATK_LICENSE = LGPL-2.0+ +ATK_LICENSE_FILES = COPYING +AT_SPI2_ATK_INSTALL_STAGING = YES +AT_SPI2_ATK_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR) LDFLAGS=-L$(STAGING_DIR)/usr/lib install +AT_SPI2_ATK_DEPENDENCIES = atk at-spi2-core libglib2 host-pkgconf + +$(eval $(autotools-package))
Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com> --- DEVELOPERS | 1 + package/Config.in | 1 + package/at-spi2-atk/Config.in | 5 +++++ package/at-spi2-atk/at-spi2-atk.hash | 4 ++++ package/at-spi2-atk/at-spi2-atk.mk | 17 +++++++++++++++++ 5 files changed, 28 insertions(+) create mode 100644 package/at-spi2-atk/Config.in create mode 100644 package/at-spi2-atk/at-spi2-atk.hash create mode 100644 package/at-spi2-atk/at-spi2-atk.mk