diff mbox series

[3/6] tpm2-abrmd: declare dependency on a toolchain with C++

Message ID 20180322202752.2562-4-casantos@datacom.ind.br
State Accepted
Commit 003269a6692d146ca9c8a94f965244cf11f58738
Headers show
Series tpm2-{tss, abrmd, tools} fix compilation errors | expand

Commit Message

Carlos Santos March 22, 2018, 8:27 p.m. UTC
It depends on tpm2-tss, whose current version contains C++ code.

Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
---
 package/tpm2-abrmd/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Peter Korsgaard March 22, 2018, 10:57 p.m. UTC | #1
>>>>> "Carlos" == Carlos Santos <casantos@datacom.ind.br> writes:

 > It depends on tpm2-tss, whose current version contains C++ code.
 > Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
 > ---
 >  package/tpm2-abrmd/Config.in | 5 +++--
 >  1 file changed, 3 insertions(+), 2 deletions(-)

 > diff --git a/package/tpm2-abrmd/Config.in b/package/tpm2-abrmd/Config.in
 > index 31c5ae7d6b..5c236d1d5c 100644
 > --- a/package/tpm2-abrmd/Config.in
 > +++ b/package/tpm2-abrmd/Config.in
 > @@ -20,6 +20,7 @@ config BR2_PACKAGE_TPM2_ABRMD
 
 >  	  https://github.com/tpm2-software/tpm2-abrmd
 
 > -comment "tpm2-abrmd needs a toolchain w/ wchar, threads"
 > +comment "tpm2-abrmd needs a toolchain w/ C++, wchar, threads"

You again forgot to add the dependency to the config symbol itself.

Committed with that fixed, thanks.
diff mbox series

Patch

diff --git a/package/tpm2-abrmd/Config.in b/package/tpm2-abrmd/Config.in
index 31c5ae7d6b..5c236d1d5c 100644
--- a/package/tpm2-abrmd/Config.in
+++ b/package/tpm2-abrmd/Config.in
@@ -20,6 +20,7 @@  config BR2_PACKAGE_TPM2_ABRMD
 
 	  https://github.com/tpm2-software/tpm2-abrmd
 
-comment "tpm2-abrmd needs a toolchain w/ wchar, threads"
+comment "tpm2-abrmd needs a toolchain w/ C++, wchar, threads"
 	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \
+		|| !BR2_TOOLCHAIN_HAS_THREADS