diff mbox

.gitlab-ci.yml: fix it again

Message ID 20170701182227.11778-1-arnout@mind.be
State Accepted
Headers show

Commit Message

Arnout Vandecappelle July 1, 2017, 6:22 p.m. UTC 
It seems the ! is removed by the yaml parser, so it needs to be quoted.
While we're at it, add some explanatory comment.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 .gitlab-ci.yml    | 5 ++++-
 .gitlab-ci.yml.in | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

Comments

Thomas Petazzoni July 1, 2017, 10:34 p.m. UTC | #1 
Hello,

On Sat, 1 Jul 2017 20:22:27 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> It seems the ! is removed by the yaml parser, so it needs to be quoted.
> While we're at it, add some explanatory comment.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
>  .gitlab-ci.yml    | 5 ++++-
>  .gitlab-ci.yml.in | 5 ++++-
>  2 files changed, 8 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
diff mbox

Patch

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 6bd983750d..eda8af4997 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -35,8 +35,11 @@  check-gitlab-ci.yml:
         - diff -u .gitlab-ci.yml.orig .gitlab-ci.yml
 
 check-DEVELOPERS:
+    # get-developers should print just "No action specified"; if it prints
+    # anything else, it's a parse error.
+    # The initial ! is removed by YAML so we need to quote it.
     script:
-        - ! utils/get-developers | grep -v 'No action specified'
+        - "! utils/get-developers | grep -v 'No action specified'"
 
 .defconfig: &defconfig
     # Running the defconfigs for every push is too much, so limit to
diff --git a/.gitlab-ci.yml.in b/.gitlab-ci.yml.in
index 0855bffb79..24a1888c1e 100644
--- a/.gitlab-ci.yml.in
+++ b/.gitlab-ci.yml.in
@@ -35,8 +35,11 @@  check-gitlab-ci.yml:
         - diff -u .gitlab-ci.yml.orig .gitlab-ci.yml
 
 check-DEVELOPERS:
+    # get-developers should print just "No action specified"; if it prints
+    # anything else, it's a parse error.
+    # The initial ! is removed by YAML so we need to quote it.
     script:
-        - ! utils/get-developers | grep -v 'No action specified'
+        - "! utils/get-developers | grep -v 'No action specified'"
 
 .defconfig: &defconfig
     # Running the defconfigs for every push is too much, so limit to