diff mbox

gcc: arc: Fix tst_movb pattern

Message ID 20170524153919.44524-1-abrodkin@synopsys.com
State Accepted
Headers show

Commit Message

Alexey Brodkin May 24, 2017, 3:39 p.m. UTC 
Fixes building of quagga [1]:
------------------------------>8---------------------------
839:1: error: unrecognizable insn:
 }
 ^
(insn 183 24 26 4 (set (reg:CC_ZN 61 cc)
        (and:SI (reg:SI 0 r0 [orig:192 _12->id.s_addr ] [192])
            (const_int -256 [0xffffffffffffff00]))) ospf_ri.c:790 -1
     (nil))
ospf_ri.c:839:1: internal compiler error: in extract_insn, at recog.c:2287
------------------------------>8---------------------------

Note this patch is prepared on top of arc-2017.03 release bump,
that said there's a prerequisite [2]: "toolchain: Bump ARC tools to arc-2017.03 release".

[1] http://autobuild.buildroot.net/results/3c1/3c12c4609d4a77ab8ccd3ea94840884d70520efai
[2] http://patchwork.ozlabs.org/patch/766176/

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
---
 .../0001-ARC-Fix-tst_movb-pattern.patch            | 55 ++++++++++++++++++++++
 1 file changed, 55 insertions(+)
 create mode 100644 package/gcc/arc-2017.03/0001-ARC-Fix-tst_movb-pattern.patch

Comments

Thomas Petazzoni May 25, 2017, 1:27 p.m. UTC | #1 
Hello,

On Wed, 24 May 2017 18:39:19 +0300, Alexey Brodkin wrote:
> Fixes building of quagga [1]:
> ------------------------------>8---------------------------  
> 839:1: error: unrecognizable insn:
>  }
>  ^
> (insn 183 24 26 4 (set (reg:CC_ZN 61 cc)
>         (and:SI (reg:SI 0 r0 [orig:192 _12->id.s_addr ] [192])
>             (const_int -256 [0xffffffffffffff00]))) ospf_ri.c:790 -1
>      (nil))
> ospf_ri.c:839:1: internal compiler error: in extract_insn, at recog.c:2287
> ------------------------------>8---------------------------  

Applied to master, thanks.

Thomas
diff mbox

Patch

diff --git a/package/gcc/arc-2017.03/0001-ARC-Fix-tst_movb-pattern.patch b/package/gcc/arc-2017.03/0001-ARC-Fix-tst_movb-pattern.patch
new file mode 100644
index 0000000000..3b09a13019
--- /dev/null
+++ b/package/gcc/arc-2017.03/0001-ARC-Fix-tst_movb-pattern.patch
@@ -0,0 +1,55 @@ 
+From 08235ef444fd32d311fc9edb65895133820462e3 Mon Sep 17 00:00:00 2001
+From: claziss <claziss@synopsys.com>
+Date: Wed, 24 May 2017 12:53:43 +0200
+Subject: [PATCH] [ARC] Fix tst_movb pattern.
+
+The tst_movb pattern is missing guarding when spitting.
+
+gcc/
+2017-05-24  Claudiu Zissulescu  <claziss@synopsys.com>
+
+	* config/arc/arc.md (tst_movb): Add guard when splitting.
+
+testsuite/
+2017-05-24  Claudiu Zissulescu  <claziss@synopsys.com>
+
+	* gcc.target/arc/pr9001195952.c: New test.
+---
+ gcc/config/arc/arc.md                       |  2 +-
+ gcc/testsuite/gcc.target/arc/pr9001195952.c | 11 +++++++++++
+ 2 files changed, 12 insertions(+), 1 deletion(-)
+ create mode 100755 gcc/testsuite/gcc.target/arc/pr9001195952.c
+
+diff --git a/gcc/config/arc/arc.md b/gcc/config/arc/arc.md
+index e78abaaafc42..d5510aeb0600 100644
+--- a/gcc/config/arc/arc.md
++++ b/gcc/config/arc/arc.md
+@@ -863,7 +863,7 @@ archs4xd, archs4xd_slow"
+    (clobber (match_scratch:SI 3 "=X,X,X,X,X,X,Rrq,Rrq,c"))]
+   "TARGET_NPS_BITOPS"
+   "movb.f.cl %3,%1,%p2,%p2,%s2"
+-  "reload_completed
++  "TARGET_NPS_BITOPS && reload_completed
+    && (extract_constrain_insn_cached (insn), (which_alternative & ~1) != 6)"
+   [(set (match_dup 0) (match_dup 4))])
+ 
+diff --git a/gcc/testsuite/gcc.target/arc/pr9001195952.c b/gcc/testsuite/gcc.target/arc/pr9001195952.c
+new file mode 100755
+index 000000000000..252438d8d78b
+--- /dev/null
++++ b/gcc/testsuite/gcc.target/arc/pr9001195952.c
+@@ -0,0 +1,11 @@
++/* { dg-do compile } */
++/* { dg-skip-if "" { ! { clmcpu } } } */
++/* { dg-options "-mcpu=archs -Os -w -fpic" } */
++
++/* tst_movb split pattern is wrong for anything else than NPS
++   chip.  */
++__bswap_32___bsx() {
++  int a = __builtin_bswap32(__bswap_32___bsx);
++  if (a & 1048575)
++    zlog_warn();
++}
+-- 
+2.7.4
+