| Message ID | 20170418155554.28732-2-etienne.phelip@savoirfairelinux.com |
|---|---|
| State | Rejected |
| Headers | show
Return-Path: <buildroot-bounces@busybox.net> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3w6qVq1f6Zz9s78 for <incoming@patchwork.ozlabs.org>; Wed, 19 Apr 2017 01:56:19 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 17D0C30AF8; Tue, 18 Apr 2017 15:56:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WKa5sgkHNTU7; Tue, 18 Apr 2017 15:56:14 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 4063430B1A; Tue, 18 Apr 2017 15:56:13 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id DCECD1C2C9D for <buildroot@lists.busybox.net>; Tue, 18 Apr 2017 15:56:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id D649D30AFF for <buildroot@lists.busybox.net>; Tue, 18 Apr 2017 15:56:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ha-MVnJR1pbZ for <buildroot@lists.busybox.net>; Tue, 18 Apr 2017 15:56:03 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [208.88.110.44]) by silver.osuosl.org (Postfix) with ESMTPS id F305D30AF8 for <buildroot@buildroot.org>; Tue, 18 Apr 2017 15:56:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 153579C1A16; Tue, 18 Apr 2017 11:56:02 -0400 (EDT) Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id H6zNLQ3vbd82; Tue, 18 Apr 2017 11:56:00 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 983C79C1CEA; Tue, 18 Apr 2017 11:56:00 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail.savoirfairelinux.com Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id I3e006Yi3CLY; Tue, 18 Apr 2017 11:56:00 -0400 (EDT) Received: from localhost.mtl.sfl (unknown [192.168.49.129]) by mail.savoirfairelinux.com (Postfix) with ESMTPSA id 678099C1B08; Tue, 18 Apr 2017 11:56:00 -0400 (EDT) From: Etienne Phelip <etienne.phelip@savoirfairelinux.com> To: buildroot@buildroot.org Date: Tue, 18 Apr 2017 11:55:51 -0400 Message-Id: <20170418155554.28732-2-etienne.phelip@savoirfairelinux.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170418155554.28732-1-etienne.phelip@savoirfairelinux.com> References: <20170418155554.28732-1-etienne.phelip@savoirfairelinux.com> Cc: abhimanyu.v@gmail.com, thomas.petazzoni@free-electrons.com, gael.portay@savoirfairelinux.com, Etienne Phelip <etienne.phelip@savoirfairelinux.com> Subject: [Buildroot] [RFC 1/4] genimage.sh: fix argument parsing X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot <buildroot.busybox.net> List-Unsubscribe: <http://lists.busybox.net/mailman/options/buildroot>, <mailto:buildroot-request@busybox.net?subject=unsubscribe> List-Archive: <http://lists.busybox.net/pipermail/buildroot/> List-Post: <mailto:buildroot@busybox.net> List-Help: <mailto:buildroot-request@busybox.net?subject=help> List-Subscribe: <http://lists.busybox.net/mailman/listinfo/buildroot>, <mailto:buildroot-request@busybox.net?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" <buildroot-bounces@busybox.net> |
diff --git a/support/scripts/genimage.sh b/support/scripts/genimage.sh index 0ed0e8b..6684e73 100755 --- a/support/scripts/genimage.sh +++ b/support/scripts/genimage.sh @@ -7,6 +7,9 @@ die() { GENIMAGE_TMP="${BUILD_DIR}/genimage.tmp" +# First argument is BINARIES_DIR, skip it +shift + while getopts c: OPT ; do case "${OPT}" in c) GENIMAGE_CFG="${OPTARG}";;
When executed as a post-image script, BR sets BINARIE_DIR as first argument. This first argument causes the option parsing to break. This patch shifts the first argument before performing the getopts loop. BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh" BR2_ROOTFS_POST_SCRIPT_ARGS="-c path/to/genimage.cfg" Signed-off-by: Etienne Phelip <etienne.phelip@savoirfairelinux.com> --- support/scripts/genimage.sh | 3 +++ 1 file changed, 3 insertions(+)