| Message ID | 20170321160237.31058-2-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Headers | show |
Hello, On Tue, 21 Mar 2017 18:02:36 +0200, Andy Shevchenko wrote: > The commit d7c54cb0c0cf ("bluez5_utils: not available with uClibc") > disables bluez5_utils (most of them) to be built with uClibc. Looking to > the development of BlueZ user space support that commit basically makes > the bluez5_utils package somewhat piece of junk. Not sure I understand what you mean here. > Since bluez5_utils 5.44 > deprecates all previously used tools and focuses on btmgmt and > bluetoothctl we need to restore status quo. Same here, I don't understand. > diff --git a/package/uclibc/uClibc-ng.config b/package/uclibc/uClibc-ng.config > index 528bce965..91082975e 100644 > --- a/package/uclibc/uClibc-ng.config > +++ b/package/uclibc/uClibc-ng.config > @@ -32,6 +32,7 @@ UCLIBC_HAS_GLIBC_CUSTOM_STREAMS=y > UCLIBC_HAS_PRINTF_M_SPEC=y > # UCLIBC_HAS_REGEX_OLD is not set > # UCLIBC_HAS_FNMATCH_OLD is not set > +UCLIBC_HAS_WORDEXP=y > UCLIBC_HAS_NFTW=y > UCLIBC_HAS_FTW=y > UCLIBC_HAS_GNU_GLOB=y Could you comment on the size impact of enabling this option? I.e the size of uClibc without/with this option enabled, for example on ARM? Thanks! Thomas
On Tue, 2017-03-21 at 17:06 +0100, Thomas Petazzoni wrote: > Hello, > > On Tue, 21 Mar 2017 18:02:36 +0200, Andy Shevchenko wrote: > > > The commit d7c54cb0c0cf ("bluez5_utils: not available with uClibc") > > disables bluez5_utils (most of them) to be built with uClibc. > > Looking to > > the development of BlueZ user space support that commit basically > > makes > > the bluez5_utils package somewhat piece of junk. > > Not sure I understand what you mean here. Without new tools like bluetoothctl it's impossible to use Bluetooth modules, such as BCM43341 based. hcitool, hciattach, hciconfig, etc (see the list under DEPRECATED in Makefile.tools in bluez5_utils sources) does *not* work with it. > > Since bluez5_utils 5.44 > > deprecates all previously used tools and focuses on btmgmt and > > bluetoothctl we need to restore status quo. > > Same here, I don't understand. See above. > > > diff --git a/package/uclibc/uClibc-ng.config > > b/package/uclibc/uClibc-ng.config > > index 528bce965..91082975e 100644 > > --- a/package/uclibc/uClibc-ng.config > > +++ b/package/uclibc/uClibc-ng.config > > @@ -32,6 +32,7 @@ UCLIBC_HAS_GLIBC_CUSTOM_STREAMS=y > > UCLIBC_HAS_PRINTF_M_SPEC=y > > # UCLIBC_HAS_REGEX_OLD is not set > > # UCLIBC_HAS_FNMATCH_OLD is not set > > +UCLIBC_HAS_WORDEXP=y > > UCLIBC_HAS_NFTW=y > > UCLIBC_HAS_FTW=y > > UCLIBC_HAS_GNU_GLOB=y > > Could you comment on the size impact of enabling this option? I can do it (on x86). > I.e the > size of uClibc without/with this option enabled, for example on ARM? No, I have no ARM board to test this. Or you mean to built entire stack what I'm using for some arbitrary ARM board?
Hello, On Tue, 21 Mar 2017 18:11:48 +0200, Andy Shevchenko wrote: > > I.e the > > size of uClibc without/with this option enabled, for example on ARM? > > No, I have no ARM board to test this. Or you mean to built entire stack > what I'm using for some arbitrary ARM board? You don't need a ARM board. Just make a Buildroot build for ARM with uClibc (wordexp disabled), look at the uClibc size, and then the same build but this time with your patch applied (which enables wordexp). Best regards, Thomas
On Tue, 2017-03-21 at 17:17 +0100, Thomas Petazzoni wrote: > Hello, > > On Tue, 21 Mar 2017 18:11:48 +0200, Andy Shevchenko wrote: > > > > I.e the > > > size of uClibc without/with this option enabled, for example on > > > ARM? > > > > No, I have no ARM board to test this. Or you mean to built entire > > stack > > what I'm using for some arbitrary ARM board? > > You don't need a ARM board. Just make a Buildroot build for ARM with > uClibc (wordexp disabled), look at the uClibc size, and then the same > build but this time with your patch applied (which enables wordexp). Got it. Will do when will have time later this week.
Hi Andy, On Tue, Mar 21, 2017 at 06:11:48PM +0200, Andy Shevchenko wrote: > On Tue, 2017-03-21 at 17:06 +0100, Thomas Petazzoni wrote: > > On Tue, 21 Mar 2017 18:02:36 +0200, Andy Shevchenko wrote: > > > The commit d7c54cb0c0cf ("bluez5_utils: not available with uClibc") > > > disables bluez5_utils (most of them) to be built with uClibc. > > > Looking to > > > the development of BlueZ user space support that commit basically > > > makes > > > the bluez5_utils package somewhat piece of junk. > > > > Not sure I understand what you mean here. > > Without new tools like bluetoothctl it's impossible to use Bluetooth > modules, such as BCM43341 based. This is a UART attached device, isn't it? > hcitool, hciattach, hciconfig, etc (see the list under DEPRECATED in > Makefile.tools in bluez5_utils sources) does *not* work with it. How do you bind the driver to the UART device without hciattach? baruch
Hi, Andy Shevchenko wrote, > The commit d7c54cb0c0cf ("bluez5_utils: not available with uClibc") > disables bluez5_utils (most of them) to be built with uClibc. Looking to > the development of BlueZ user space support that commit basically makes > the bluez5_utils package somewhat piece of junk. Since bluez5_utils 5.44 > deprecates all previously used tools and focuses on btmgmt and > bluetoothctl we need to restore status quo. You can add my Acked-By. It will allow to use more applications and I think it is just a minor size increase. Looking forward to your size comparison requested by Thomas, Thanks Waldemar
Hi, Andy Shevchenko wrote, > The commit d7c54cb0c0cf ("bluez5_utils: not available with uClibc") > disables bluez5_utils (most of them) to be built with uClibc. Looking to > the development of BlueZ user space support that commit basically makes > the bluez5_utils package somewhat piece of junk. Since bluez5_utils 5.44 > deprecates all previously used tools and focuses on btmgmt and > bluetoothctl we need to restore status quo. > > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > package/uclibc/uClibc-ng.config | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/uclibc/uClibc-ng.config b/package/uclibc/uClibc-ng.config > index 528bce965..91082975e 100644 > --- a/package/uclibc/uClibc-ng.config > +++ b/package/uclibc/uClibc-ng.config > @@ -32,6 +32,7 @@ UCLIBC_HAS_GLIBC_CUSTOM_STREAMS=y > UCLIBC_HAS_PRINTF_M_SPEC=y > # UCLIBC_HAS_REGEX_OLD is not set > # UCLIBC_HAS_FNMATCH_OLD is not set > +UCLIBC_HAS_WORDEXP=y > UCLIBC_HAS_NFTW=y > UCLIBC_HAS_FTW=y > UCLIBC_HAS_GNU_GLOB=y Acked-by: Waldemar Brodkorb <wbx@openadk.org> I would like to see it included. best regards Waldemar
Hello, On Tue, 21 Mar 2017 18:02:36 +0200, Andy Shevchenko wrote: > The commit d7c54cb0c0cf ("bluez5_utils: not available with uClibc") > disables bluez5_utils (most of them) to be built with uClibc. Looking to > the development of BlueZ user space support that commit basically makes > the bluez5_utils package somewhat piece of junk. Since bluez5_utils 5.44 > deprecates all previously used tools and focuses on btmgmt and > bluetoothctl we need to restore status quo. > > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > package/uclibc/uClibc-ng.config | 1 + > 1 file changed, 1 insertion(+) I've applied, after rewriting the commit message. If there's some bluez5_utils improvements that can be done now that wordexp is enabled, please send patches. Thanks! Thomas
diff --git a/package/uclibc/uClibc-ng.config b/package/uclibc/uClibc-ng.config index 528bce965..91082975e 100644 --- a/package/uclibc/uClibc-ng.config +++ b/package/uclibc/uClibc-ng.config @@ -32,6 +32,7 @@ UCLIBC_HAS_GLIBC_CUSTOM_STREAMS=y UCLIBC_HAS_PRINTF_M_SPEC=y # UCLIBC_HAS_REGEX_OLD is not set # UCLIBC_HAS_FNMATCH_OLD is not set +UCLIBC_HAS_WORDEXP=y UCLIBC_HAS_NFTW=y UCLIBC_HAS_FTW=y UCLIBC_HAS_GNU_GLOB=y
The commit d7c54cb0c0cf ("bluez5_utils: not available with uClibc") disables bluez5_utils (most of them) to be built with uClibc. Looking to the development of BlueZ user space support that commit basically makes the bluez5_utils package somewhat piece of junk. Since bluez5_utils 5.44 deprecates all previously used tools and focuses on btmgmt and bluetoothctl we need to restore status quo. Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- package/uclibc/uClibc-ng.config | 1 + 1 file changed, 1 insertion(+)