| Message ID | 20131114225758.GA13765@gmail.com |
|---|---|
| State | Accepted |
| Commit | 157101726c3d490d20cae4f3ad61197330b06df1 |
| Headers | show |
Dear Andrew Ruder, On Thu, 14 Nov 2013 16:57:58 -0600, Andrew Ruder wrote: > As far as I can tell enabling tcl support has no affect on the actual > library. Furthermore, wvstreams has been checking for/linking against > tcl 8.3 which has never been supported in buildroot as far as I can tell > (8.4 added in 2005). That being said there is clearly no reason to keep > this around. Let's Cc Simon Dawson on this one, he is the one who added wvstreams in the first place, earlier this year. Maybe he can comment on the TCL side of it. > On a side-note, I am testing a few bigger patches to get expect 5.45 > and tcl 8.6.1 added/bumped. I haven't done a decent amount of testing, > but figured I'd get some of the smaller patches out of the way as I go. Great! Thomas
>>>>> "Andrew" == Andrew Ruder <andrew.ruder@elecsyscorp.com> writes: > As far as I can tell enabling tcl support has no affect on the actual > library. Furthermore, wvstreams has been checking for/linking against > tcl 8.3 which has never been supported in buildroot as far as I can tell > (8.4 added in 2005). That being said there is clearly no reason to keep > this around. > Signed-off-by: Andrew Ruder <andrew.ruder@elecsyscorp.com> Committed, thanks. > --- > On a side-note, I am testing a few bigger patches to get expect 5.45 > and tcl 8.6.1 added/bumped. I haven't done a decent amount of testing, > but figured I'd get some of the smaller patches out of the way as I go. Sounds good!
diff --git a/package/wvstreams/wvstreams.mk b/package/wvstreams/wvstreams.mk index b4f7d89..41155a7 100644 --- a/package/wvstreams/wvstreams.mk +++ b/package/wvstreams/wvstreams.mk @@ -22,7 +22,8 @@ WVSTREAMS_CONF_OPT += \ --with-openssl \ --with-zlib \ --without-pam \ - --disable-warnings + --disable-warnings \ + --without-tcl # needed for openssl detection when statically linking (as ssl needs lz) WVSTREAMS_CONF_ENV += LIBS=-lz @@ -38,13 +39,6 @@ else WVSTREAMS_CONF_OPT += --without-dbus endif -ifeq ($(BR2_PACKAGE_TCL),y) - WVSTREAMS_DEPENDENCIES += tcl - WVSTREAMS_CONF_OPT += --with-tcl -else - WVSTREAMS_CONF_OPT += --without-tcl -endif - ifeq ($(BR2_PACKAGE_QT),y) WVSTREAMS_DEPENDENCIES += qt WVSTREAMS_CONF_OPT += --with-qt
As far as I can tell enabling tcl support has no affect on the actual library. Furthermore, wvstreams has been checking for/linking against tcl 8.3 which has never been supported in buildroot as far as I can tell (8.4 added in 2005). That being said there is clearly no reason to keep this around. Signed-off-by: Andrew Ruder <andrew.ruder@elecsyscorp.com> --- On a side-note, I am testing a few bigger patches to get expect 5.45 and tcl 8.6.1 added/bumped. I haven't done a decent amount of testing, but figured I'd get some of the smaller patches out of the way as I go. package/wvstreams/wvstreams.mk | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)