diff mbox series

[4/4] configs: bpi-m64: bump linux, uboot

Message ID 1535963172-6664-4-git-send-email-jagan@amarulasolutions.com
State Changes Requested
Headers show
Series [1/4] DEVELOPERS: Fix file order list maintained by me | expand

Commit Message

Jagan Teki Sept. 3, 2018, 8:26 a.m. UTC
- Uboot to 2017.15
- Linux to 4.17

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 configs/bananapi_m64_defconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Luca Ceresoli Sept. 3, 2018, 2:43 p.m. UTC | #1
Hi Jagan,

On 03/09/2018 10:26, Jagan Teki wrote:
> - Uboot to 2017.15
> - Linux to 4.17
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>  configs/bananapi_m64_defconfig | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/configs/bananapi_m64_defconfig b/configs/bananapi_m64_defconfig
> index db39903..b071230 100644
> --- a/configs/bananapi_m64_defconfig
> +++ b/configs/bananapi_m64_defconfig
> @@ -2,8 +2,8 @@ BR2_aarch64=y
>  BR2_cortex_a53=y
>  BR2_ARM_FPU_VFPV4=y
>  
> -# Linux headers same as kernel, a 4.14 series
> -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y
> +# Linux headers same as kernel, a 4.17 series
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_17=y
>  
>  # Firmware
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
> @@ -17,7 +17,7 @@ BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
>  BR2_TARGET_UBOOT=y
>  BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
>  BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> -BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.11"
> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.15"

I don't think version 2017.15 really exists. I tested, just in case, and
got a 404.

Also, out of personal taste, I would put the whole defconfig name in the
patch subject, to be more grep-friendly:

- [PATCH 4/4] configs: bpi-m64: bump linux, uboot
+ [PATCH 4/4] configs: bananapi_m64: bump linux, uboot

Regards,
Thomas Petazzoni Sept. 4, 2018, 8:21 a.m. UTC | #2
Hello,

On Mon, 3 Sep 2018 16:43:30 +0200, Luca Ceresoli wrote:

> - [PATCH 4/4] configs: bpi-m64: bump linux, uboot
> + [PATCH 4/4] configs: bananapi_m64: bump linux, uboot

Nitpicking: I even prefer:

	configs/banapi_m64:

which we use more commonly in Buildroot.

Thomas
diff mbox series

Patch

diff --git a/configs/bananapi_m64_defconfig b/configs/bananapi_m64_defconfig
index db39903..b071230 100644
--- a/configs/bananapi_m64_defconfig
+++ b/configs/bananapi_m64_defconfig
@@ -2,8 +2,8 @@  BR2_aarch64=y
 BR2_cortex_a53=y
 BR2_ARM_FPU_VFPV4=y
 
-# Linux headers same as kernel, a 4.14 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y
+# Linux headers same as kernel, a 4.17 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_17=y
 
 # Firmware
 BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
@@ -17,7 +17,7 @@  BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.11"
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.15"
 BR2_TARGET_UBOOT_BOARD_DEFCONFIG="bananapi_m64"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
 BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
@@ -31,7 +31,7 @@  BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE="board/bananapi/bananapi-m64/boot.cmd"
 # Kernel
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.14"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.17"
 BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
 BR2_LINUX_KERNEL_INTREE_DTS_NAME="allwinner/sun50i-a64-bananapi-m64"