| Message ID | 1488727151-7633-1-git-send-email-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Accepted |
| Headers | show |
Thomas, All, On 2017-03-05 16:19 +0100, Thomas Petazzoni spake thusly: > cryptsetup installs a library and a header file, so it makes sense to > install it to staging. > > Fixes bug #9691. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Reviewed-by: Me Regards, Yann E. MORIN. > --- > package/cryptsetup/cryptsetup.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/cryptsetup/cryptsetup.mk b/package/cryptsetup/cryptsetup.mk > index 50bf5f2..6081009 100644 > --- a/package/cryptsetup/cryptsetup.mk > +++ b/package/cryptsetup/cryptsetup.mk > @@ -12,6 +12,7 @@ CRYPTSETUP_DEPENDENCIES = lvm2 popt util-linux host-pkgconf \ > $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext) > CRYPTSETUP_LICENSE = GPLv2+ (programs), LGPLv2.1+ (library) > CRYPTSETUP_LICENSE_FILES = COPYING COPYING.LGPL > +CRYPTSETUP_INSTALL_STAGING = YES > > ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y) > CRYPTSETUP_CONF_ENV += LDFLAGS="$(TARGET_LDFLAGS) -lintl" > -- > 2.7.4 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hello, On Sun, 5 Mar 2017 16:19:11 +0100, Thomas Petazzoni wrote: > cryptsetup installs a library and a header file, so it makes sense to > install it to staging. > > Fixes bug #9691. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > package/cryptsetup/cryptsetup.mk | 1 + > 1 file changed, 1 insertion(+) Applied to master, thanks. Thomas
Hello, On Sun, 5 Mar 2017 16:34:22 +0100, Yann E. MORIN wrote: > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > Reviewed-by: Me Thanks for reviewing. However, it would be nicer if your Reviewed-by tag had been a real one: remember they are picked up by patchwork, and therefore I don't have to manually add Reviewed-by/Tested-by/Acked-by tags when applying... except when people use them like you did :-) Thanks! Thomas
Thomas, All, On 2017-03-05 21:36 +0100, Thomas Petazzoni spake thusly: > On Sun, 5 Mar 2017 16:34:22 +0100, Yann E. MORIN wrote: > > > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > > > Reviewed-by: Me > > Thanks for reviewing. However, it would be nicer if your Reviewed-by > tag had been a real one: remember they are picked up by patchwork, and > therefore I don't have to manually add Reviewed-by/Tested-by/Acked-by > tags when applying... except when people use them like you did :-) Damn, autocompletion snafu... Thanks for fixing. Regards, Yann E. MORIN.
diff --git a/package/cryptsetup/cryptsetup.mk b/package/cryptsetup/cryptsetup.mk index 50bf5f2..6081009 100644 --- a/package/cryptsetup/cryptsetup.mk +++ b/package/cryptsetup/cryptsetup.mk @@ -12,6 +12,7 @@ CRYPTSETUP_DEPENDENCIES = lvm2 popt util-linux host-pkgconf \ $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext) CRYPTSETUP_LICENSE = GPLv2+ (programs), LGPLv2.1+ (library) CRYPTSETUP_LICENSE_FILES = COPYING COPYING.LGPL +CRYPTSETUP_INSTALL_STAGING = YES ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y) CRYPTSETUP_CONF_ENV += LDFLAGS="$(TARGET_LDFLAGS) -lintl"
cryptsetup installs a library and a header file, so it makes sense to install it to staging. Fixes bug #9691. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- package/cryptsetup/cryptsetup.mk | 1 + 1 file changed, 1 insertion(+)