| Message ID | 1471887117-18135-1-git-send-email-rahul.bedarkar@imgtec.com |
|---|---|
| State | Accepted |
| Headers | show |
Hello, On Mon, 22 Aug 2016 23:01:57 +0530, Rahul Bedarkar wrote: > With glibc 2.16, we get following build error when building jack2: > > [193/247] cxx: tests/iodelay.cpp -> build/tests/iodelay.cpp.4.o > ../tests/iodelay.cpp:171:43: error: 'UINT32_MAX' was not declared in this scope > ../tests/iodelay.cpp:171:55: error: 'UINT32_MAX' was not declared in this scope > ../tests/iodelay.cpp:172:44: error: 'UINT32_MAX' was not declared in this scope > ../tests/iodelay.cpp:172:56: error: 'UINT32_MAX' was not declared in this scope > > In glibc 2.17 or older version, Header <stdint.h> defines these macros > for C++ only if explicitly requested by defining __STDC_LIMIT_MACROS. > > We can't use <cstdint> since it requires C++11 standard. > > Fixes: > > http://autobuild.buildroot.net/results/369/369ce208ffea43dad75ba0a13469159b341e3bf5/ > > Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com> > --- > .../0003-tests-define-__STDC_LIMIT_MACROS.patch | 41 ++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 package/jack2/0003-tests-define-__STDC_LIMIT_MACROS.patch Applied to master, thanks. Please submit your patch to the upstream jack2 project. Thanks! Thomas
diff --git a/package/jack2/0003-tests-define-__STDC_LIMIT_MACROS.patch b/package/jack2/0003-tests-define-__STDC_LIMIT_MACROS.patch new file mode 100644 index 0000000..96377f9 --- /dev/null +++ b/package/jack2/0003-tests-define-__STDC_LIMIT_MACROS.patch @@ -0,0 +1,41 @@ +From c971aaab74ca6e7d4ac3a06bd26e7309dfc5da45 Mon Sep 17 00:00:00 2001 +From: Rahul Bedarkar <rahul.bedarkar@imgtec.com> +Date: Mon, 22 Aug 2016 19:04:47 +0530 +Subject: [PATCH 1/1] tests: define __STDC_LIMIT_MACROS + +With glibc 2.16, we get following build error when building jack2: + + [193/247] cxx: tests/iodelay.cpp -> build/tests/iodelay.cpp.4.o + ../tests/iodelay.cpp:171:43: error: 'UINT32_MAX' was not declared in this scope + ../tests/iodelay.cpp:171:55: error: 'UINT32_MAX' was not declared in this scope + ../tests/iodelay.cpp:172:44: error: 'UINT32_MAX' was not declared in this scope + ../tests/iodelay.cpp:172:56: error: 'UINT32_MAX' was not declared in this scope + +In glibc 2.17 or older version, Header <stdint.h> defines these macros +for C++ only if explicitly requested by defining __STDC_LIMIT_MACROS. + +We can't use <cstdint> since it requires C++11 standard. + +This build issue found by Buildroot autobuilder. +http://autobuild.buildroot.net/results/369/369ce208ffea43dad75ba0a13469159b341e3bf5/ + +Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com> +--- + tests/iodelay.cpp | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/tests/iodelay.cpp b/tests/iodelay.cpp +index 1ef470f..f5c5836 100644 +--- a/tests/iodelay.cpp ++++ b/tests/iodelay.cpp +@@ -20,6 +20,7 @@ + + #include <stdlib.h> + #include <stdio.h> ++#define __STDC_LIMIT_MACROS + #include <stdint.h> + #include <math.h> + #include <unistd.h> +-- +2.6.2 +
With glibc 2.16, we get following build error when building jack2: [193/247] cxx: tests/iodelay.cpp -> build/tests/iodelay.cpp.4.o ../tests/iodelay.cpp:171:43: error: 'UINT32_MAX' was not declared in this scope ../tests/iodelay.cpp:171:55: error: 'UINT32_MAX' was not declared in this scope ../tests/iodelay.cpp:172:44: error: 'UINT32_MAX' was not declared in this scope ../tests/iodelay.cpp:172:56: error: 'UINT32_MAX' was not declared in this scope In glibc 2.17 or older version, Header <stdint.h> defines these macros for C++ only if explicitly requested by defining __STDC_LIMIT_MACROS. We can't use <cstdint> since it requires C++11 standard. Fixes: http://autobuild.buildroot.net/results/369/369ce208ffea43dad75ba0a13469159b341e3bf5/ Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com> --- .../0003-tests-define-__STDC_LIMIT_MACROS.patch | 41 ++++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 package/jack2/0003-tests-define-__STDC_LIMIT_MACROS.patch