diff mbox

skeleton: /etc/network/interface.d/* support

Message ID 1471360870-53982-1-git-send-email-matthew.weber@rockwellcollins.com
State Rejected
Headers show

Commit Message

Matt Weber Aug. 16, 2016, 3:21 p.m. UTC 
Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
---
 package/skeleton/skeleton.mk                    | 2 ++
 system/device_table.txt                         | 1 +
 system/skeleton/etc/network/interfaces.d/.empty | 0
 3 files changed, 3 insertions(+)
 create mode 100644 system/skeleton/etc/network/interfaces.d/.empty

diff --git a/system/skeleton/etc/network/interfaces.d/.empty b/system/skeleton/etc/network/interfaces.d/.empty
new file mode 100644
index 0000000..e69de29

Comments

Matt Weber Aug. 16, 2016, 3:36 p.m. UTC | #1 
All,

On Tue, Aug 16, 2016 at 10:21 AM, Matt Weber <
matthew.weber@rockwellcollins.com> wrote:

> Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
> ---
>  package/skeleton/skeleton.mk                    | 2 ++
>  system/device_table.txt                         | 1 +
>  system/skeleton/etc/network/interfaces.d/.empty | 0
>  3 files changed, 3 insertions(+)
>  create mode 100644 system/skeleton/etc/network/interfaces.d/.empty
>
> diff --git a/package/skeleton/skeleton.mk b/package/skeleton/skeleton.mk
> index 1000161..c9dce10 100644
> --- a/package/skeleton/skeleton.mk
> +++ b/package/skeleton/skeleton.mk
> @@ -151,6 +151,8 @@ define SKELETON_SET_NETWORK_LOCALHOST
>                 echo ;                                               \
>                 echo "auto lo";                                      \
>                 echo "iface lo inet loopback";                       \
> +               echo ;                                               \
> +               echo "source interfaces.d/*";                        \
>

Needs to be conditional for BR2_PACKAGE_IFUPDOWN supports this and busybox
does not



>         ) > $(TARGET_DIR)/etc/network/interfaces
>  endef
>
> diff --git a/system/device_table.txt b/system/device_table.txt
> index dc1af51..69b1d46 100644
> --- a/system/device_table.txt
> +++ b/system/device_table.txt
> @@ -17,5 +17,6 @@
>  /etc/network/if-pre-up.d               d       755     0       0       -
>      -       -       -       -
>  /etc/network/if-down.d                 d       755     0       0       -
>      -       -       -       -
>  /etc/network/if-post-down.d            d       755     0       0       -
>      -       -       -       -
> +/etc/network/interfaces.d              d       755     0       0       -
>      -       -       -       -
>  # uncomment this to allow starting x as non-root
>  #/usr/X11R6/bin/Xfbdev                 f       4755    0       0       -
>      -       -       -       -
> diff --git a/system/skeleton/etc/network/interfaces.d/.empty
> b/system/skeleton/etc/network/interfaces.d/.empty
> new file mode 100644
> index 0000000..e69de29
> --
> 1.9.1
>
>
Khem Raj Aug. 16, 2016, 4:34 p.m. UTC | #2 
> On Aug 16, 2016, at 8:21 AM, Matt Weber <matthew.weber@rockwellcollins.com> wrote:
> 
> Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
> ---
> package/skeleton/skeleton.mk                    | 2 ++
> system/device_table.txt                         | 1 +
> system/skeleton/etc/network/interfaces.d/.empty | 0
> 3 files changed, 3 insertions(+)
> create mode 100644 system/skeleton/etc/network/interfaces.d/.empty
> 
> diff --git a/package/skeleton/skeleton.mk b/package/skeleton/skeleton.mk
> index 1000161..c9dce10 100644
> --- a/package/skeleton/skeleton.mk
> +++ b/package/skeleton/skeleton.mk
> @@ -151,6 +151,8 @@ define SKELETON_SET_NETWORK_LOCALHOST
> 		echo ;                                               \
> 		echo "auto lo";                                      \
> 		echo "iface lo inet loopback";                       \
> +		echo ;                                               \
> +		echo "source interfaces.d/*";                        \

its portable to use . instead of source keyword

> 	) > $(TARGET_DIR)/etc/network/interfaces
> endef
> 
> diff --git a/system/device_table.txt b/system/device_table.txt
> index dc1af51..69b1d46 100644
> --- a/system/device_table.txt
> +++ b/system/device_table.txt
> @@ -17,5 +17,6 @@
> /etc/network/if-pre-up.d		d	755	0	0	-	-	-	-	-
> /etc/network/if-down.d			d	755	0	0	-	-	-	-	-
> /etc/network/if-post-down.d		d	755	0	0	-	-	-	-	-
> +/etc/network/interfaces.d		d	755	0	0	-	-	-	-	-
> # uncomment this to allow starting x as non-root
> #/usr/X11R6/bin/Xfbdev		     	f	4755	0	0	-	-	-	-	-
> diff --git a/system/skeleton/etc/network/interfaces.d/.empty b/system/skeleton/etc/network/interfaces.d/.empty
> new file mode 100644
> index 0000000..e69de29
> --
> 1.9.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Matt Weber Aug. 16, 2016, 8:25 p.m. UTC | #3 
Khem,

On Tue, Aug 16, 2016 at 11:34 AM, Khem Raj <raj.khem@gmail.com> wrote:

>
> > On Aug 16, 2016, at 8:21 AM, Matt Weber <matthew.weber@
> rockwellcollins.com> wrote:
> >
> > Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
> > ---
> > package/skeleton/skeleton.mk                    | 2 ++
> > system/device_table.txt                         | 1 +
> > system/skeleton/etc/network/interfaces.d/.empty | 0
> > 3 files changed, 3 insertions(+)
> > create mode 100644 system/skeleton/etc/network/interfaces.d/.empty
> >
> > diff --git a/package/skeleton/skeleton.mk b/package/skeleton/skeleton.mk
> > index 1000161..c9dce10 100644
> > --- a/package/skeleton/skeleton.mk
> > +++ b/package/skeleton/skeleton.mk
> > @@ -151,6 +151,8 @@ define SKELETON_SET_NETWORK_LOCALHOST
> >               echo ;                                               \
> >               echo "auto lo";                                      \
> >               echo "iface lo inet loopback";                       \
> > +             echo ;                                               \
> > +             echo "source interfaces.d/*";                        \
>
> its portable to use . instead of source keyword
>

That doesn't seem to work in this case.  Is seems it's keying off the word
source vs it being more shell like.


>
> >       ) > $(TARGET_DIR)/etc/network/interfaces
> > endef
> >
> > diff --git a/system/device_table.txt b/system/device_table.txt
> > index dc1af51..69b1d46 100644
> > --- a/system/device_table.txt
> > +++ b/system/device_table.txt
> > @@ -17,5 +17,6 @@
> > /etc/network/if-pre-up.d              d       755     0       0       -
>      -       -       -       -
> > /etc/network/if-down.d                        d       755     0       0
>      -       -       -       -       -
> > /etc/network/if-post-down.d           d       755     0       0       -
>      -       -       -       -
> > +/etc/network/interfaces.d            d       755     0       0       -
>      -       -       -       -
> > # uncomment this to allow starting x as non-root
> > #/usr/X11R6/bin/Xfbdev                        f       4755    0       0
>      -       -       -       -       -
> > diff --git a/system/skeleton/etc/network/interfaces.d/.empty
> b/system/skeleton/etc/network/interfaces.d/.empty
> > new file mode 100644
> > index 0000000..e69de29
> > --
> > 1.9.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
>
Khem Raj Aug. 16, 2016, 8:33 p.m. UTC | #4 
> On Aug 16, 2016, at 1:25 PM, Matthew Weber <matthew.weber@rockwellcollins.com> wrote:
> 
> Khem,
> 
> On Tue, Aug 16, 2016 at 11:34 AM, Khem Raj <raj.khem@gmail.com <mailto:raj.khem@gmail.com>> wrote:
> 
> > On Aug 16, 2016, at 8:21 AM, Matt Weber <matthew.weber@rockwellcollins.com <mailto:matthew.weber@rockwellcollins.com>> wrote:
> >
> > Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com <mailto:matthew.weber@rockwellcollins.com>>
> > ---
> > package/skeleton/skeleton.mk <http://skeleton.mk/>                    | 2 ++
> > system/device_table.txt                         | 1 +
> > system/skeleton/etc/network/interfaces.d/.empty | 0
> > 3 files changed, 3 insertions(+)
> > create mode 100644 system/skeleton/etc/network/interfaces.d/.empty
> >
> > diff --git a/package/skeleton/skeleton.mk <http://skeleton.mk/> b/package/skeleton/skeleton.mk <http://skeleton.mk/>
> > index 1000161..c9dce10 100644
> > --- a/package/skeleton/skeleton.mk <http://skeleton.mk/>
> > +++ b/package/skeleton/skeleton.mk <http://skeleton.mk/>
> > @@ -151,6 +151,8 @@ define SKELETON_SET_NETWORK_LOCALHOST
> >               echo ;                                               \
> >               echo "auto lo";                                      \
> >               echo "iface lo inet loopback";                       \
> > +             echo ;                                               \
> > +             echo "source interfaces.d/*";                        \
> 
> its portable to use . instead of source keyword
> 
> That doesn't seem to work in this case.  Is seems it's keying off the word source vs it being more shell like.
> 

Is it run in Make context and not shell context ?

> 
> >       ) > $(TARGET_DIR)/etc/network/interfaces
> > endef
> >
> > diff --git a/system/device_table.txt b/system/device_table.txt
> > index dc1af51..69b1d46 100644
> > --- a/system/device_table.txt
> > +++ b/system/device_table.txt
> > @@ -17,5 +17,6 @@
> > /etc/network/if-pre-up.d              d       755     0       0       -       -       -       -       -
> > /etc/network/if-down.d                        d       755     0       0       -       -       -       -       -
> > /etc/network/if-post-down.d           d       755     0       0       -       -       -       -       -
> > +/etc/network/interfaces.d            d       755     0       0       -       -       -       -       -
> > # uncomment this to allow starting x as non-root
> > #/usr/X11R6/bin/Xfbdev                        f       4755    0       0       -       -       -       -       -
> > diff --git a/system/skeleton/etc/network/interfaces.d/.empty b/system/skeleton/etc/network/interfaces.d/.empty
> > new file mode 100644
> > index 0000000..e69de29
> > --
> > 1.9.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@busybox.net <mailto:buildroot@busybox.net>
> > http://lists.busybox.net/mailman/listinfo/buildroot <http://lists.busybox.net/mailman/listinfo/buildroot>
> 
> 
> 
> 
> --
> Matthew L Weber / Pr Software Engineer
> Airborne Information Systems / Security Systems and Software / Secure Platforms
> MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
> www.rockwellcollins.com <http://www.rockwellcollins.com/>
> 
> Note: Any Export License Required Information and License Restricted Third Party Intellectual Property (TPIP) content must be encrypted and sent to matthew.weber@corp.rockwellcollins.com <mailto:matthew.weber@corp.rockwellcollins.com>.
Matt Weber Aug. 17, 2016, 1:23 a.m. UTC | #5 
Khem,

On Aug 16, 2016 3:33 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
>
>
>> On Aug 16, 2016, at 1:25 PM, Matthew Weber <
matthew.weber@rockwellcollins.com> wrote:
>>
>> Khem,
>>
>> On Tue, Aug 16, 2016 at 11:34 AM, Khem Raj <raj.khem@gmail.com> wrote:
>>>
>>>
>>> > On Aug 16, 2016, at 8:21 AM, Matt Weber <
matthew.weber@rockwellcollins.com> wrote:
>>> >
>>> > Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
>>> > ---
>>> > package/skeleton/skeleton.mk                    | 2 ++
>>> > system/device_table.txt                         | 1 +
>>> > system/skeleton/etc/network/interfaces.d/.empty | 0
>>> > 3 files changed, 3 insertions(+)
>>> > create mode 100644 system/skeleton/etc/network/interfaces.d/.empty
>>> >
>>> > diff --git a/package/skeleton/skeleton.mk b/package/skeleton/
skeleton.mk
>>> > index 1000161..c9dce10 100644
>>> > --- a/package/skeleton/skeleton.mk
>>> > +++ b/package/skeleton/skeleton.mk
>>> > @@ -151,6 +151,8 @@ define SKELETON_SET_NETWORK_LOCALHOST
>>> >               echo ;                                               \
>>> >               echo "auto lo";                                      \
>>> >               echo "iface lo inet loopback";                       \
>>> > +             echo ;                                               \
>>> > +             echo "source interfaces.d/*";                        \
>>>
>>> its portable to use . instead of source keyword
>>
>>
>> That doesn't seem to work in this case.  Is seems it's keying off the
word source vs it being more shell like.
>>
>
>
> Is it run in Make context and not shell context ?

The ifupdown daemon consumes the file,  it isn't executed

>
>>>
>>> >       ) > $(TARGET_DIR)/etc/network/interfaces
>>> > endef
>>> >
>>> > diff --git a/system/device_table.txt b/system/device_table.txt
>>> > index dc1af51..69b1d46 100644
>>> > --- a/system/device_table.txt
>>> > +++ b/system/device_table.txt
>>> > @@ -17,5 +17,6 @@
>>> > /etc/network/if-pre-up.d              d       755     0       0
 -       -       -       -       -
>>> > /etc/network/if-down.d                        d       755     0
 0       -       -       -       -       -
>>> > /etc/network/if-post-down.d           d       755     0       0
 -       -       -       -       -
>>> > +/etc/network/interfaces.d            d       755     0       0
 -       -       -       -       -
>>> > # uncomment this to allow starting x as non-root
>>> > #/usr/X11R6/bin/Xfbdev                        f       4755    0
 0       -       -       -       -       -
>>> > diff --git a/system/skeleton/etc/network/interfaces.d/.empty
b/system/skeleton/etc/network/interfaces.d/.empty
>>> > new file mode 100644
>>> > index 0000000..e69de29
>>> > --
>>> > 1.9.1
>>> >
>>> > _______________________________________________
>>> > buildroot mailing list
>>> > buildroot@busybox.net
>>> > http://lists.busybox.net/mailman/listinfo/buildroot
>>>
>>
>>
>>
>> --
>> Matthew L Weber / Pr Software Engineer
>> Airborne Information Systems / Security Systems and Software / Secure
Platforms
>> MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
>> www.rockwellcollins.com
>>
>> Note: Any Export License Required Information and License Restricted
Third Party Intellectual Property (TPIP) content must be encrypted and sent
to matthew.weber@corp.rockwellcollins.com.
>
>
diff mbox

Patch

diff --git a/package/skeleton/skeleton.mk b/package/skeleton/skeleton.mk
index 1000161..c9dce10 100644
--- a/package/skeleton/skeleton.mk
+++ b/package/skeleton/skeleton.mk
@@ -151,6 +151,8 @@  define SKELETON_SET_NETWORK_LOCALHOST
 		echo ;                                               \
 		echo "auto lo";                                      \
 		echo "iface lo inet loopback";                       \
+		echo ;                                               \
+		echo "source interfaces.d/*";                        \
 	) > $(TARGET_DIR)/etc/network/interfaces
 endef
 
diff --git a/system/device_table.txt b/system/device_table.txt
index dc1af51..69b1d46 100644
--- a/system/device_table.txt
+++ b/system/device_table.txt
@@ -17,5 +17,6 @@ 
 /etc/network/if-pre-up.d		d	755	0	0	-	-	-	-	-
 /etc/network/if-down.d			d	755	0	0	-	-	-	-	-
 /etc/network/if-post-down.d		d	755	0	0	-	-	-	-	-
+/etc/network/interfaces.d		d	755	0	0	-	-	-	-	-
 # uncomment this to allow starting x as non-root
 #/usr/X11R6/bin/Xfbdev		     	f	4755	0	0	-	-	-	-	-