diff mbox

[1/6] gnutls: update legal info

Message ID 1467636386-6759-1-git-send-email-rahul.bedarkar@imgtec.com
State Accepted
Headers show

Commit Message

Rahul Bedarkar July 4, 2016, 12:46 p.m. UTC
GnuTLS core library is licensed under LGPLv2.1+ while gnutls-openssl
library is licensed under GPLv3+. Annotate the license with components.

Reviewed-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
---
 package/gnutls/gnutls.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yann E. MORIN July 4, 2016, 3:39 p.m. UTC | #1
Rahul, All,

On 2016-07-04 18:16 +0530, Rahul Bedarkar spake thusly:
> GnuTLS core library is licensed under LGPLv2.1+ while gnutls-openssl
> library is licensed under GPLv3+. Annotate the license with components.

What do you call "core library" and "gnutls-openssl library"?

Do you consider libdane to be that "gnutls-openssl library" you talk
about?

I've looked at the source, and libdane is (at least partially) LGPLv3:

    libdane/errors.c:
    [--SNIP--]
     * libdane is free software; you can redistribute it and/or
     * modify it under the terms of the GNU Lesser General Public License
     * as published by the Free Software Foundation; either version 3 of
     * the License, or (at your option) any later version.
    [--SNIP--]

Could you please review the situation and provide a bit more
explanations as to what is what, please?

Regards,
Yann E. MORIN.

> Reviewed-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
> Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
> ---
>  package/gnutls/gnutls.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/gnutls/gnutls.mk b/package/gnutls/gnutls.mk
> index 76d2ca2..c063f8f 100644
> --- a/package/gnutls/gnutls.mk
> +++ b/package/gnutls/gnutls.mk
> @@ -8,7 +8,7 @@ GNUTLS_VERSION_MAJOR = 3.4
>  GNUTLS_VERSION = $(GNUTLS_VERSION_MAJOR).13
>  GNUTLS_SOURCE = gnutls-$(GNUTLS_VERSION).tar.xz
>  GNUTLS_SITE = ftp://ftp.gnutls.org/gcrypt/gnutls/v$(GNUTLS_VERSION_MAJOR)
> -GNUTLS_LICENSE = GPLv3+, LGPLv2.1+
> +GNUTLS_LICENSE = GPLv3+ (gnutls-openssl library), LGPLv2.1+ (core library)
>  GNUTLS_LICENSE_FILES = COPYING COPYING.LESSER
>  GNUTLS_DEPENDENCIES = host-pkgconf libtasn1 nettle pcre
>  GNUTLS_CONF_OPTS = \
> -- 
> 2.6.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni July 4, 2016, 10:13 p.m. UTC | #2
Hello,

On Mon, 4 Jul 2016 17:39:50 +0200, Yann E. MORIN wrote:

> On 2016-07-04 18:16 +0530, Rahul Bedarkar spake thusly:
> > GnuTLS core library is licensed under LGPLv2.1+ while gnutls-openssl
> > library is licensed under GPLv3+. Annotate the license with components.  
> 
> What do you call "core library" and "gnutls-openssl library"?

This is explained in the README file:

"""
Since GnuTLS version 3.1.10, the core library has been released under
the GNU Lesser General Public License (LGPL) version 2.1 or later.

Note, however, that version 6.0.0 and later of the gmplib library used
by GnuTLS are distributed under a LGPLv3+ or GPLv2+ dual license, and
as such binaries of this library need to adhere to either LGPLv3+ or
GPLv2+ license.

The GNU LGPL applies to the main GnuTLS library, while the
included applications as well as gnutls-openssl 
library are under the GNU GPL version 3.  The gnutls library is 
located in the lib/ and libdane/ directories, while the applications
in src/ and, the gnutls-openssl library is at extra/.
"""

> 
> Do you consider libdane to be that "gnutls-openssl library" you talk
> about?

No, see above. libdane is part of the "core library".

> I've looked at the source, and libdane is (at least partially) LGPLv3:
> 
>     libdane/errors.c:
>     [--SNIP--]
>      * libdane is free software; you can redistribute it and/or
>      * modify it under the terms of the GNU Lesser General Public License
>      * as published by the Free Software Foundation; either version 3 of
>      * the License, or (at your option) any later version.
>     [--SNIP--]

This seems to be a bug, which I've reported upstream at
https://gitlab.com/gnutls/gnutls/issues/109.

Thomas
Thomas Petazzoni July 4, 2016, 10:14 p.m. UTC | #3
Hello,

On Mon, 4 Jul 2016 18:16:21 +0530, Rahul Bedarkar wrote:
> GnuTLS core library is licensed under LGPLv2.1+ while gnutls-openssl
> library is licensed under GPLv3+. Annotate the license with components.
> 
> Reviewed-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
> Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
> ---
>  package/gnutls/gnutls.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied with some changes:

    [Thomas:
     - add comment about the license of the "core library" since some files
       seems to be mistakenly under LGPLv3+ even though the library is
       licensed under LGPLv2.1+.
     - add the README file in the license information, since it contains a
       lot of useful details.]

Thanks!

Thomas
diff mbox

Patch

diff --git a/package/gnutls/gnutls.mk b/package/gnutls/gnutls.mk
index 76d2ca2..c063f8f 100644
--- a/package/gnutls/gnutls.mk
+++ b/package/gnutls/gnutls.mk
@@ -8,7 +8,7 @@  GNUTLS_VERSION_MAJOR = 3.4
 GNUTLS_VERSION = $(GNUTLS_VERSION_MAJOR).13
 GNUTLS_SOURCE = gnutls-$(GNUTLS_VERSION).tar.xz
 GNUTLS_SITE = ftp://ftp.gnutls.org/gcrypt/gnutls/v$(GNUTLS_VERSION_MAJOR)
-GNUTLS_LICENSE = GPLv3+, LGPLv2.1+
+GNUTLS_LICENSE = GPLv3+ (gnutls-openssl library), LGPLv2.1+ (core library)
 GNUTLS_LICENSE_FILES = COPYING COPYING.LESSER
 GNUTLS_DEPENDENCIES = host-pkgconf libtasn1 nettle pcre
 GNUTLS_CONF_OPTS = \