| Message ID | 1467403317-16425-1-git-send-email-abrodkin@synopsys.com |
|---|---|
| State | Accepted |
| Commit | 0ce3963a62df423a939c6f8f9d1f961a71d5d74f |
| Headers | show |
>>>>> "Alexey" == Alexey Brodkin <Alexey.Brodkin@synopsys.com> writes: > According to current "include/configs/sunxi-common.h" > U-Boot environment is stored on SD-card with offset 544 kB > and its size is limited as 128 kB. > Given memory layout of sunxi boards: > 1. SPL > 2. U-Boot > 3. U-Boot environment > 4. Partitions > we need to make sure the first real partition starts at least > with 544+128 kB offset. Adding a small safety gap let's put > the first partition with offset 1Mb from the beginning of SD-card. > Otherwise current setup gets broken as soon as one saves U-Boot > environment with "saveenv" which basically overwrites FAT partition with > zImage and board no longer boots into Linux kernel. > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> > Cc: Erico Nunes <nunes.erico@gmail.com> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Cc: Peter Korsgaard <peter@korsgaard.com> > Cc: Carlos Quijano <carlos@crqgestion.es> > Cc: Andi Shyti <andi@etezian.org> > --- > board/cubietech/cubieboard2/genimage.cfg | 1 + > 1 file changed, 1 insertion(+) > diff --git a/board/cubietech/cubieboard2/genimage.cfg b/board/cubietech/cubieboard2/genimage.cfg > index 8929a72..cde78e1 100644 > --- a/board/cubietech/cubieboard2/genimage.cfg > +++ b/board/cubietech/cubieboard2/genimage.cfg > @@ -26,6 +26,7 @@ image sdcard.img { > partition-type = 0xC > bootable = "true" > image = "boot.vfat" > + offset = 1048576 Thanks. I prefer to add the padding to the u-boot "partition", as that is logically where it belongs, so I've instead set the size of that one to 1MB - 8K, and committed - Thanks. We need to do the same for the other sunxi boards as well. I'll do so now.
diff --git a/board/cubietech/cubieboard2/genimage.cfg b/board/cubietech/cubieboard2/genimage.cfg index 8929a72..cde78e1 100644 --- a/board/cubietech/cubieboard2/genimage.cfg +++ b/board/cubietech/cubieboard2/genimage.cfg @@ -26,6 +26,7 @@ image sdcard.img { partition-type = 0xC bootable = "true" image = "boot.vfat" + offset = 1048576 } partition rootfs {
According to current "include/configs/sunxi-common.h" U-Boot environment is stored on SD-card with offset 544 kB and its size is limited as 128 kB. Given memory layout of sunxi boards: 1. SPL 2. U-Boot 3. U-Boot environment 4. Partitions we need to make sure the first real partition starts at least with 544+128 kB offset. Adding a small safety gap let's put the first partition with offset 1Mb from the beginning of SD-card. Otherwise current setup gets broken as soon as one saves U-Boot environment with "saveenv" which basically overwrites FAT partition with zImage and board no longer boots into Linux kernel. Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> Cc: Erico Nunes <nunes.erico@gmail.com> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Peter Korsgaard <peter@korsgaard.com> Cc: Carlos Quijano <carlos@crqgestion.es> Cc: Andi Shyti <andi@etezian.org> --- board/cubietech/cubieboard2/genimage.cfg | 1 + 1 file changed, 1 insertion(+)