| Message ID | 1464366101-637-1-git-send-email-nerv@dawncrow.de |
|---|---|
| State | Changes Requested |
| Headers | show |
Hi, Some notes on my patch: Without it fftw fails to configure when the toolchain has threads and openmp checking for OpenMP flag of C compiler... -fopenmp configure: error: --with-combined-threads incompatible with --enable-openmp I'm not sure if my approach is what you would have in mind... should I rather use ifeq,else,endif as in the block above or do you have a good suggestion to make --with-combined-threads mutual exclusive between threads and openmp? Am 27.05.2016 um 18:21 schrieb André Hentschel: > Signed-off-by: André Hentschel <nerv@dawncrow.de> > --- > package/fftw/fftw.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/fftw/fftw.mk b/package/fftw/fftw.mk > index 5045ab6..f4b1794 100644 > --- a/package/fftw/fftw.mk > +++ b/package/fftw/fftw.mk > @@ -35,7 +35,7 @@ FFTW_CONF_OPTS += --enable-threads --with-combined-threads > else > FFTW_CONF_OPTS += --disable-threads > endif > -FFTW_CONF_OPTS += $(if $(BR2_GCC_ENABLE_OPENMP),--enable,--disable)-openmp > +FFTW_CONF_OPTS += $(if $(BR2_GCC_ENABLE_OPENMP),--without-combined-threads --enable,--disable)-openmp > > FFTW_CONF_OPTS += CFLAGS="$(FFTW_CFLAGS)" > >
diff --git a/package/fftw/fftw.mk b/package/fftw/fftw.mk index 5045ab6..f4b1794 100644 --- a/package/fftw/fftw.mk +++ b/package/fftw/fftw.mk @@ -35,7 +35,7 @@ FFTW_CONF_OPTS += --enable-threads --with-combined-threads else FFTW_CONF_OPTS += --disable-threads endif -FFTW_CONF_OPTS += $(if $(BR2_GCC_ENABLE_OPENMP),--enable,--disable)-openmp +FFTW_CONF_OPTS += $(if $(BR2_GCC_ENABLE_OPENMP),--without-combined-threads --enable,--disable)-openmp FFTW_CONF_OPTS += CFLAGS="$(FFTW_CFLAGS)"
Signed-off-by: André Hentschel <nerv@dawncrow.de> --- package/fftw/fftw.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)