| Message ID | 1454443064-14269-11-git-send-email-fhunleth@troodon-software.com |
|---|---|
| State | Accepted |
| Headers | show |
Hi Frank, All, Le 02/02/2016 20:57, Frank Hunleth a écrit : > As part of the version change, the package name changed to use an > underscore rather than a hyphen. Fortunately, the name change doesn't > affect the Config.in option, so no legacy handling is needed. I don't understand why we need to rename the Buildroot package here. Best regards, Romain > > Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com> > --- > package/Config.in | 2 +- > package/{erlang-p1-stun => erlang-p1_stun}/Config.in | 4 ++-- > .../erlang-p1-stun.mk => erlang-p1_stun/erlang-p1_stun.mk} | 6 +++--- > 3 files changed, 6 insertions(+), 6 deletions(-) > rename package/{erlang-p1-stun => erlang-p1_stun}/Config.in (70%) > rename package/{erlang-p1-stun/erlang-p1-stun.mk => erlang-p1_stun/erlang-p1_stun.mk} (77%) > > diff --git a/package/Config.in b/package/Config.in > index e576c92..c5a7734 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -476,7 +476,7 @@ menu "Erlang libraries/modules" > source "package/erlang-p1-iconv/Config.in" > source "package/erlang-p1-sip/Config.in" > source "package/erlang-p1-stringprep/Config.in" > - source "package/erlang-p1-stun/Config.in" > + source "package/erlang-p1_stun/Config.in" > source "package/erlang-p1-tls/Config.in" > source "package/erlang-p1-utils/Config.in" > source "package/erlang-p1-xml/Config.in" > diff --git a/package/erlang-p1-stun/Config.in b/package/erlang-p1_stun/Config.in > similarity index 70% > rename from package/erlang-p1-stun/Config.in > rename to package/erlang-p1_stun/Config.in > index 70cdd91..b3f56de 100644 > --- a/package/erlang-p1-stun/Config.in > +++ b/package/erlang-p1_stun/Config.in > @@ -1,6 +1,6 @@ > config BR2_PACKAGE_ERLANG_P1_STUN > - bool "erlang-p1-stun" > - select BR2_PACKAGE_ERLANG_P1_TLS > + bool "erlang-p1_stun" > + select BR2_PACKAGE_ERLANG_FAST_TLS > select BR2_PACKAGE_ERLANG_P1_UTILS > help > STUN library for Erlang > diff --git a/package/erlang-p1-stun/erlang-p1-stun.mk b/package/erlang-p1_stun/erlang-p1_stun.mk > similarity index 77% > rename from package/erlang-p1-stun/erlang-p1-stun.mk > rename to package/erlang-p1_stun/erlang-p1_stun.mk > index 7920347..d689585 100644 > --- a/package/erlang-p1-stun/erlang-p1-stun.mk > +++ b/package/erlang-p1_stun/erlang-p1_stun.mk > @@ -1,14 +1,14 @@ > ################################################################################ > # > -# erlang-p1-stun > +# erlang-p1_stun > # > ################################################################################ > > -ERLANG_P1_STUN_VERSION = a3dce07 > +ERLANG_P1_STUN_VERSION = 0.9.0 > ERLANG_P1_STUN_SITE = $(call github,processone,stun,$(ERLANG_P1_STUN_VERSION)) > ERLANG_P1_STUN_LICENSE = GPLv2+ > ERLANG_P1_STUN_LICENSE_FILES = COPYING > -ERLANG_P1_STUN_DEPENDENCIES = erlang-p1-tls erlang-p1-utils > +ERLANG_P1_STUN_DEPENDENCIES = erlang-fast_tls erlang-p1-utils > ERLANG_P1_STUN_INSTALL_STAGING = YES > > $(eval $(rebar-package)) >
Hi Romain, On Sat, Feb 6, 2016 at 5:52 PM, Romain Naour <romain.naour@gmail.com> wrote: > Hi Frank, All, > > Le 02/02/2016 20:57, Frank Hunleth a écrit : >> As part of the version change, the package name changed to use an >> underscore rather than a hyphen. Fortunately, the name change doesn't >> affect the Config.in option, so no legacy handling is needed. > > I don't understand why we need to rename the Buildroot package here. I renamed it for consistency with upstream. However, now that I look into it, the rest of the erlang-p1-* packages could be renamed erlang-p1_* by the same logic. I think that I'll revert the renaming here and bump the version rather than tackling everything in this patch set. Frank > > Best regards, > Romain > >> >> Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com> >> --- >> package/Config.in | 2 +- >> package/{erlang-p1-stun => erlang-p1_stun}/Config.in | 4 ++-- >> .../erlang-p1-stun.mk => erlang-p1_stun/erlang-p1_stun.mk} | 6 +++--- >> 3 files changed, 6 insertions(+), 6 deletions(-) >> rename package/{erlang-p1-stun => erlang-p1_stun}/Config.in (70%) >> rename package/{erlang-p1-stun/erlang-p1-stun.mk => erlang-p1_stun/erlang-p1_stun.mk} (77%) >> >> diff --git a/package/Config.in b/package/Config.in >> index e576c92..c5a7734 100644 >> --- a/package/Config.in >> +++ b/package/Config.in >> @@ -476,7 +476,7 @@ menu "Erlang libraries/modules" >> source "package/erlang-p1-iconv/Config.in" >> source "package/erlang-p1-sip/Config.in" >> source "package/erlang-p1-stringprep/Config.in" >> - source "package/erlang-p1-stun/Config.in" >> + source "package/erlang-p1_stun/Config.in" >> source "package/erlang-p1-tls/Config.in" >> source "package/erlang-p1-utils/Config.in" >> source "package/erlang-p1-xml/Config.in" >> diff --git a/package/erlang-p1-stun/Config.in b/package/erlang-p1_stun/Config.in >> similarity index 70% >> rename from package/erlang-p1-stun/Config.in >> rename to package/erlang-p1_stun/Config.in >> index 70cdd91..b3f56de 100644 >> --- a/package/erlang-p1-stun/Config.in >> +++ b/package/erlang-p1_stun/Config.in >> @@ -1,6 +1,6 @@ >> config BR2_PACKAGE_ERLANG_P1_STUN >> - bool "erlang-p1-stun" >> - select BR2_PACKAGE_ERLANG_P1_TLS >> + bool "erlang-p1_stun" >> + select BR2_PACKAGE_ERLANG_FAST_TLS >> select BR2_PACKAGE_ERLANG_P1_UTILS >> help >> STUN library for Erlang >> diff --git a/package/erlang-p1-stun/erlang-p1-stun.mk b/package/erlang-p1_stun/erlang-p1_stun.mk >> similarity index 77% >> rename from package/erlang-p1-stun/erlang-p1-stun.mk >> rename to package/erlang-p1_stun/erlang-p1_stun.mk >> index 7920347..d689585 100644 >> --- a/package/erlang-p1-stun/erlang-p1-stun.mk >> +++ b/package/erlang-p1_stun/erlang-p1_stun.mk >> @@ -1,14 +1,14 @@ >> ################################################################################ >> # >> -# erlang-p1-stun >> +# erlang-p1_stun >> # >> ################################################################################ >> >> -ERLANG_P1_STUN_VERSION = a3dce07 >> +ERLANG_P1_STUN_VERSION = 0.9.0 >> ERLANG_P1_STUN_SITE = $(call github,processone,stun,$(ERLANG_P1_STUN_VERSION)) >> ERLANG_P1_STUN_LICENSE = GPLv2+ >> ERLANG_P1_STUN_LICENSE_FILES = COPYING >> -ERLANG_P1_STUN_DEPENDENCIES = erlang-p1-tls erlang-p1-utils >> +ERLANG_P1_STUN_DEPENDENCIES = erlang-fast_tls erlang-p1-utils >> ERLANG_P1_STUN_INSTALL_STAGING = YES >> >> $(eval $(rebar-package)) >>
Dear Frank Hunleth, On Tue, 2 Feb 2016 14:57:36 -0500, Frank Hunleth wrote: > As part of the version change, the package name changed to use an > underscore rather than a hyphen. Fortunately, the name change doesn't > affect the Config.in option, so no legacy handling is needed. > > Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com> As suggested by Romain in his review, I've dropped the rename. Generally speaking, when things aren't clear between _ and -, I very much prefer to see - used in package name (though I admit this is a personal preference). > config BR2_PACKAGE_ERLANG_P1_STUN > - bool "erlang-p1-stun" > - select BR2_PACKAGE_ERLANG_P1_TLS > + bool "erlang-p1_stun" > + select BR2_PACKAGE_ERLANG_FAST_TLS Build testing has shown that BR2_PACKAGE_ERLANG_FAST_TLS was not the proper dependency, and instead keeping BR2_PACKAGE_ERLANG_P1_TLS was the right solution. Could you double check why you switched to fast_tls ? So, I've applied to next, with the following changes: [Thomas: - do only the version bump, not the package rename, as suggested by Romain Naour - erlang-p1-stun continues to depend on erlang-p1-tls, not erlang-fast_tls.] Thanks! Thomas
Hi Thomas, On Sat, Feb 20, 2016 at 5:30 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear Frank Hunleth, > > On Tue, 2 Feb 2016 14:57:36 -0500, Frank Hunleth wrote: >> As part of the version change, the package name changed to use an >> underscore rather than a hyphen. Fortunately, the name change doesn't >> affect the Config.in option, so no legacy handling is needed. >> >> Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com> > > As suggested by Romain in his review, I've dropped the rename. > Generally speaking, when things aren't clear between _ and -, I very > much prefer to see - used in package name (though I admit this is a > personal preference). Yes, I generally have the same preference. In the Erlang world, the style is to use underscores since module names can be represented as atoms. In theory, you can quote atoms if you want them to have hyphens, but it doesn't look pretty. In the end, I don't think that it bothers me either way, so I'm happy to leave it as is. > > >> config BR2_PACKAGE_ERLANG_P1_STUN >> - bool "erlang-p1-stun" >> - select BR2_PACKAGE_ERLANG_P1_TLS >> + bool "erlang-p1_stun" >> + select BR2_PACKAGE_ERLANG_FAST_TLS > > Build testing has shown that BR2_PACKAGE_ERLANG_FAST_TLS was not the > proper dependency, and instead keeping BR2_PACKAGE_ERLANG_P1_TLS was > the right solution. Could you double check why you switched to > fast_tls ? This was a mistake on my part. I fixed it in a patch that I hadn't sent to the list, so thanks for fixing that for me. Frank > > So, I've applied to next, with the following changes: > > [Thomas: > - do only the version bump, not the package rename, as suggested by > Romain Naour > - erlang-p1-stun continues to depend on erlang-p1-tls, not > erlang-fast_tls.] > > Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com
Hello, On Sat, 20 Feb 2016 18:09:20 -0500, Frank Hunleth wrote: > Yes, I generally have the same preference. In the Erlang world, the > style is to use underscores since module names can be represented as > atoms. In theory, you can quote atoms if you want them to have > hyphens, but it doesn't look pretty. In the end, I don't think that it > bothers me either way, so I'm happy to leave it as is. Ok, fine. > >> config BR2_PACKAGE_ERLANG_P1_STUN > >> - bool "erlang-p1-stun" > >> - select BR2_PACKAGE_ERLANG_P1_TLS > >> + bool "erlang-p1_stun" > >> + select BR2_PACKAGE_ERLANG_FAST_TLS > > > > Build testing has shown that BR2_PACKAGE_ERLANG_FAST_TLS was not the > > proper dependency, and instead keeping BR2_PACKAGE_ERLANG_P1_TLS was > > the right solution. Could you double check why you switched to > > fast_tls ? > > This was a mistake on my part. I fixed it in a patch that I hadn't > sent to the list, so thanks for fixing that for me. So, is the fast_tls package still useful? Thomas
Hi Thomas, On Sat, Feb 20, 2016 at 6:12 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Hello, > > On Sat, 20 Feb 2016 18:09:20 -0500, Frank Hunleth wrote: > >> Yes, I generally have the same preference. In the Erlang world, the >> style is to use underscores since module names can be represented as >> atoms. In theory, you can quote atoms if you want them to have >> hyphens, but it doesn't look pretty. In the end, I don't think that it >> bothers me either way, so I'm happy to leave it as is. > > Ok, fine. > >> >> config BR2_PACKAGE_ERLANG_P1_STUN >> >> - bool "erlang-p1-stun" >> >> - select BR2_PACKAGE_ERLANG_P1_TLS >> >> + bool "erlang-p1_stun" >> >> + select BR2_PACKAGE_ERLANG_FAST_TLS >> > >> > Build testing has shown that BR2_PACKAGE_ERLANG_FAST_TLS was not the >> > proper dependency, and instead keeping BR2_PACKAGE_ERLANG_P1_TLS was >> > the right solution. Could you double check why you switched to >> > fast_tls ? >> >> This was a mistake on my part. I fixed it in a patch that I hadn't >> sent to the list, so thanks for fixing that for me. > > So, is the fast_tls package still useful? No. I'll send a patch that removes it. Frank
diff --git a/package/Config.in b/package/Config.in index e576c92..c5a7734 100644 --- a/package/Config.in +++ b/package/Config.in @@ -476,7 +476,7 @@ menu "Erlang libraries/modules" source "package/erlang-p1-iconv/Config.in" source "package/erlang-p1-sip/Config.in" source "package/erlang-p1-stringprep/Config.in" - source "package/erlang-p1-stun/Config.in" + source "package/erlang-p1_stun/Config.in" source "package/erlang-p1-tls/Config.in" source "package/erlang-p1-utils/Config.in" source "package/erlang-p1-xml/Config.in" diff --git a/package/erlang-p1-stun/Config.in b/package/erlang-p1_stun/Config.in similarity index 70% rename from package/erlang-p1-stun/Config.in rename to package/erlang-p1_stun/Config.in index 70cdd91..b3f56de 100644 --- a/package/erlang-p1-stun/Config.in +++ b/package/erlang-p1_stun/Config.in @@ -1,6 +1,6 @@ config BR2_PACKAGE_ERLANG_P1_STUN - bool "erlang-p1-stun" - select BR2_PACKAGE_ERLANG_P1_TLS + bool "erlang-p1_stun" + select BR2_PACKAGE_ERLANG_FAST_TLS select BR2_PACKAGE_ERLANG_P1_UTILS help STUN library for Erlang diff --git a/package/erlang-p1-stun/erlang-p1-stun.mk b/package/erlang-p1_stun/erlang-p1_stun.mk similarity index 77% rename from package/erlang-p1-stun/erlang-p1-stun.mk rename to package/erlang-p1_stun/erlang-p1_stun.mk index 7920347..d689585 100644 --- a/package/erlang-p1-stun/erlang-p1-stun.mk +++ b/package/erlang-p1_stun/erlang-p1_stun.mk @@ -1,14 +1,14 @@ ################################################################################ # -# erlang-p1-stun +# erlang-p1_stun # ################################################################################ -ERLANG_P1_STUN_VERSION = a3dce07 +ERLANG_P1_STUN_VERSION = 0.9.0 ERLANG_P1_STUN_SITE = $(call github,processone,stun,$(ERLANG_P1_STUN_VERSION)) ERLANG_P1_STUN_LICENSE = GPLv2+ ERLANG_P1_STUN_LICENSE_FILES = COPYING -ERLANG_P1_STUN_DEPENDENCIES = erlang-p1-tls erlang-p1-utils +ERLANG_P1_STUN_DEPENDENCIES = erlang-fast_tls erlang-p1-utils ERLANG_P1_STUN_INSTALL_STAGING = YES $(eval $(rebar-package))
As part of the version change, the package name changed to use an underscore rather than a hyphen. Fortunately, the name change doesn't affect the Config.in option, so no legacy handling is needed. Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com> --- package/Config.in | 2 +- package/{erlang-p1-stun => erlang-p1_stun}/Config.in | 4 ++-- .../erlang-p1-stun.mk => erlang-p1_stun/erlang-p1_stun.mk} | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) rename package/{erlang-p1-stun => erlang-p1_stun}/Config.in (70%) rename package/{erlang-p1-stun/erlang-p1-stun.mk => erlang-p1_stun/erlang-p1_stun.mk} (77%)