diff mbox

[1/2] package/nginx: fix a typo

Message ID 1446662767-15730-1-git-send-email-nrubinstein@aldebaran.com
State Accepted
Headers show

Commit Message

=?UTF-8?q?No=C3=A9=20Rubinstein?= Nov. 4, 2015, 6:46 p.m. UTC 
Signed-off-by: Noé Rubinstein <nrubinstein@aldebaran.com>
---
 package/nginx/nginx.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Petazzoni Nov. 4, 2015, 8:49 p.m. UTC | #1 
Dear Noé Rubinstein,

On Wed,  4 Nov 2015 19:46:06 +0100, Noé Rubinstein wrote:
> Signed-off-by: Noé Rubinstein <nrubinstein@aldebaran.com>
> ---
>  package/nginx/nginx.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Both patches applied, thanks!

For the second patch, it would be good if someone could modify makedevs
to not accept user/group specified as strings, since resolving them
from the host point of view doesn't make any sense.

Thanks!

Thomas
Arnout Vandecappelle Nov. 4, 2015, 10:51 p.m. UTC | #2 
On 04-11-15 21:49, Thomas Petazzoni wrote:
> Dear Noé Rubinstein,
> 
> On Wed,  4 Nov 2015 19:46:06 +0100, Noé Rubinstein wrote:
>> Signed-off-by: Noé Rubinstein <nrubinstein@aldebaran.com>
>> ---
>>  package/nginx/nginx.mk | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Both patches applied, thanks!
> 
> For the second patch, it would be good if someone could modify makedevs
> to not accept user/group specified as strings, since resolving them
> from the host point of view doesn't make any sense.

 Or better yet, use the target passwd and group files...

 Regards,
 Arnout
diff mbox

Patch

diff --git a/package/nginx/nginx.mk b/package/nginx/nginx.mk
index 32a337c..8e23bd8 100644
--- a/package/nginx/nginx.mk
+++ b/package/nginx/nginx.mk
@@ -19,7 +19,7 @@  NGINX_CONF_OPTS = \
 
 # www-data user and group are used for nginx. Because these user and group
 # are already set by buildroot, it is not necessary to redefine them.
-# See system/skeleton/passwd
+# See system/skeleton/etc/passwd
 #   username: www-data    uid: 33
 #   groupname: www-data   gid: 33
 #