diff mbox

skeleton: add "operator" group

Message ID 1446048540-25164-1-git-send-email-jezz@sysmic.org
State Accepted
Commit 78521ca8bd2f8b7722521e2e9055dd59b8d9fc54
Headers show

Commit Message

Jérôme Pouiller Oct. 28, 2015, 4:09 p.m. UTC
gid 37 was referenced in /etc/passwd but not in /etc/group

Signed-off-by: Jérôme Pouiller <jezz@sysmic.org>
---
 system/skeleton/etc/group | 1 +
 1 file changed, 1 insertion(+)

Comments

Peter Korsgaard Oct. 28, 2015, 10:35 p.m. UTC | #1
>>>>> "Jérôme" == Jérôme Pouiller <jezz@sysmic.org> writes:

 > gid 37 was referenced in /etc/passwd but not in /etc/group
 > Signed-off-by: Jérôme Pouiller <jezz@sysmic.org>
 > ---
 >  system/skeleton/etc/group | 1 +
 >  1 file changed, 1 insertion(+)

 > diff --git a/system/skeleton/etc/group b/system/skeleton/etc/group
 > index ba20e90..c813da2 100644
 > --- a/system/skeleton/etc/group
 > +++ b/system/skeleton/etc/group
 > @@ -16,6 +16,7 @@ video:x:28:
 >  audio:x:29:
 >  tape:x:32:
 >  www-data:x:33:
 > +operator:x:37:

Committed, thanks.

I guess this means it wasn't used anywhere? Perhaps we should better
remove the user/group?
Jérôme Pouiller Oct. 29, 2015, 10:08 a.m. UTC | #2
On Wednesday 28 October 2015 23:35:15 Peter Korsgaard wrote:
> >>>>> "Jérôme" == Jérôme Pouiller <jezz@sysmic.org> writes:
>  > gid 37 was referenced in /etc/passwd but not in /etc/group
>  > Signed-off-by: Jérôme Pouiller <jezz@sysmic.org>
>  > ---
>  > 
>  >  system/skeleton/etc/group | 1 +
>  >  1 file changed, 1 insertion(+)
>  > 
>  > diff --git a/system/skeleton/etc/group b/system/skeleton/etc/group
>  > index ba20e90..c813da2 100644
>  > --- a/system/skeleton/etc/group
>  > +++ b/system/skeleton/etc/group
>  > 
>  > @@ -16,6 +16,7 @@ video:x:28:
>  >  audio:x:29:
>  >  tape:x:32:
>  > 
>  >  www-data:x:33:
>  > +operator:x:37:
> Committed, thanks.
> 
> I guess this means it wasn't used anywhere? Perhaps we should better
> remove the user/group?

In fact, I think many users/groups are useless. According to [1] and 
after checked groups used by udev:

  - groups "wheel", "operator", "staff", "lock", "netdev" and users
    "operator", "sync" can been safely removed

  - I think users/groups "daemon", "bin" and "sys" are now obsolete and
    can also been removed

  - "mail" and "www-data" should only exist if an MTA/webserver is
    enabled.

  - udev use "input" group (currently "input" group exist only if
    systemd is enabled)

  - group of /etc/shadow should be "shadow"

In add, since skeleton is now a real package we may define users and 
groups using SKELETON_USERS variable instead of maintaining 
passwd/group/shadow.

I can do these changes if there is a consensus on it.

[1] 
http://wiki.gacq.com/index.php/Debian_default_system_groups_description

BR,
diff mbox

Patch

diff --git a/system/skeleton/etc/group b/system/skeleton/etc/group
index ba20e90..c813da2 100644
--- a/system/skeleton/etc/group
+++ b/system/skeleton/etc/group
@@ -16,6 +16,7 @@  video:x:28:
 audio:x:29:
 tape:x:32:
 www-data:x:33:
+operator:x:37:
 utmp:x:43:
 plugdev:x:46:
 staff:x:50: