diff mbox

[v4,3/3] download: get rid of trailing slash removal hack for FOO_SITE

Message ID 1443892938-17039-4-git-send-email-luca@lucaceresoli.net
State Accepted
Headers show

Commit Message

Luca Ceresoli Oct. 3, 2015, 5:22 p.m. UTC
Not needed anymore since the URLs have been cleared, the manual states
they are illegal and a check has been introduced to notice future
mistakes.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

---
No changes in v4.

Changes v2 -> v3:
 - move after the commit on docs/manual, update commit message.

Changes v1 -> v2:
 - redo on current master.
---
 package/pkg-generic.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Arnout Vandecappelle Oct. 4, 2015, 12:39 p.m. UTC | #1
On 03-10-15 18:22, Luca Ceresoli wrote:
> Not needed anymore since the URLs have been cleared, the manual states
> they are illegal and a check has been introduced to notice future
> mistakes.
> 
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


 Regards,
 Arnout

> 
> ---
> No changes in v4.
> 
> Changes v2 -> v3:
>  - move after the commit on docs/manual, update commit message.
> 
> Changes v1 -> v2:
>  - redo on current master.
> ---
>  package/pkg-generic.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index de2fb07..3942a89 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -388,7 +388,7 @@ endif
>  $(2)_ALL_DOWNLOADS = \
>  	$$(foreach p,$$($(2)_SOURCE) $$($(2)_PATCH) $$($(2)_EXTRA_DOWNLOADS),\
>  		$$(if $$(findstring ://,$$(p)),$$(p),\
> -			$$($(2)_SITE:/=)/$$(p)))
> +			$$($(2)_SITE)/$$(p)))
>  
>  ifndef $(2)_SITE
>   ifdef $(3)_SITE
>
diff mbox

Patch

diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index de2fb07..3942a89 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -388,7 +388,7 @@  endif
 $(2)_ALL_DOWNLOADS = \
 	$$(foreach p,$$($(2)_SOURCE) $$($(2)_PATCH) $$($(2)_EXTRA_DOWNLOADS),\
 		$$(if $$(findstring ://,$$(p)),$$(p),\
-			$$($(2)_SITE:/=)/$$(p)))
+			$$($(2)_SITE)/$$(p)))
 
 ifndef $(2)_SITE
  ifdef $(3)_SITE